Hangyu Hua
51fb8c2c10
dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock ...
[ Upstream commit a41b17ff9dacd22f5f118ee53d82da0f3e52d5e3 ]
In the case of sk->dccps_qpolicy == DCCPQ_POLICY_PRIO, dccp_qpolicy_full
will drop a skb when qpolicy is full. And the lock in dccp_sendmsg is
released before sock_alloc_send_skb and then relocked after
sock_alloc_send_skb. The following conditions may lead dccp_qpolicy_push
to add skb to an already full sk_write_queue:
thread1--->lock
thread1--->dccp_qpolicy_full: queue is full. drop a skb
thread1--->unlock
thread2--->lock
thread2--->dccp_qpolicy_full: queue is not full. no need to drop.
thread2--->unlock
thread1--->lock
thread1--->dccp_qpolicy_push: add a skb. queue is full.
thread1--->unlock
thread2--->lock
thread2--->dccp_qpolicy_push: add a skb!
thread2--->unlock
Fix this by moving dccp_qpolicy_full.
Fixes: b1308dc015https://lore.kernel.org/r/20220729110027.40569-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-08-25 11:17:49 +02:00
6lowpan: iphc: Fix an off-by-one check of array index
2021-09-15 09:47:31 +02:00
xen/9p: use alloc/free_pages_exact()
2022-03-11 11:22:39 +01:00
net/802/garp: fix memleak in garp_request_join()
2021-07-31 08:19:38 +02:00
net: vlan: fix underflow for the real_dev refcnt
2021-12-01 09:23:34 +01:00
appletalk: Fix skb allocation size in loopback case
2021-04-07 14:47:41 +02:00
ax25: Fix UAF bugs in ax25 timers
2022-04-20 09:19:40 +02:00
batman-adv: Don't skb_split skbuffs with frag_list
2022-05-18 09:47:24 +02:00
Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put
2022-08-03 11:59:37 +02:00
bpfilter: Specify the log level for the kmsg message
2021-07-14 16:53:33 +02:00
netfilter: br_netfilter: do not skip all hooks with 0 priority
2022-07-21 20:59:24 +02:00
net-caif: avoid user-triggerable WARN_ON(1)
2021-09-22 12:26:40 +02:00
can: bcm: use call_rcu() instead of costly synchronize_rcu()
2022-07-12 16:30:46 +02:00
libceph: clear con->out_msg on Policy::stateful_server faults
2020-11-05 11:43:34 +01:00
tcp: Fix data-races around sysctl knobs related to SYN option.
2022-07-29 17:14:14 +02:00
net: dcb: disable softirqs in dcbnl_flush_dev()
2022-03-08 19:07:51 +01:00
dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock
2022-08-25 11:17:49 +02:00
net: decnet: Fix sleeping inside in af_decnet
2021-07-28 13:30:56 +02:00
net: dsa: Add missing of_node_put() in dsa_port_parse_of
2022-03-23 09:12:07 +01:00
hsr: use netdev_err() instead of WARN_ONCE()
2021-05-14 09:44:10 +02:00
net: ieee802154: Return meaningful error codes from the netlink helpers
2022-02-08 18:24:31 +01:00
tcp: make retransmitted SKB fit into the send window
2022-08-25 11:17:43 +02:00
net: ping6: Fix memleak in ipv6_renew_options().
2022-08-03 11:59:39 +02:00
net/af_iucv: remove WARN_ONCE on malformed RX packets
2021-03-07 12:20:42 +01:00
Revert "net: af_key: add check for pfkey_broadcast in function pfkey_process"
2022-06-14 18:12:01 +02:00
ipv6: Fix signed integer overflow in l2tp_ip6_sendmsg
2022-06-22 14:11:21 +02:00
l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu
2022-04-27 13:50:47 +02:00
net: lapb: Copy the skb before sending a packet
2021-02-10 09:25:28 +01:00
llc: only change llc->dev when bind() succeeds
2022-03-28 08:46:48 +02:00
wifi: mac80211: fix queue selection for mesh/OCB interfaces
2022-07-21 20:59:17 +02:00
net: mac802154: Fix general protection fault
2021-04-14 08:24:18 +02:00
net: mpls: Fix notifications when deleting a device
2021-12-08 09:01:12 +01:00
net/ncsi: check for error return from call to nla_put_u32
2022-01-05 12:37:45 +01:00
netfilter: nf_tables: fix null deref due to zeroed list head
2022-08-25 11:17:27 +02:00
netlabel: fix out-of-bounds memory accesses
2022-04-15 14:18:35 +02:00
netlink: do not reset transport header in netlink_recvmsg()
2022-05-18 09:47:25 +02:00
netrom: Decrease sock refcount when sock timers expire
2021-07-28 13:30:56 +02:00
NFC: NULL out the dev->rfkill to prevent UAF
2022-06-14 18:11:33 +02:00
net: openvswitch: fix parsing of nw_proto for IPv6 fragments
2022-06-29 08:58:44 +02:00
net/packet: fix packet_sock xmit return value checking
2022-04-27 13:50:47 +02:00
phonet: refcount leak in pep_sock_accep
2022-01-11 15:23:33 +01:00
net: qrtr: fix another OOB Read in qrtr_endpoint_post
2021-09-03 10:08:12 +02:00
rds: memory leak in __rds_conn_create()
2021-12-22 09:29:37 +01:00
rfkill: Fix use-after-free in rfkill_resume()
2020-11-24 13:29:05 +01:00
net: rose: fix netdev reference changes
2022-08-25 11:17:49 +02:00
rxrpc: Fix decision on when to generate an IDLE ACK
2022-06-14 18:11:38 +02:00
net/sched: act_api: Notify user space if any actions were flushed before error
2022-07-07 17:36:50 +02:00
sctp: leave the err path free in sctp_stream_init to sctp_stream_free
2022-08-03 11:59:41 +02:00
net/smc: postpone sk_refcnt increment in connect()
2022-06-14 18:11:39 +02:00
bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding
2021-11-17 09:48:48 +01:00
SUNRPC: Fix READ_PLUS crasher
2022-07-07 17:36:48 +02:00
net: switchdev: do not propagate bridge updates across bridges
2021-10-27 09:54:24 +02:00
net: tipc: fix possible refcount leak in tipc_sk_create()
2022-07-21 20:59:25 +02:00
net/tls: Fix race in TLS device down flow
2022-07-29 17:14:12 +02:00
af_unix: Fix a data-race in unix_dgram_peer_wake_me().
2022-06-14 18:11:57 +02:00
vsock: remove vsock from connected table when connect is interrupted by a signal
2022-02-23 11:59:57 +01:00
nl80211: show SSID for P2P_GO interfaces
2022-06-14 18:11:32 +02:00
net/x25: Fix null-ptr-deref caused by x25_disconnect
2022-04-15 14:18:21 +02:00
Revert "xsk: Do not sleep in poll() when need_wakeup set"
2021-12-22 09:29:40 +01:00
ip: Fix data-races around sysctl_ip_no_pmtu_disc.
2022-07-29 17:14:10 +02:00
net: Return the correct errno code
2021-06-18 09:59:00 +02:00
net: don't unconditionally copy_from_user a struct ifreq for socket ioctls
2021-09-03 10:08:16 +02:00
51fb8c2c10