Zhenzhong Duan
f39406a925
ttyprintk: fix a potential deadlock in interrupt context issue ...
commit 9a655c77ff8fc65699a3f98e237db563b37c439b upstream.
tpk_write()/tpk_close() could be interrupted when holding a mutex, then
in timer handler tpk_write() may be called again trying to acquire same
mutex, lead to deadlock.
Google syzbot reported this issue with CONFIG_DEBUG_ATOMIC_SLEEP
enabled:
BUG: sleeping function called from invalid context at
kernel/locking/mutex.c:938
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 0, name: swapper/1
1 lock held by swapper/1/0:
...
Call Trace:
<IRQ>
dump_stack+0x197/0x210
___might_sleep.cold+0x1fb/0x23e
__might_sleep+0x95/0x190
__mutex_lock+0xc5/0x13c0
mutex_lock_nested+0x16/0x20
tpk_write+0x5d/0x340
resync_tnc+0x1b6/0x320
call_timer_fn+0x1ac/0x780
run_timer_softirq+0x6c3/0x1790
__do_softirq+0x262/0x98c
irq_exit+0x19b/0x1e0
smp_apic_timer_interrupt+0x1a3/0x610
apic_timer_interrupt+0xf/0x20
</IRQ>
See link https://syzkaller.appspot.com/bug?extid=2eeef62ee31f9460ad65 for
more details.
Fix it by using spinlock in process context instead of mutex and having
interrupt disabled in critical section.
Reported-by: syzbot+2eeef62ee31f9460ad65@syzkaller.appspotmail.com
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20200113034842.435-1-zhenzhong.duan@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-02-05 21:22:41 +00:00
ia64: remove support for machvecs
2019-08-16 14:32:26 -07:00
hwrng: omap3-rom - Fix missing clock by probing with device tree
2020-01-26 10:01:03 +01:00
ipmi: Fix memory leak in __ipmi_bmc_register
2020-01-26 10:01:02 +01:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
tpm: Handle negative priv->response_len in tpm_common_read()
2020-01-14 20:08:21 +01:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
PCI: Move ASPM declarations to linux/pci.h
2019-08-28 08:28:39 -05:00
char: sparc64: Add privileged ADI driver
2018-06-05 11:24:55 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
Merge 5.2-rc4 into char-misc-next
2019-06-09 09:11:21 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
vfs: do bulk POLL* -> EPOLL* replacement
2018-02-11 14:34:03 -08:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 405
2019-06-05 17:37:13 +02:00
hpet: Fix division by zero in hpet_time_div()
2019-07-25 14:39:51 +02:00
ia64 for v5.4 - big change here is removal of support for SGI Altix
2019-09-16 15:32:01 -07:00
lp: fix sparc64 LPSETTIMEOUT ioctl
2019-12-13 08:42:17 +01:00
char: remove the SGI tiocx/mbcs driver
2019-08-16 11:33:56 -07:00
Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2019-09-28 08:14:15 -07:00
char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles
2019-05-24 18:00:41 +02:00
char/mspec: remove SGI SN2 support
2019-08-16 11:33:56 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Switch DEFINE_TIMER callbacks to struct timer_list *
2017-11-21 15:57:05 -08:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
ppdev: fix PPGETTIME/PPSETTIME ioctls
2019-12-17 19:56:41 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 164
2019-05-30 11:26:38 -07:00
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-11-16 18:14:32 -08:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
tlclk: clean an indentation issue, remove extraneous tabs
2018-11-11 12:58:27 -08:00
toshiba: Add correct printk log level while emitting error log
2019-09-04 13:42:43 +02:00
ttyprintk: fix a potential deadlock in interrupt context issue
2020-02-05 21:22:41 +00:00
virtio_console: allocate inbufs in add_port() only if it is needed
2019-11-19 05:13:49 -05:00
f39406a925