Mikulas Patocka
1781fa54a4
dm writecache: fix incorrect flush sequence when doing SSD mode commit ...
commit aa9509209c5ac2f0b35d01a922bf9ae072d0c2fc upstream.
When committing state, the function writecache_flush does the following:
1. write metadata (writecache_commit_flushed)
2. flush disk cache (writecache_commit_flushed)
3. wait for data writes to complete (writecache_wait_for_ios)
4. increase superblock seq_count
5. write the superblock
6. flush disk cache
It may happen that at step 3, when we wait for some write to finish, the
disk may report the write as finished, but the write only hit the disk
cache and it is not yet stored in persistent storage. At step 5 we write
the superblock - it may happen that the superblock is written before the
write that we waited for in step 3. If the machine crashes, it may result
in incorrect data being returned after reboot.
In order to fix the bug, we must swap steps 2 and 3 in the above sequence,
so that we first wait for writes to complete and then flush the disk
cache.
Fixes: 48debafe4fstable@vger.kernel.org # 4.18+
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-02-11 04:35:26 -08:00
bcache: at least try to shrink 1 node in bch_mca_scan()
2020-01-04 19:18:11 +01:00
dm space map common: fix to ensure new block isn't already in use
2020-02-11 04:35:26 -08:00
dm bufio: introduce a global cache replacement
2019-09-13 17:00:21 -04:00
dm cache: fix bugs when a GFP_NOWAIT allocation fails
2019-10-17 11:13:50 -04:00
dm clone metadata: Use a two phase commit
2019-12-21 11:05:00 +01:00
dm clone metadata: Use a two phase commit
2019-12-21 11:05:00 +01:00
dm clone: Flush destination device before committing metadata
2019-12-21 11:05:01 +01:00
Revert "dm crypt: use WQ_HIGHPRI for the IO and crypt workqueues"
2019-11-29 10:09:44 +01:00
dm dust: use dust block size for badblocklist index
2019-08-21 11:27:17 -04:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
- Improve DM snapshot target's scalability by using finer grained
2019-05-16 15:55:48 -07:00
block: Kill gfp_t argument of blkdev_report_zones()
2019-07-11 20:04:37 -06:00
docs: device-mapper: move it to the admin-guide
2019-07-15 11:03:01 -03:00
block: centralize PI remapping logic to the block layer
2019-09-17 20:03:49 -06:00
dm: introduce DM_GET_TARGET_VERSION
2019-09-16 10:18:01 -04:00
dm kcopyd: always complete failed jobs
2019-08-15 15:57:39 -04:00
block: Kill gfp_t argument of blkdev_report_zones()
2019-07-11 20:04:37 -06:00
dm log writes: fix incorrect comment about the logged sequence example
2019-07-09 14:13:33 -04:00
dm mpath: remove harmful bio-based optimization
2019-12-21 11:04:56 +01:00
dm raid: fix updating of max_discard_sectors limit
2019-09-11 16:18:23 -04:00
dm raid1: use struct_size() with kzalloc()
2019-08-26 11:05:32 -04:00
block: Delay default elevator initialization
2019-09-05 19:52:34 -06:00
block: fix an integer overflow in logical block size
2020-01-23 08:22:32 +01:00
dm snapshot: rework COW throttling to fix deadlock
2019-10-10 09:46:05 -04:00
dm stats: use struct_size() helper
2019-09-04 09:39:22 -04:00
dm: make dm_table_find_target return NULL
2019-08-23 10:13:12 -04:00
dm thin metadata: Add support for a pre-commit callback
2019-12-21 11:05:01 +01:00
dm thin metadata: Add support for a pre-commit callback
2019-12-21 11:05:01 +01:00
dm thin: fix use-after-free in metadata_pre_commit_callback
2020-02-05 21:22:53 +00:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm writecache: fix incorrect flush sequence when doing SSD mode commit
2020-02-11 04:35:26 -08:00
dm zoned: support zone sizes smaller than 128MiB
2020-02-11 04:35:26 -08:00
dm zoned: reduce overhead of backing device checks
2019-12-17 19:56:12 +01:00
dm zoned: reduce overhead of backing device checks
2019-12-17 19:56:12 +01:00
dm zoned: reduce overhead of backing device checks
2019-12-17 19:56:12 +01:00
dm: make dm_table_find_target return NULL
2019-08-23 10:13:12 -04:00
dm: make dm_table_find_target return NULL
2019-08-23 10:13:12 -04:00
dm: add clone target
2019-09-12 09:32:31 -04:00
dm: add clone target
2019-09-12 09:32:31 -04:00
md/bitmap: avoid race window between md_bitmap_resize and bitmap_file_clear_bit
2019-12-31 16:44:20 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 47
2019-05-24 17:27:13 +02:00
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
md: make sure desc_nr less than MD_SB_DISKS
2020-01-04 19:18:34 +01:00
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
block: fix an integer overflow in logical block size
2020-01-23 08:22:32 +01:00
md/raid0: avoid RAID0 data corruption due to layout confusion.
2019-09-13 13:10:05 -07:00
md: raid1-10: Unify r{1,10}bio_pool_free
2019-06-15 01:37:35 -06:00
md: raid1: check rdev before reference in raid1_sync_request func
2020-01-09 10:19:48 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288
2019-06-05 17:36:37 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288
2019-06-05 17:36:37 +02:00
raid5: need to set STRIPE_HANDLE for batch head
2020-01-09 10:19:48 +01:00
raid5: use bio_end_sector in r5_next_bio
2019-09-13 13:14:43 -07:00
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
1781fa54a4