No description
  • C 98.2%
  • Assembly 1%
  • Makefile 0.3%
  • Shell 0.2%
  • Python 0.1%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Boqun Feng 1c322ac06d acpi/nfit: Fix COMPLETION_INITIALIZER_ONSTACK() abuse
COMPLETION_INITIALIZER_ONSTACK() is supposed to be used as an initializer,
in other words, it should only be used in assignment expressions or
compound literals. So the usage in drivers/acpi/nfit/core.c:

	COMPLETION_INITIALIZER_ONSTACK(flush.cmp);

... is inappropriate.

Besides, this usage could also break the build for another fix that
reduces stack sizes caused by COMPLETION_INITIALIZER_ONSTACK(), because
that fix changes COMPLETION_INITIALIZER_ONSTACK() from rvalue to lvalue,
and usage as above will report the following error:

	drivers/acpi/nfit/core.c: In function 'acpi_nfit_flush_probe':
	include/linux/completion.h:77:3: error: value computed is not used [-Werror=unused-value]
	  (*({ init_completion(&work); &work; }))

This patch fixes this by replacing COMPLETION_INITIALIZER_ONSTACK()
with init_completion() in acpi_nfit_flush_probe(), which does the
same initialization without any other problems.

Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: walken@google.com
Cc: willy@infradead.org
Link: http://lkml.kernel.org/r/20170824142239.15178-1-boqun.feng@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-08-29 15:14:38 +02:00
arch smp: Avoid using two cache lines for struct call_single_data 2017-08-29 15:14:38 +02:00
block smp: Avoid using two cache lines for struct call_single_data 2017-08-29 15:14:38 +02:00
certs
crypto
Documentation Documentation/locking/atomic: Finish the document... 2017-08-25 11:06:33 +02:00
drivers acpi/nfit: Fix COMPLETION_INITIALIZER_ONSTACK() abuse 2017-08-29 15:14:38 +02:00
firmware
fs Merge branch 'linus' into locking/core, to pick up fixes 2017-08-25 11:04:51 +02:00
include smp: Avoid using two cache lines for struct call_single_data 2017-08-29 15:14:38 +02:00
init
ipc
kernel locking/pvqspinlock: Relax cmpxchg's to improve performance on some architectures 2017-08-29 15:14:38 +02:00
lib locking/lockdep/selftests: Add mixed read-write ABBA tests 2017-08-25 11:06:31 +02:00
mm Merge branch 'linus' into locking/core, to pick up fixes 2017-08-25 11:04:51 +02:00
net Merge branch 'linus' into locking/core, to pick up fixes 2017-08-25 11:04:51 +02:00
samples
scripts Merge branch 'linus' into locking/core, to pick up fixes 2017-08-25 11:04:51 +02:00
security
sound
tools Merge branch 'linus' into locking/core, to pick up fixes 2017-08-25 11:04:51 +02:00
usr
virt
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap
COPYING
CREDITS
Kbuild
Kconfig
MAINTAINERS
Makefile
README

Linux kernel
============

This file was moved to Documentation/admin-guide/README.rst

Please notice that there are several guides for kernel developers and users.
These guides can be rendered in a number of formats, like HTML and PDF.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
See Documentation/00-INDEX for a list of what is contained in each file.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.