Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Linus Lüssing 07ef3f7bc5 net: bridge: mcast: fix broken length + header check for MRDv6 Adv. ... [ Upstream commit 99014088156cd78867d19514a0bc771c4b86b93b ] The IPv6 Multicast Router Advertisements parsing has the following two issues: For one thing, ICMPv6 MRD Advertisements are smaller than ICMPv6 MLD messages (ICMPv6 MRD Adv.: 8 bytes vs. ICMPv6 MLDv1/2: >= 24 bytes, assuming MLDv2 Reports with at least one multicast address entry). When ipv6_mc_check_mld_msg() tries to parse an Multicast Router Advertisement its MLD length check will fail - and it will wrongly return -EINVAL, even if we have a valid MRD Advertisement. With the returned -EINVAL the bridge code will assume a broken packet and will wrongly discard it, potentially leading to multicast packet loss towards multicast routers. The second issue is the MRD header parsing in br_ip6_multicast_mrd_rcv(): It wrongly checks for an ICMPv6 header immediately after the IPv6 header (IPv6 next header type). However according to RFC4286, section 2 all MRD messages contain a Router Alert option (just like MLD). So instead there is an IPv6 Hop-by-Hop option for the Router Alert between the IPv6 and ICMPv6 header, again leading to the bridge wrongly discarding Multicast Router Advertisements. To fix these two issues, introduce a new return value -ENODATA to ipv6_mc_check_mld() to indicate a valid ICMPv6 packet with a hop-by-hop option which is not an MLD but potentially an MRD packet. This also simplifies further parsing in the bridge code, as ipv6_mc_check_mld() already fully checks the ICMPv6 header and hop-by-hop option. These issues were found and fixed with the help of the mrdisc tool (https://github.com/troglobit/mrdisc). Fixes: 4b3087c7e3 ("bridge: Snoop Multicast Router Advertisements") Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-05-14 09:44:32 +02:00
..
netfilter	netfilter: bridge: add pre_exit hooks for ebtable unregistration	2021-04-21 12:56:16 +02:00
br.c	net: bridge: Fix a warning when del bridge sysfs	2021-02-23 15:02:25 +01:00
br_arp_nd_proxy.c
br_device.c	bridge: Fix a deadlock when enabling multicast snooping	2020-12-21 13:27:04 +01:00
br_fdb.c
br_forward.c
br_if.c
br_input.c
br_ioctl.c
br_mdb.c
br_multicast.c	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-05-14 09:44:32 +02:00
br_netfilter_hooks.c	netfilter: bridge: reset skb->pkt_type after NF_INET_POST_ROUTING traversal	2020-12-08 10:40:24 +01:00
br_netfilter_ipv6.c
br_netlink.c
br_netlink_tunnel.c
br_nf_core.c
br_private.h	bridge: Fix a deadlock when enabling multicast snooping	2020-12-21 13:27:04 +01:00
br_private_stp.h
br_private_tunnel.h
br_stp.c
br_stp_bpdu.c
br_stp_if.c
br_stp_timer.c
br_switchdev.c
br_sysfs_br.c
br_sysfs_if.c	net: bridge: use switchdev for port flags set through sysfs too	2021-03-07 12:20:43 +01:00
br_vlan.c	net: bridge: vlan: fix error return code in __vlan_add()	2020-12-21 13:27:03 +01:00
br_vlan_tunnel.c
Kconfig
Makefile