android_kernel_motorola_sm6375/scripts/mod
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Masahiro Yamada 460083de66 modpost: fix undefined behavior of is_arm_mapping_symbol()
[ Upstream commit d6b732666a1bae0df3c3ae06925043bba34502b1 ]

The return value of is_arm_mapping_symbol() is unpredictable when "$"
is passed in.

strchr(3) says:
  The strchr() and strrchr() functions return a pointer to the matched
  character or NULL if the character is not found. The terminating null
  byte is considered part of the string, so that if c is specified as
  '\0', these functions return a pointer to the terminator.

When str[1] is '\0', strchr("axtd", str[1]) is not NULL, and str[2] is
referenced (i.e. buffer overrun).

Test code
---------

  char str1[] = "abc";
  char str2[] = "ab";

  strcpy(str1, "$");
  strcpy(str2, "$");

  printf("test1: %d\n", is_arm_mapping_symbol(str1));
  printf("test2: %d\n", is_arm_mapping_symbol(str2));

Result
------

  test1: 0
  test2: 1

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-06-14 18:12:01 +02:00
..
.gitignore
devicetable-offsets.c
empty.c
file2alias.c modpost: add guid_t type definition 2019-09-04 22:55:42 +09:00
Makefile
mk_elfconfig.c
modpost.c modpost: fix undefined behavior of is_arm_mapping_symbol() 2022-06-14 18:12:01 +02:00
modpost.h symbol namespaces: revert to previous __ksymtab name scheme 2019-10-18 15:32:52 +02:00
sumversion.c kbuild: remove the first line of *.mod files 2019-07-18 02:19:31 +09:00