Linus Torvalds
8d2c0d36d6
radix tree: fix sibling entry handling in radix_tree_descend() ...
The fixes to the radix tree test suite show that the multi-order case is
broken. The basic reason is that the radix tree code uses tagged
pointers with the "internal" bit in the low bits, and calculating the
pointer indices was supposed to mask off those bits. But gcc will
notice that we then use the index to re-create the pointer, and will
avoid doing the arithmetic and use the tagged pointer directly.
This cleans the code up, using the existing is_sibling_entry() helper to
validate the sibling pointer range (instead of open-coding it), and
using entry_to_node() to mask off the low tag bit from the pointer. And
once you do that, you might as well just use the now cleaned-up pointer
directly.
[ Side note: the multi-order code isn't actually ever used in the kernel
right now, and the only reason I didn't just delete all that code is
that Kirill Shutemov piped up and said:
"Well, my ext4-with-huge-pages patchset[1] uses multi-order entries.
It also converts shmem-with-huge-pages and hugetlb to them.
I'm okay with converting it to other mechanism, but I need
something. (I looked into Konstantin's RFC patchset[2]. It looks
okay, but I don't feel myself qualified to review it as I don't
know much about radix-tree internals.)"
[1] http://lkml.kernel.org/r/20160915115523.29737-1-kirill.shutemov@linux.intel.com
[2] http://lkml.kernel.org/r/147230727479.9957.1087787722571077339.stgit@zurg ]
Reported-by: Matthew Wilcox <mawilcox@microsoft.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Cedric Blancher <cedric.blancher@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-09-25 13:32:46 -07:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2016-03-17 21:38:27 -07:00
fonts: Add 6x10 font
2014-10-09 11:35:48 +03:00
lib: lz4: cleanup unaligned access efficiency detection
2016-04-13 09:22:49 -07:00
lzo: check for length overrun in variable length encoding.
2014-09-28 11:08:01 +02:00
lib/mpi: Fix SG miter leak
2016-07-29 18:30:16 +08:00
powerpc: Create disable_kernel_{fp,altivec,vsx,spe}()
2015-12-01 13:52:25 +11:00
lib/xz: enable all filters by default in Kconfig
2014-06-04 16:54:18 -07:00
zlib_deflate/deftree: remove bi_reverse()
2015-09-10 13:29:01 -07:00
zlib: clean up some dead code
2014-08-06 18:01:24 -07:00
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2016-05-17 09:33:39 -07:00
assoc_array: don't call compare_object() on a node
2016-04-06 14:06:48 +01:00
locking/atomic: Implement atomic{,64,_long}_fetch_{add,sub,and,andnot,or,xor}{,_relaxed,_acquire,_release}()
2016-06-16 10:48:32 +02:00
locking/atomic: Implement atomic{,64,_long}_fetch_{add,sub,and,andnot,or,xor}{,_relaxed,_acquire,_release}()
2016-06-16 10:48:32 +02:00
syscalls: implement execveat() system call
2014-12-13 12:42:51 -08:00
x86/uaccess: Move thread_info::addr_limit to thread_struct
2016-07-15 10:26:30 +02:00
ARM: 8187/1: add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction
2014-12-22 16:43:06 +00:00
treewide: Remove old email address
2015-11-23 09:44:58 +01:00
lib/bug.c: use common WARN helper
2016-03-17 15:09:34 -07:00
random: replace non-blocking pool with a Chacha20-based CRNG
2016-07-03 00:57:23 -04:00
ipv4: Update parameters for csum_tcpudp_magic to their original types
2016-03-13 23:55:13 -04:00
lib/clz_ctz.c: add prototype declarations in lib/clz_ctz.c
2014-04-03 16:21:12 -07:00
lib: Add a generic cmdline parse function parse_option_str
2014-10-03 18:40:58 +01:00
sched/topology: Rename topology_thread_cpumask() to topology_sibling_cpumask()
2015-05-27 15:22:15 +02:00
cpumask: Export cpumask_any_but()
2016-02-29 09:35:20 +01:00
lib: crc-itu-t.[ch] fix 0x0x prefix in integer constants
2015-05-26 15:26:43 +02:00
lib: introduce crc_t10dif_update()
2015-05-30 22:42:24 -07:00
lib/crc7: Shift crc7() output left 1 bit
2014-05-16 14:26:52 -04:00
crc32: use ktime_get_ns() for measurement
2016-08-02 19:35:08 -04:00
kbuild: include core debug info when DEBUG_INFO_REDUCED
2015-06-11 15:08:32 +02:00
debugobjects: insulate non-fixup logic related to static obj from fixup callbacks
2016-05-19 19:12:14 -07:00
lib/decompress: set the compressor name to NULL on error
2015-07-17 16:39:54 -07:00
lib/decompressors: use real out buf size for gunzip with kernel
2015-09-10 13:29:01 -07:00
lib/decompressors: use real out buf size for gunzip with kernel
2015-09-10 13:29:01 -07:00
lib/decompressors: use real out buf size for gunzip with kernel
2015-09-10 13:29:01 -07:00
lib/decompress_unlzma: Do a NULL check for pointer
2015-09-10 13:29:01 -07:00
lib/decompressors: use real out buf size for gunzip with kernel
2015-09-10 13:29:01 -07:00
lib/decompressors: use real out buf size for gunzip with kernel
2015-09-10 13:29:01 -07:00
devres: use to_pci_dev()
2016-02-07 23:17:59 -08:00
lib/digsig: digsig_verify_rsa(): return -EINVAL if modulo length is zero
2016-05-31 16:42:00 +08:00
__div64_32(): make it overridable at compile time
2015-11-16 14:42:12 -05:00
dma-debug: track bucket lock state for static checkers
2016-07-26 16:19:19 -07:00
dma-mapping: use unsigned long for dma_attrs
2016-08-04 08:50:07 -04:00
dump_stack: avoid potential deadlocks
2016-02-05 18:10:40 -08:00
dynamic_debug: add jump label support
2016-08-04 08:50:07 -04:00
lib/dynamic_queue_limits.c: simplify includes
2015-02-12 18:54:15 -08:00
lib/cpio: Make find_cpio_data()'s offset arg optional
2016-06-08 11:04:19 +02:00
extable: add support for relative extables to search and sort routines
2016-02-24 14:57:26 +00:00
fault-inject: fix inverted interval/probability values in printk
2015-10-23 17:55:10 +09:00
lib: add fdt_empty_tree.c
2014-04-30 19:49:37 +01:00
lib: rename lib/find_next_bit.c to lib/find_bit.c
2015-04-17 09:03:54 -04:00
lib+mm: fix few spelling mistakes
2016-02-15 11:18:23 +01:00
lib/GCD.c: use binary GCD algorithm instead of Euclidean
2016-05-20 17:58:30 -07:00
lib: crc32: constify crc32 lookup table
2015-02-13 21:21:35 -08:00
CPM/QE: use genalloc to manage CPM/QE muram
2015-12-22 17:10:18 -06:00
lib/glob.c: add CONFIG_GLOB_SELFTEST
2014-08-06 18:01:25 -07:00
lib/halfmd4.c: use rol32 inline function in the ROUND macro
2015-11-06 17:50:42 -08:00
lib/hexdump.c: truncate output in case of overflow
2015-11-06 17:50:42 -08:00
x86/hweight: Get rid of the special calling convention
2016-06-08 15:01:02 +02:00
mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd
2015-11-06 17:50:42 -08:00
lib/interval_tree.c: simplify includes
2015-02-12 18:54:15 -08:00
lib: Export interval_tree
2014-05-05 09:09:14 +02:00
Kconfig: rename HAS_IOPORT to HAS_IOPORT_MAP
2014-04-07 16:36:11 -07:00
lib/iomap_copy.c: add __ioread32_copy()
2016-01-20 17:09:18 -08:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc
2015-11-05 16:34:48 -08:00
lib/iommu-helper: skip to next segment
2016-08-02 19:35:07 -04:00
x86, mm: support huge KVA mappings on x86
2015-04-14 16:49:04 -07:00
fix iov_iter_fault_in_readable()
2016-09-17 14:05:30 -07:00
irq_poll: Fix irq_poll_sched()
2016-01-19 15:26:55 -05:00
lib/is_single_threaded.c: change current_is_single_threaded() to use for_each_thread()
2015-11-06 17:50:42 -08:00
lib/kasprintf.c: add sanity check to kvasprintf
2016-01-16 11:17:27 -08:00
raxix-tree: introduce CONFIG_RADIX_TREE_MULTIORDER
2016-05-20 17:58:30 -07:00
locking/hung_task: Fix typo in CONFIG_DETECT_HUNG_TASK help text
2016-09-23 07:30:04 +02:00
mm, kasan: switch SLUB to stackdepot, enable memory quarantine for SLUB
2016-07-28 16:07:41 -07:00
kgdb: depends on VT
2016-05-23 17:04:14 -07:00
ubsan: fix tree-wide -Wmaybe-uninitialized false positives
2016-03-22 15:36:02 -07:00
kfifo: use BUG_ON
2014-08-08 15:57:25 -07:00
klist: fix starting point removed bug in klist iterators
2016-02-07 22:18:47 -08:00
kobject: export kset_find_obj() for module use
2016-02-09 17:36:34 -08:00
lib/kobject_uevent.c: remove redundant include
2015-02-12 18:54:15 -08:00
lib: add "on"/"off" support to kstrtobool
2016-03-17 15:09:34 -07:00
block: fix blk_stack_limits() regression due to lcm() change
2015-03-31 09:45:50 -06:00
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2016-01-22 11:58:43 -08:00
list: kill list_force_poison()
2016-03-09 15:43:42 -08:00
lib/list_sort: use late_initcall to hook in self tests
2015-06-16 14:12:35 -04:00
lib/llist.c: fix data race in llist_del_first
2015-11-06 17:50:42 -08:00
locking/lockdep: Revert qrwlock recusive stuff
2014-10-03 06:09:30 +02:00
locking/lockref: Remove homebrew cmpxchg64_relaxed() macro definition
2015-08-12 11:59:04 +02:00
lru_cache: Converted lc_seq_printf_status to return void
2015-11-25 09:22:02 -07:00
mm/usercopy: get rid of CONFIG_DEBUG_STRICT_USER_COPY_CHECKS
2016-08-30 10:10:21 -07:00
lib/md5.c: simplify include
2015-02-12 18:54:15 -08:00
mac_pton: Use bool not int return
2014-06-25 17:45:43 -07:00
net: Add support for CHANGEUPPER notifier error injection
2015-12-03 11:49:23 -05:00
libnl: fix help of _64bit functions
2016-04-23 20:13:24 -04:00
printk/nmi: generic solution for safe printk in NMI
2016-05-20 17:58:30 -07:00
include/linux/nodemask.h: create next_node_in() helper
2016-05-19 19:12:14 -07:00
once: make helper generic for calling functions once
2015-10-08 05:26:36 -07:00
libnvdimm for 4.3:
2015-09-08 14:35:59 -07:00
lib+mm: fix few spelling mistakes
2016-02-15 11:18:23 +01:00
percpu_counter: update debugobjects fixup callbacks return type
2016-05-19 19:12:14 -07:00
mm, page_alloc: rename __GFP_WAIT to __GFP_RECLAIM
2015-11-06 17:50:42 -08:00
lib/plist.c: remove redundant include
2015-02-12 18:54:16 -08:00
radix tree: fix sibling entry handling in radix_tree_descend()
2016-09-25 13:32:46 -07:00
timers: Remove set_timer_slack() leftovers
2016-07-07 10:35:09 +02:00
ratelimit: extend to print suppressed messages on release
2016-08-02 19:35:06 -04:00
Introduce rb_replace_node_rcu()
2016-07-06 10:51:14 +01:00
rhashtable: fix a memory leak in alloc_bucket_locks()
2016-08-26 21:59:53 -07:00
scatterlist: fix a typo in comment block of sg_miter_stop()
2016-02-08 10:15:17 -08:00
tracing: Use seq_buf_used() in seq_buf_to_user() instead of len
2015-12-23 14:27:20 -05:00
lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c
2016-04-15 16:53:14 -04:00
lib: scatterlist: add sg splitting function
2015-08-24 14:28:01 -06:00
lib: EXPORT_SYMBOL sha_init
2015-03-23 22:12:08 -04:00
lib/show_mem.c: correct reserved memory calculation
2015-09-08 15:35:28 -07:00
percpu: add preemption checks to __this_cpu ops
2014-04-07 16:36:14 -07:00
lib/sort: Add 64 bit swap function
2015-06-25 17:00:40 -07:00
lib/stackdepot.c: use __GFP_NOWARN for stack allocations
2016-07-28 16:07:41 -07:00
lib/stmp_device.c: replace module.h include
2015-02-12 18:54:16 -08:00
lib: move strtobool() to kstrtobool()
2016-03-17 15:09:34 -07:00
string_helpers: add kstrdup_quotable_file
2016-04-21 10:47:26 +10:00
unsafe_[get|put]_user: change interface to use a error target label
2016-08-08 13:02:01 -07:00
unsafe_[get|put]_user: change interface to use a error target label
2016-08-08 13:02:01 -07:00
dma-mapping: use unsigned long for dma_attrs
2016-08-04 08:50:07 -04:00
lib/syscall.c: unexport task_current_syscall()
2014-04-03 16:21:06 -07:00
kstrto*: accept "-0" for signed conversion
2015-09-10 13:29:01 -07:00
lib/test-string_helpers.c: fix and improve string_get_size() tests
2016-02-03 08:28:43 -08:00
test_bitmap: unit tests for lib/bitmap.c
2016-02-19 22:54:09 -05:00
bpf: prepare bpf_int_jit_compile/bpf_prog_select_runtime apis
2016-05-16 13:49:32 -04:00
test: firmware_class: add asynchronous request trigger
2016-01-07 13:44:22 -07:00
lib/test_hash.c: fix warning in preprocessor symbol evaluation
2016-09-01 17:52:01 -07:00
test_hexdump: print statistics at the end
2016-01-20 17:09:18 -08:00
kasan/tests: add tests for user memory access functions
2016-05-20 17:58:30 -07:00
mm, printk: introduce new format string for flags
2016-03-15 16:55:16 -07:00
rhashtable-test: Fix max_size parameter description
2016-08-08 12:52:42 -07:00
locking/static_keys: Provide a selftest
2015-08-03 11:51:12 +02:00
locking/static_keys: Avoid nested functions
2016-02-09 10:27:29 +01:00
lib/uuid: add a test module
2016-05-30 15:26:57 -07:00
lib/textsearch.c: remove textsearch_put reference from comments
2014-10-14 02:18:14 +02:00
timerqueue: Let timerqueue_add/del return information
2015-04-22 17:06:49 +02:00
UBSAN: fix typo in format string
2016-08-02 17:31:41 -04:00
UBSAN: run-time undefined behavior sanity checker
2016-01-20 17:09:18 -08:00
lib/ucs2_string: Correct ucs2 -> utf8 conversion
2016-02-16 12:49:05 +00:00
lib/uuid.c: use correct offset in uuid parser
2016-05-30 15:26:57 -07:00
lib/uuid.c: introduce a few more generic helpers
2016-05-20 17:58:30 -07:00
8d2c0d36d6