David S. Miller
28e6103665
sparc: Fix debugger syscall restart interactions.
...
So, forever, we've had this ptrace_signal_deliver implementation
which tries to handle all of the nasties that can occur when the
debugger looks at a process about to take a signal. It's meant
to address all of these issues inside of the kernel so that the
debugger need not be mindful of such things.
Problem is, this doesn't work.
The idea was that we should do the syscall restart business first, so
that the debugger captures that state. Otherwise, if the debugger for
example saves the child's state, makes the child execute something
else, then restores the saved state, we won't handle the syscall
restart properly because we lose the "we're in a syscall" state.
The code here worked for most cases, but if the debugger actually
passes the signal through to the child unaltered, it's possible that
we would do a syscall restart when we shouldn't have.
In particular this breaks the case of debugging a process under a gdb
which is being debugged by yet another gdb. gdb uses sigsuspend
to wait for SIGCHLD of the inferior, but if gdb itself is being
debugged by a top-level gdb we get a ptrace_stop(). The top-level gdb
does a PTRACE_CONT with SIGCHLD to let the inferior gdb see the
signal. But ptrace_signal_deliver() assumed the debugger would cancel
out the signal and therefore did a syscall restart, because the return
error was ERESTARTNOHAND.
Fix this by simply making ptrace_signal_deliver() a nop, and providing
a way for the debugger to control system call restarting properly:
1) Report a "in syscall" software bit in regs->{tstate,psr}.
It is set early on in trap entry to a system call and is fully
visible to the debugger via ptrace() and regsets.
2) Test this bit right before doing a syscall restart. We have
to do a final recheck right after get_signal_to_deliver() in
case the debugger cleared the bit during ptrace_stop().
3) Clear the bit in trap return so we don't accidently try to set
that bit in the real register.
As a result we also get a ptrace_{is,clear}_syscall() for sparc32 just
like sparc64 has.
M68K has this same exact bug, and is now the only other user of the
ptrace_signal_deliver hook. It needs to be fixed in the same exact
way as sparc.
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-05-11 02:07:19 -07:00
..
agp.h
x86: remove flush_agp_mappings()
2008-01-30 13:34:07 +01:00
apb.h
asi.h
atomic.h
[SPARC64]: __inline__ --> inline
2007-10-27 00:13:04 -07:00
auxio.h
auxvec.h
[SPARC]: Merge include/asm-sparc{,64}/auxvec.h
2008-02-09 04:00:03 -08:00
backoff.h
[SPARC64]: Fix atomic backoff limit.
2008-03-19 01:04:48 -07:00
bbc.h
bitops.h
generic: implement __fls on all 64-bit archs
2008-04-26 19:21:16 +02:00
bpp.h
[SPARC]: Merge asm-sparc{,64}/bpp.h
2008-02-09 04:00:12 -08:00
bug.h
[SPARC]: Merge asm-sparc{,64}/bug.h
2008-02-09 04:00:32 -08:00
bugs.h
[SPARC]: Merge asm-sparc{,64}/bugs.h
2008-02-09 04:00:37 -08:00
byteorder.h
[SPARC]: Merge asm-sparc{,64}/byteorder.h
2008-02-09 04:17:28 -08:00
cache.h
[SPARC]: Merge asm-sparc{,64}/cache.h
2008-02-09 04:17:37 -08:00
cacheflush.h
chafsr.h
checksum.h
chmctrl.h
cmt.h
compat.h
asm-*/compat.h: fix typo in comment
2008-02-03 16:32:51 +02:00
compat_signal.h
cpudata.h
[SPARC64]: Fix sparse warnings in arch/sparc64/kernel/{cpu,setup}.c
2008-03-25 21:51:40 -07:00
cputime.h
[SPARC]: Merge asm-sparc{,64}/cputime.h
2008-02-09 04:17:47 -08:00
current.h
[SPARC]: Merge asm-sparc{,64}/current.h
2008-02-09 04:17:54 -08:00
dcr.h
dcu.h
[SPARC64]: Fix sparse errors in arch/sparc64/kernel/traps.c
2008-03-26 00:19:43 -07:00
delay.h
device.h
[SPARC]: Merge asm-sparc{,64}/device.h
2008-02-09 04:18:02 -08:00
display7seg.h
div64.h
[SPARC]: Merge asm-sparc{,64}/div64.h
2008-02-09 04:18:08 -08:00
dma-mapping.h
[SPARC64]: Fix OOPS in dma_sync_*_for_device()
2007-12-20 01:29:45 -08:00
dma.h
ebus.h
elf.h
[SPARC64]: Make use of the new fs/compat_binfmt_elf.c
2008-02-08 00:08:10 -08:00
emergency-restart.h
[SPARC]: Merge asm-sparc{,64}/emergency-restart.h
2008-02-09 04:18:14 -08:00
envctrl.h
errno.h
[SPARC]: Merge asm-sparc{,64}/errno.h
2008-02-09 04:18:23 -08:00
estate.h
fb.h
[SPARC]: Merge asm-sparc{,64}/fb.h
2008-02-09 04:18:29 -08:00
fbio.h
fcntl.h
fhc.h
floppy.h
sparc64: Kill unused local ISA bus layer.
2008-04-26 21:41:23 -07:00
fpumacro.h
[SPARC64]: __inline__ --> inline
2007-10-27 00:13:04 -07:00
futex.h
asm-*/futex.h should include linux/uaccess.h
2008-04-30 08:29:52 -07:00
hardirq.h
head.h
hugetlb.h
hugetlbfs: common code update for s390
2008-04-28 08:58:25 -07:00
hvtramp.h
[SPARC64]: Remove most limitations to kernel image size.
2008-03-21 17:01:38 -07:00
hw_irq.h
hypervisor.h
[SPARC64]: Fix two kernel linear mapping setup bugs.
2007-12-13 06:13:38 -08:00
ide.h
ide: remove ide_default_io_ctl() macro
2008-04-18 00:46:34 +02:00
idprom.h
intr_queue.h
io.h
[SPARC64]: Add SG merging support back into IOMMU code.
2008-02-09 03:15:36 -08:00
ioctl.h
ioctls.h
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
iommu.h
[SPARC64]: NUMA device infrastructure.
2008-04-23 23:32:16 -07:00
ipcbuf.h
irq.h
[SPARC64]: Fix sparse warnings in arch/sparc64/kernel/irq.c
2008-03-26 00:37:51 -07:00
irq_regs.h
irqflags.h
Kbuild
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
kdebug.h
x86: optimize page faults like all other achitectures and kill notifier cruft
2007-10-16 09:42:50 -07:00
kgdb.h
sparc: Add kgdb support.
2008-04-29 02:38:50 -07:00
kmap_types.h
kprobes.h
Kprobes: indicate kretprobe support in Kconfig
2008-03-04 16:35:11 -08:00
kvm.h
kvm: provide kvm.h for all architecture: fixes headers_install
2008-04-02 15:28:18 -07:00
ldc.h
linkage.h
lmb.h
[LIB]: Make PowerPC LMB code generic so sparc64 can use it too.
2008-02-13 16:56:49 -08:00
local.h
lsu.h
mc146818rtc.h
mdesc.h
mman.h
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
mmu.h
mmu_context.h
mmzone.h
[SPARC64]: Add NUMA support.
2008-04-23 23:32:17 -07:00
module.h
mostek.h
[SPARC64]: __inline__ --> inline
2007-10-27 00:13:04 -07:00
msgbuf.h
mutex.h
namei.h
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
ns87303.h
[SPARC64]: __inline__ --> inline
2007-10-27 00:13:04 -07:00
of_device.h
[SPARC]: Merge include/asm-sparc{,64}/of_device.h
2008-02-09 03:58:32 -08:00
of_platform.h
[SPARC]: Remove of_platform_device_create
2008-02-09 03:49:58 -08:00
openprom.h
openpromio.h
oplib.h
page.h
hugetlbfs: architecture header cleanup
2008-04-28 08:58:25 -07:00
param.h
parport.h
[SPARC64]: __inline__ --> inline
2007-10-27 00:13:04 -07:00
pci.h
[SPARC64]: Implement pci_resource_to_user()
2007-12-26 19:33:46 -08:00
percpu.h
SPARC64: use generic percpu
2008-01-30 23:27:58 +01:00
perfctr.h
pgalloc.h
CONFIG_HIGHPTE vs. sub-page page tables.
2008-02-08 09:22:42 -08:00
pgtable.h
mm: introduce pte_special pte bit
2008-04-28 08:58:23 -07:00
pil.h
sparc64: Kill PIL_RESERVED, unused.
2008-04-28 04:03:06 -07:00
poll.h
posix_types.h
asm-*/posix_types.h: scrub __GLIBC__
2008-02-08 09:22:34 -08:00
processor.h
[SPARC64]: Define TASK_SIZE_OF()
2008-03-26 17:32:33 -07:00
prom.h
[SPARC]: Merge include/asm-sparc{,64}/prom.h
2008-02-09 03:56:20 -08:00
psrcompat.h
sparc: Fix debugger syscall restart interactions.
2008-05-11 02:07:19 -07:00
pstate.h
sparc: Fix debugger syscall restart interactions.
2008-05-11 02:07:19 -07:00
ptrace.h
sparc: Fix debugger syscall restart interactions.
2008-05-11 02:07:19 -07:00
reboot.h
[SPARC64]: Fix sparse warnings wrt. machine_alt_power_off().
2008-02-19 20:39:18 -08:00
reg.h
resource.h
rtc.h
rwsem-const.h
rwsem.h
sbus.h
[SPARC64]: __inline__ --> inline
2007-10-27 00:13:04 -07:00
scatterlist.h
Add CONFIG_DEBUG_SG sg validation
2007-10-22 21:20:03 +02:00
scratchpad.h
seccomp.h
sections.h
semaphore.h
Generic semaphore implementation
2008-04-17 10:42:34 -04:00
sembuf.h
setup.h
sfafsr.h
sfp-machine.h
shmbuf.h
shmparam.h
unexport asm/shmparam.h
2007-10-17 08:42:47 -07:00
sigcontext.h
siginfo.h
signal.h
sparc: Fix debugger syscall restart interactions.
2008-05-11 02:07:19 -07:00
smp.h
remove asm/bitops.h includes
2007-10-19 11:53:41 -07:00
socket.h
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
sockios.h
sparsemem.h
[SPARC64]: Decrease SECTION_SIZE_BITS to 30.
2008-04-23 23:32:13 -07:00
spinlock.h
spinlock_types.h
spitfire.h
[SPARC64]: Remove most limitations to kernel image size.
2008-03-21 17:01:38 -07:00
sstate.h
stacktrace.h
[SPARC64]: Make save_stack_trace() more efficient.
2008-03-24 20:06:24 -07:00
starfire.h
stat.h
statfs.h
string.h
sunbpp.h
syscalls.h
[SPARC64]: More sparse warning fixes in process.c
2008-02-19 21:25:50 -08:00
system.h
sparc: Add kgdb support.
2008-04-29 02:38:50 -07:00
termbits.h
[SPARC]: Support for new termios.
2007-10-17 19:38:10 -07:00
termios.h
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
thread_info.h
sparc: Remove old style signal frame support.
2008-04-27 02:26:36 -07:00
timer.h
[SPARC64]: Fix sparse warnings in arch/sparc64/kernel/time.c
2008-03-26 01:11:55 -07:00
timex.h
read_current_timer() cleanups
2008-02-06 10:41:02 -08:00
tlb.h
add mm argument to pte/pmd/pud/pgd_free
2008-02-05 09:44:18 -08:00
tlbflush.h
remove unused flush_tlb_pgtables
2007-10-19 11:53:34 -07:00
topology.h
[SPARC64]: Add NUMA support.
2008-04-23 23:32:17 -07:00
tsb.h
ttable.h
sparc: Fix debugger syscall restart interactions.
2008-05-11 02:07:19 -07:00
types.h
sparc64: types: use <asm-generic/int-*.h> for the sparc64 architecture
2008-05-02 16:18:41 -07:00
uaccess.h
aout: remove unnecessary inclusions of {asm, linux}/a.out.h
2008-02-08 09:22:30 -08:00
uctx.h
unaligned.h
kernel: Move arches to use common unaligned access
2008-04-29 08:06:27 -07:00
unistd.h
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
upa.h
[SPARC64]: __inline__ --> inline
2007-10-27 00:13:04 -07:00
user.h
[SPARC]: Remove SunOS and Solaris binary support.
2008-04-21 15:10:15 -07:00
utrap.h
vga.h
vio.h
[SPARC64]: Use "is_power_of_2" macro for simplicity.
2007-11-07 02:24:33 -08:00
visasm.h
[SPARC64]: __inline__ --> inline
2007-10-27 00:13:04 -07:00
watchdog.h
xor.h