Kees Cook
0638dcc7e7
treewide: Remove uninitialized_var() usage ...
commit 3f649ab728cda8038259d8f14492fe400fbab911 upstream.
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings
(e.g. "unused variable"). If the compiler thinks it is uninitialized,
either simply initialize the variable or make compiler changes.
In preparation for removing[2] the[3] macro[4], remove all remaining
needless uses with the following script:
git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \
xargs perl -pi -e \
's/\buninitialized_var\(([^\)]+)\)/\1/g;
s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;'
drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid
pathological white-space.
No outstanding warnings were found building allmodconfig with GCC 9.3.0
for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64,
alpha, and m68k.
[1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Reviewed-by: Leon Romanovsky <leonro@mellanox.com> # drivers/infiniband and mlx4/mlx5
Acked-by: Jason Gunthorpe <jgg@mellanox.com> # IB
Acked-by: Kalle Valo <kvalo@codeaurora.org> # wireless drivers
Reviewed-by: Chao Yu <yuchao0@huawei.com> # erofs
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-06-09 10:29:01 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
alim15x3: move irq-restore before pci_dev_put()
2018-06-05 16:26:46 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
cmd64x: potential buffer overflow in cmd64x_program_timings()
2020-02-24 08:36:53 +01:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
docs: cdrom: convert docs to ReST and rename to *.rst
2019-06-14 14:20:46 -06:00
block: Switch struct packet_command to use struct scsi_sense_hdr
2018-08-02 15:22:13 -06:00
Revert "ide: unexport DISK_EVENT_MEDIA_CHANGE for ide-gd and ide-cd"
2019-04-12 13:35:25 -06:00
ide: don't use req->special
2018-11-10 08:03:52 -07:00
ide: don't use req->special
2018-11-10 08:03:52 -07:00
ide: replace ->proc_fops with ->proc_show
2018-05-16 07:24:30 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide
2019-03-11 09:34:00 -07:00
ide: replace ->proc_fops with ->proc_show
2018-05-16 07:24:30 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
ide: ensure atapi sense request aren't preempted
2019-01-31 08:25:09 -07:00
ide: don't acquire queue_lock in ide_complete_pm_rq
2018-11-16 09:17:02 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 47
2019-05-24 17:27:13 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
ide: don't use req->special
2018-11-10 08:03:52 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: kzalloc() -> kcalloc()
2018-06-12 16:19:22 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
ide: remove the sgiioc4 driver
2019-08-16 11:33:56 -07:00
ide: remove the sgiioc4 driver
2019-08-16 11:33:56 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61
2019-05-24 17:36:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
ide: serverworks: potential overflow in svwks_set_pio_mode()
2020-02-24 08:36:53 +01:00
ide: mark expected switch fall-throughs
2018-08-13 11:48:54 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
drivers: Remove explicit invocations of mmiowb()
2019-04-08 12:01:02 +01:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
0638dcc7e7