Toke Høiland-Jørgensen
8f88812306
wifi: ath9k: Remove error checks when creating debugfs entries ...
[ Upstream commit f6ffe7f0184792c2f99aca6ae5b916683973d7d3 ]
We should not be checking the return values from debugfs creation at all: the
debugfs functions are designed to handle errors of previously called functions
and just transparently abort the creation of debugfs entries when debugfs is
disabled. If we check the return value and abort driver initialisation, we break
the driver if debugfs is disabled (such as when booting with debugfs=off).
Earlier versions of ath9k accidentally did the right thing by checking the
return value, but only for NULL, not for IS_ERR(). This was "fixed" by the two
commits referenced below, breaking ath9k with debugfs=off starting from the 6.6
kernel (as reported in the Bugzilla linked below).
Restore functionality by just getting rid of the return value check entirely.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=219122
Fixes: 1e4134610d93 ("wifi: ath9k: use IS_ERR() with debugfs_create_dir()")
Fixes: 6edb4ba6fb5b ("wifi: ath9k: fix parameter check in ath9k_init_debug()")
Reported-by: Daniel Tobias <dan.g.tob@gmail.com>
Tested-by: Daniel Tobias <dan.g.tob@gmail.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20240805110225.19690-1-toke@toke.dk
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-08 16:20:26 +01:00
ACPI: PMIC: Remove unneeded check in tps68470_pmic_opregion_probe()
2024-11-08 16:20:26 +01:00
binder: fix UAF caused by offsets overwrite
2024-09-12 11:03:55 +02:00
ata: pata_macio: Use WARN instead of BUG
2024-09-12 11:03:55 +02:00
atm: idt77252: prevent use after free in dequeue_rx()
2024-09-04 13:14:51 +02:00
devres: Initialize an uninitialized struct member
2024-09-12 11:03:54 +02:00
rbd: don't assume RBD_LOCK_STATE_LOCKED for exclusive mappings
2024-08-19 05:33:40 +02:00
Bluetooth: hci_ldisc: check HCI_UART_PROTO_READY flag in HCIUARTGETPROTO
2024-09-04 13:15:01 +02:00
bus: tegra-aconnect: Update dependency to ARCH_TEGRA
2024-03-26 18:22:15 -04:00
hwrng: amd - Convert PCIBIOS_* return codes to errnos
2024-08-19 05:33:37 +02:00
clk: qcom: clk-alpha-pll: Fix the trion pll postdiv set rate API
2024-09-12 11:03:51 +02:00
clocksource/drivers/timer-of: Remove percpu irq related code
2024-09-12 11:03:56 +02:00
cpufreq: exit() callback is optional
2024-06-16 13:28:34 +02:00
crypto: qat - Fix ADF_DEV_RESET_SYNC memory leak
2024-06-16 13:28:51 +02:00
dmaengine: ioatdma: Fix missing kmem_cache_destroy()
2024-07-05 09:08:23 +02:00
dma-buf/sw-sync: don't enable IRQ from sync_print_obj()
2024-06-16 13:28:47 +02:00
EDAC, i10nm: make skx_common.o a separate module
2024-08-19 05:33:25 +02:00
extcon: max8997: select IRQ_DOMAIN instead of depending on it
2024-06-16 13:28:43 +02:00
firewire: nosy: ensure user_length is taken into account when fetching packet contents
2024-05-17 11:43:54 +02:00
firmware: turris-mox-rwtm: Initialize completion before mailbox
2024-08-19 05:33:28 +02:00
gpio: prevent potential speculation leaks in gpio_device_get_desc()
2024-11-08 16:20:26 +01:00
drm: komeda: Fix an issue related to normalized zpos
2024-11-08 16:20:25 +01:00
greybus: Fix use-after-free bug in gb_interface_release due to race condition.
2024-07-05 09:08:20 +02:00
HID: cougar: fix slab-out-of-bounds Read in cougar_report_fixup
2024-09-12 11:03:54 +02:00
Drivers: hv: vmbus: Fix rescind handling in uio_hv_generic
2024-09-12 11:03:55 +02:00
hwmon: (w83627ehf) Fix underflows seen when writing limit attributes
2024-09-12 11:03:54 +02:00
intel_th: pci: Add Lunar Lake support
2024-07-05 09:08:19 +02:00
i2c: riic: avoid potential division by zero
2024-09-04 13:14:53 +02:00
i3c: master: cdns: Update maximum prescaler value for i2c clock
2024-02-23 08:25:02 +01:00
iio: fix scale application in iio_convert_raw_to_processed_unlocked
2024-09-12 11:03:55 +02:00
IB/hfi1: Fix potential deadlock on &irq_src_lock and &dd->uctxt_lock
2024-09-04 13:14:54 +02:00
Input: uinput - reject requests with unreasonable number of slots
2024-09-12 11:03:55 +02:00
interconnect: Treat xlate() returning NULL node as an error
2024-01-08 11:29:45 +01:00
iommu/vt-d: Handle volatile descriptor status read
2024-09-12 11:03:53 +02:00
irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1
2024-09-12 11:03:52 +02:00
mISDN: Fix a use after free in hfcmulti_tx()
2024-08-19 05:33:42 +02:00
leds: ss4200: Convert PCIBIOS_* return codes to errnos
2024-08-19 05:33:37 +02:00
macintosh/therm_windtunnel: fix module unload.
2024-08-19 05:33:34 +02:00
mcb: fix error handling for different scenarios when parsing
2023-11-28 16:50:19 +00:00
dm init: Handle minors larger than 255
2024-09-12 11:03:53 +02:00
media: qcom: camss: Add check for v4l2_fwnode_endpoint_parse
2024-09-12 11:03:52 +02:00
mfd: omap-usb-tll: Use struct_size to allocate tll
2024-08-19 05:33:32 +02:00
VMCI: Fix use-after-free when removing resource in vmci_resource_remove()
2024-09-12 11:03:55 +02:00
mmc: sdhci-of-aspeed: fix module autoloading
2024-09-12 11:03:51 +02:00
ubi: eba: properly rollback inside self_check_eba
2024-08-19 05:33:38 +02:00
wifi: ath9k: Remove error checks when creating debugfs entries
2024-11-08 16:20:26 +01:00
nfc: pn533: Add poll mod list filling check
2024-09-04 13:15:04 +02:00
nd_btt: Make BTT lanes preemptible
2023-11-20 10:30:12 +01:00
nvmet-tcp: fix kernel crash if commands allocation fails
2024-09-12 11:03:56 +02:00
nvmem: Fix return type of devm_nvmem_device_get() in kerneldoc
2024-09-12 11:03:55 +02:00
of/irq: Prevent device address out-of-bounds read in interrupt map walk
2024-09-12 11:03:55 +02:00
parisc: iosapic.c: Fix sparse warnings
2023-10-10 21:46:39 +02:00
dev/parport: fix the array out-of-bounds risk
2024-08-19 05:33:43 +02:00
PCI: Add missing bridge lock to pci_bus_lock()
2024-09-12 11:03:54 +02:00
pcmcia: Use resource_size function on resource object
2024-09-12 11:03:52 +02:00
perf/smmuv3: Enable HiSilicon Erratum 162001900 quirk for HIP08/09
2023-09-23 11:00:03 +02:00
phy: ti: phy-omap-usb2: Fix NULL pointer dereference for SRP
2024-02-23 08:25:06 +01:00
pinctrl: at91: make it work with current gpiolib
2024-11-08 16:20:25 +01:00
platform/x86: dell-smbios: Fix error path in dell_smbios_init()
2024-09-12 11:03:52 +02:00
PNP: ACPI: fix fortify warning
2024-02-23 08:24:54 +01:00
power: supply: axp288_charger: Round constant_charge_voltage writes down
2024-08-19 05:33:52 +02:00
ptp: Fix error message on failed pin verification
2024-07-05 09:08:11 +02:00
pwm: stm32: Always do lazy disabling
2024-08-19 05:33:26 +02:00
regulator: core: Fix modpost error "regulator_get_regmap" undefined
2024-07-05 09:08:23 +02:00
remoteproc: imx_rproc: Skip over memory region when node value is NULL
2024-08-19 05:33:44 +02:00
reset: hi6220: Add support for AO reset controller
2024-09-12 11:03:51 +02:00
rpmsg: virtio: Free driver_override when rpmsg_remove()
2024-02-23 08:24:48 +01:00
rtc: isl1208: Fix return value of nvmem callbacks
2024-08-19 05:33:39 +02:00
s390/cio: rename bitmap_size() -> idset_bitmap_size()
2024-09-04 13:14:51 +02:00
scsi: aacraid: Fix double-free on probe failure
2024-09-04 13:15:05 +02:00
slimbus: core: Remove usage of the deprecated ida_simple_xx() API
2024-04-13 12:51:26 +02:00
soc: qcom: cmd-db: Map shared memory as WC, not WB
2024-09-04 13:15:04 +02:00
soundwire: stream: Revert "soundwire: stream: fix programming slave ports for non-continous port maps"
2024-11-08 16:20:25 +01:00
spi: bcm63xx: Enable module autoloading
2024-11-08 16:20:25 +01:00
ssb: Fix division by zero issue in ssb_calc_clock_rate
2024-09-04 13:14:53 +02:00
staging: iio: frequency: ad9834: Validate frequency parameter value
2024-09-12 11:03:55 +02:00
scsi: target: Fix SELinux error when systemd-modules loads the target module
2024-05-17 11:43:51 +02:00
thermal: core: prevent potential string overflow
2023-11-20 10:30:09 +01:00
serial: core: check uartclk for zero to avoid divide by zero
2024-08-19 05:33:52 +02:00
Drivers: hv: vmbus: Fix rescind handling in uio_hv_generic
2024-09-12 11:03:55 +02:00
USB: usbtmc: prevent kernel-usb-infoleak
2024-11-08 16:20:26 +01:00
vfio/platform: Create persistent IRQ handlers
2024-04-13 12:51:34 +02:00
vhost: Add smp_rmb() in vhost_vq_avail_empty()
2024-05-02 16:18:29 +02:00
fbdev: savage: Handle err return when savagefb_check_var failed
2024-06-16 13:28:50 +02:00
virtio: delete vq in vp_find_vqs_msix() when request_irq() fails
2024-06-16 13:28:46 +02:00
watchdog: stm32_iwdg: initialize default timeout
2024-03-26 18:22:24 -04:00
xen/events: close evtchn after mapping cleanup
2024-04-13 12:51:29 +02:00
8f88812306