Mikulas Patocka
340cd44451
dm kcopyd: fix callback race ...
If the thread calling dm_kcopyd_copy is delayed due to scheduling inside
split_job/segment_complete and the subjobs complete before the loop in
split_job completes, the kcopyd callback could be invoked from the
thread that called dm_kcopyd_copy instead of the kcopyd workqueue.
dm_kcopyd_copy -> split_job -> segment_complete -> job->fn()
Snapshots depend on the fact that callbacks are called from the singlethreaded
kcopyd workqueue and expect that there is no racing between individual
callbacks. The racing between callbacks can lead to corruption of exception
store and it can also mean that exception store callbacks are called twice
for the same exception - a likely reason for crashes reported inside
pending_complete() / remove_exception().
This patch fixes two problems:
1. job->fn being called from the thread that submitted the job (see above).
- Fix: hand over the completion callback to the kcopyd thread.
2. job->fn(read_err, write_err, job->context); in segment_complete
reports the error of the last subjob, not the union of all errors.
- Fix: pass job->write_err to the callback to report all error bits
(it is done already in run_complete_job)
Cc: stable@kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
2009-04-09 00:27:17 +01:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md: Make mddev->size sector-based.
2009-03-31 14:33:13 +11:00
md: move headers out of include/linux/raid/
2009-03-31 14:27:03 +11:00
dm: bio list add bio_list_add_head
2009-04-02 19:55:36 +01:00
dm: preserve bi_io_vec when resubmitting bios
2009-04-02 19:55:23 +01:00
dm crypt: use kzfree
2009-04-02 19:55:28 +01:00
dm: consolidate target deregistration error handling
2009-01-06 03:04:58 +00:00
dm snapshot: move ctr parsing to exception store
2009-04-02 19:55:34 +01:00
dm snapshot: move status to exception store
2009-04-02 19:55:35 +01:00
dm io: make sync_io uninterruptible
2009-04-02 19:55:24 +01:00
dm: add integrity support
2009-04-09 00:27:12 +01:00
dm kcopyd: fix callback race
2009-04-09 00:27:17 +01:00
dm: remove limited barrier support
2009-04-09 00:27:13 +01:00
dm log: remove struct dm_dirty_log_internal
2009-04-02 19:55:30 +01:00
dm mpath: move trigger_event to system workqueue
2009-01-06 03:05:13 +00:00
dm mpath: remove is_active from struct dm_path
2008-10-10 13:36:58 +01:00
dm: path selector use module refcount directly
2009-04-02 19:55:27 +01:00
dm raid1: add is_remote_recovering hook for clusters
2009-04-02 19:55:30 +01:00
dm raid1: separate region_hash interface part1
2008-10-21 17:45:06 +01:00
dm: remove dm header from targets
2008-10-21 17:44:59 +01:00
dm snapshot: persistent fix dtr cleanup
2009-04-02 19:55:35 +01:00
dm snapshot: move status to exception store
2009-04-02 19:55:35 +01:00
dm snapshot: move status to exception store
2009-04-02 19:55:35 +01:00
dm: consolidate target deregistration error handling
2009-01-06 03:04:58 +00:00
dm: add name and uuid to sysfs
2009-01-06 03:05:12 +00:00
dm: remove limited barrier support
2009-04-09 00:27:13 +01:00
dm target: remove struct tt_internal
2009-04-02 19:55:28 +01:00
md: replace remaining __FUNCTION__ occurrences
2008-04-28 08:58:42 -07:00
dm: consolidate target deregistration error handling
2009-01-06 03:04:58 +00:00
dm: implement basic barrier support
2009-04-09 00:27:16 +01:00
dm: remove limited barrier support
2009-04-09 00:27:13 +01:00
md: centralize ->array_sectors modifications
2009-03-31 14:59:03 +11:00
md: remove CONFIG_MD_RAID_RESHAPE config option.
2009-03-31 15:27:05 +11:00
md: centralize ->array_sectors modifications
2009-03-31 14:59:03 +11:00
md: move lots of #include lines out of .h files and into .c
2009-03-31 14:33:13 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
Merge branch 'for-linus' of git://neil.brown.name/md
2009-04-03 09:08:19 -07:00
md: add explicit method to signal the end of a reshape.
2009-03-31 15:15:05 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md: centralize ->array_sectors modifications
2009-03-31 14:59:03 +11:00
md: move lots of #include lines out of .h files and into .c
2009-03-31 14:33:13 +11:00
md: 'array_size' sysfs attribute
2009-03-31 15:00:31 +11:00
md: move lots of #include lines out of .h files and into .c
2009-03-31 14:33:13 +11:00
md/raid1: fix build breakage
2009-04-06 14:40:07 -07:00
md: move lots of #include lines out of .h files and into .c
2009-03-31 14:33:13 +11:00
md/raid5 revise rules for when to update metadata during reshape
2009-03-31 15:28:40 +11:00
md/raid5 revise rules for when to update metadata during reshape
2009-03-31 15:28:40 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md/raid6: move raid6 data processing to raid6_pq.ko
2009-03-31 15:09:39 +11:00
md: fix typo in FSF address
2009-03-31 14:57:37 +11:00
md: 'array_size' sysfs attribute
2009-03-31 15:00:31 +11:00
md: move lots of #include lines out of .h files and into .c
2009-03-31 14:33:13 +11:00
340cd44451