Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Vlad Buslov 5f2e543918 net/sched: flower: fix parsing of ethertype following VLAN header ... [ Upstream commit 2105f700b53c24aa48b65c15652acc386044d26a ] A tc flower filter matching TCA_FLOWER_KEY_VLAN_ETH_TYPE is expected to match the L2 ethertype following the first VLAN header, as confirmed by linked discussion with the maintainer. However, such rule also matches packets that have additional second VLAN header, even though filter has both eth_type and vlan_ethtype set to "ipv4". Looking at the code this seems to be mostly an artifact of the way flower uses flow dissector. First, even though looking at the uAPI eth_type and vlan_ethtype appear like a distinct fields, in flower they are all mapped to the same key->basic.n_proto. Second, flow dissector skips following VLAN header as no keys for FLOW_DISSECTOR_KEY_CVLAN are set and eventually assigns the value of n_proto to last parsed header. With these, such filters ignore any headers present between first VLAN header and first "non magic" header (ipv4 in this case) that doesn't result FLOW_DISSECT_RET_PROTO_AGAIN. Fix the issue by extending flow dissector VLAN key structure with new 'vlan_eth_type' field that matches first ethertype following previously parsed VLAN header. Modify flower classifier to set the new flow_dissector_key_vlan->vlan_eth_type with value obtained from TCA_FLOWER_KEY_VLAN_ETH_TYPE/TCA_FLOWER_KEY_CVLAN_ETH_TYPE uAPIs. Link: https://lore.kernel.org/all/Yjhgi48BpTGh6dig@nanopsycho/ Fixes: 9399ae9a6c ("net_sched: flower: Add vlan support") Fixes: d64efd0926 ("net/sched: flower: Add supprt for matching on QinQ vlan headers") Signed-off-by: Vlad Buslov <vladbu@nvidia.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-04-20 09:19:34 +02:00
..
9p
bluetooth	Bluetooth: defer cleanup of resources in hci_unregister_dev()	2021-08-12 13:20:58 +02:00
caif	net: caif: add proper error handling	2021-06-10 13:37:09 +02:00
iucv
netfilter	netfilter: nf_queue: fix possible use-after-free	2022-03-08 19:07:47 +01:00
netns	ipv4: convert fib_num_tclassid_users to atomic_t	2021-12-08 09:01:12 +01:00
nfc	NFC: add NCI_UNREG flag to eliminate the race	2021-12-01 09:23:35 +01:00
phonet
sctp	sctp: use call_rcu to free endpoint	2022-01-05 12:37:44 +01:00
tc_act	net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info	2021-12-22 09:29:40 +01:00
6lowpan.h
act_api.h	net: sched: fix police ext initialization	2021-03-04 10:26:53 +01:00
addrconf.h	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-05-14 09:44:32 +02:00
af_ieee802154.h
af_rxrpc.h	rxrpc: Make rxrpc_kernel_get_srtt() indicate validity	2020-09-09 19:12:23 +02:00
af_unix.h
af_vsock.h
ah.h
arp.h	ipv4: Invalidate neighbour for broadcast address upon address addition	2022-04-15 14:18:33 +02:00
atmclip.h
ax25.h
ax88796.h
bond_3ad.h	bonding: fix data-races around agg_select_timer	2022-02-23 11:59:58 +01:00
bond_alb.h	bonding: make tx_rebalance_counter an atomic	2021-12-14 14:49:00 +01:00
bond_options.h
bonding.h	bonding: wait for sysfs kobject destruction before freeing struct slave	2020-12-08 10:40:24 +01:00
bpf_sk_storage.h
busy_poll.h	net: annotate data race around sk_ll_usec	2021-07-31 08:19:38 +02:00
calipso.h
cfg80211-wext.h
cfg80211.h	mac80211: properly handle A-MSDUs that start with an RFC 1042 header	2021-06-03 08:59:01 +02:00
cfg802154.h
checksum.h	net: Force inlining of checksum functions in net/checksum.h	2022-03-02 11:41:08 +01:00
cipso_ipv4.h
cls_cgroup.h
codel.h
codel_impl.h
codel_qdisc.h
compat.h
datalink.h
dcbevent.h
dcbnl.h
devlink.h
dn.h
dn_dev.h
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h
drop_monitor.h	net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report()	2020-05-27 17:46:24 +02:00
dsa.h
dsfield.h
dst.h	net: Added pointer check for dst->ops->neigh_lookup in dst_neigh_lookup_skb	2020-07-22 09:32:47 +02:00
dst_cache.h
dst_metadata.h	net: fix a memleak when uncloning an skb dst and its metadata	2022-02-16 12:52:51 +01:00
dst_ops.h
erspan.h
esp.h	esp: Fix possible buffer overflow in ESP transformation	2022-03-28 08:46:44 +02:00
ethoc.h
failover.h
fib_notifier.h
fib_rules.h	ipv6: fix memory leak in fib6_rule_suppress	2021-12-08 09:01:13 +01:00
firewire.h
flow.h	ipv4: Initialize flowi4_multipath_hash in data path	2020-09-26 18:03:12 +02:00
flow_dissector.h	net/sched: flower: fix parsing of ethertype following VLAN header	2022-04-20 09:19:34 +02:00
flow_offload.h
fou.h
fq.h
fq_impl.h
garp.h
gen_stats.h
genetlink.h	genetlink: remove genl_bind	2020-07-22 09:32:46 +02:00
geneve.h
gre.h
gro_cells.h
gtp.h
gue.h
hwbm.h
icmp.h	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-03-04 10:26:53 +01:00
ieee80211_radiotap.h
ieee802154_netdev.h
if_inet6.h
ife.h
ila.h
inet6_connection_sock.h
inet6_hashtables.h
inet_common.h
inet_connection_sock.h	tcp: relookup sock for RST+ACK packets handled by obsolete req sock	2021-03-30 14:35:26 +02:00
inet_ecn.h	inet_ecn: Fix endianness of checksum update when setting ECT(1)	2020-12-08 10:40:25 +01:00
inet_frag.h	inet: frags: annotate races around fqdir->dead and fqdir->high_thresh	2022-01-27 09:19:54 +01:00
inet_hashtables.h	dccp: Fix possible memleak in dccp_init and dccp_fini	2020-06-17 16:40:32 +02:00
inet_sock.h
inet_timewait_sock.h
inetpeer.h
ip.h	ipv4: avoid using shared IP generator for connected sockets	2022-02-01 17:24:37 +01:00
ip6_checksum.h
ip6_fib.h	ipv6: annotate accesses to fn->fn_sernum	2022-02-01 17:24:38 +01:00
ip6_route.h	net: ipv6: fix returned variable type in ip6_skb_dst_mtu	2021-08-12 13:20:57 +02:00
ip6_tunnel.h
ip_fib.h	ipv4: convert fib_num_tclassid_users to atomic_t	2021-12-08 09:01:12 +01:00
ip_tunnels.h	ip_tunnels: Set tunnel option flag when tunnel metadata is present	2020-11-24 13:29:05 +01:00
ip_vs.h	ipvs: allow connection reuse for unconfirmed conntrack	2020-08-19 08:16:10 +02:00
ipcomp.h
ipconfig.h
ipv6.h
ipv6_frag.h	inet: frags: annotate races around fqdir->dead and fqdir->high_thresh	2022-01-27 09:19:54 +01:00
ipv6_stubs.h	net: ipv6: add fib6_nh_release_dsts stub	2021-12-01 09:23:33 +01:00
ipx.h
iw_handler.h
kcm.h
l3mdev.h
lag.h
lapb.h
lib80211.h
llc.h	llc: fix out-of-bound array index in llc_sk_dev_hash()	2021-11-17 09:48:47 +01:00
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h	net: llc: fix skb_over_panic	2021-08-04 12:27:39 +02:00
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
lwtunnel.h
mac80211.h	mac80211: populate debugfs only after cfg80211 init	2020-04-29 16:33:18 +02:00
mac802154.h
mip6.h
mld.h
mpls.h
mpls_iptunnel.h
mrp.h
ncsi.h
ndisc.h
neighbour.h	net, neigh: Enable state migration between NUD_PERMANENT and NTF_USE	2021-11-17 09:48:49 +01:00
net_failover.h
net_namespace.h	net: make get_net_ns return error if NET_NS is disabled	2021-06-23 14:41:25 +02:00
net_ratelimit.h
netevent.h
netlabel.h
netlink.h
netprio_cgroup.h
netrom.h
nexthop.h	net: ipv4: Fix rtnexthop len when RTA_FLOW is present	2021-10-06 15:42:33 +02:00
nl802154.h	net: ieee802154: handle iftypes as u32	2021-12-01 09:23:32 +01:00
nsh.h
p8022.h
page_pool.h	mm: fix struct page layout on 32-bit systems	2021-05-19 10:08:31 +02:00
ping.h
pkt_cls.h
pkt_sched.h	net: prevent user from passing illegal stab size	2021-10-17 10:42:34 +02:00
pptp.h
protocol.h
psample.h	psample: Add a fwd declaration for skbuff	2021-08-18 08:56:59 +02:00
psnap.h
raw.h
rawv6.h
red.h	sch_red: fix off-by-one checks in red_check_params()	2021-04-14 08:24:14 +02:00
regulatory.h
request_sock.h
rose.h
route.h	ipv4: remove sparse error in ip_neigh_gw4()	2022-02-01 17:24:39 +01:00
rsi_91x.h
rtnetlink.h	can: dev: Move device back to init netns on owning netns delete	2021-03-30 14:35:29 +02:00
rtnh.h
sch_generic.h	net_sched: restore "mpu xxx" handling	2022-01-27 09:19:55 +01:00
scm.h
secure_seq.h
seg6.h
seg6_hmac.h
seg6_local.h
slhc_vj.h
smc.h
snmp.h
sock.h	esp: Fix possible buffer overflow in ESP transformation	2022-03-28 08:46:44 +02:00
sock_reuseport.h
Space.h
stp.h
strparser.h	bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding	2021-11-17 09:48:48 +01:00
switchdev.h
tcp.h	tcp: fix SO_RCVLOWAT related hangs under mem pressure	2021-03-04 10:26:17 +01:00
tcp_states.h
timewait_sock.h
tipc.h
tls.h	net/tls: Fix flipped sign in tls_err_abort() calls	2021-11-02 19:46:12 +01:00
transp_v6.h
tso.h
tun_proto.h
udp.h	udp: call udp_encap_enable for v6 sockets when enabling encap	2022-04-15 14:18:01 +02:00
udp_tunnel.h	udp: call udp_encap_enable for v6 sockets when enabling encap	2022-04-15 14:18:01 +02:00
udplite.h
vsock_addr.h
vxlan.h
wext.h
wimax.h
x25.h
x25device.h
xdp.h
xdp_priv.h
xdp_sock.h
xfrm.h	xfrm: Check if_id in xfrm_migrate	2022-03-19 13:40:16 +01:00