Arnd Bergmann
287980e49f
remove lots of IS_ERR_VALUE abuses
...
Most users of IS_ERR_VALUE() in the kernel are wrong, as they
pass an 'int' into a function that takes an 'unsigned long'
argument. This happens to work because the type is sign-extended
on 64-bit architectures before it gets converted into an
unsigned type.
However, anything that passes an 'unsigned short' or 'unsigned int'
argument into IS_ERR_VALUE() is guaranteed to be broken, as are
8-bit integers and types that are wider than 'unsigned long'.
Andrzej Hajda has already fixed a lot of the worst abusers that
were causing actual bugs, but it would be nice to prevent any
users that are not passing 'unsigned long' arguments.
This patch changes all users of IS_ERR_VALUE() that I could find
on 32-bit ARM randconfig builds and x86 allmodconfig. For the
moment, this doesn't change the definition of IS_ERR_VALUE()
because there are probably still architecture specific users
elsewhere.
Almost all the warnings I got are for files that are better off
using 'if (err)' or 'if (err < 0)'.
The only legitimate user I could find that we get a warning for
is the (32-bit only) freescale fman driver, so I did not remove
the IS_ERR_VALUE() there but changed the type to 'unsigned long'.
For 9pfs, I just worked around one user whose calling conventions
are so obscure that I did not dare change the behavior.
I was using this definition for testing:
#define IS_ERR_VALUE(x) ((unsigned long*)NULL == (typeof (x)*)NULL && \
unlikely((unsigned long long)(x) >= (unsigned long long)(typeof(x))-MAX_ERRNO))
which ends up making all 16-bit or wider types work correctly with
the most plausible interpretation of what IS_ERR_VALUE() was supposed
to return according to its users, but also causes a compile-time
warning for any users that do not pass an 'unsigned long' argument.
I suggested this approach earlier this year, but back then we ended
up deciding to just fix the users that are obviously broken. After
the initial warning that caused me to get involved in the discussion
(fs/gfs2/dir.c) showed up again in the mainline kernel, Linus
asked me to send the whole thing again.
[ Updated the 9p parts as per Al Viro - Linus ]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: https://lkml.org/lkml/2016/1/7/363
Link: https://lkml.org/lkml/2016/5/27/486
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> # For nvmem part
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-05-27 15:26:11 -07:00
..
acard-ahci.c
ahci: Store irq number in struct ahci_host_priv
2015-06-03 01:37:49 -04:00
ahci.c
AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs
2016-03-11 12:31:49 -05:00
ahci.h
ahci: Cache host controller version
2016-02-19 10:52:46 -05:00
ahci_brcmstb.c
drivers: ata: wake port before DMA stop for ALPM
2016-01-25 15:20:44 -05:00
ahci_ceva.c
drivers: ata: add support for Ceva sata host controller
2015-06-10 11:15:17 +09:00
ahci_da850.c
ata: ahci_platform: fix owner module reference mismatch for scsi host
2015-01-28 18:45:23 -05:00
ahci_imx.c
ata: ahci_platform: fix owner module reference mismatch for scsi host
2015-01-28 18:45:23 -05:00
ahci_mvebu.c
ata: ahci_mvebu: add support for Armada 3700 variant
2016-02-18 12:41:17 -05:00
ahci_octeon.c
libata: support AHCI on OCTEON platform
2016-02-11 10:12:04 -05:00
ahci_platform.c
ata: ahci-platform: Add ports-implemented DT bindings.
2016-04-01 10:30:30 -04:00
ahci_qoriq.c
ahci: qoriq: Adjust the default register values on ls1021a
2015-12-16 10:24:35 -05:00
ahci_seattle.c
ata: add AMD Seattle platform driver
2016-04-13 15:14:24 -04:00
ahci_st.c
ata: ahci_st: fixup layering violations / drvdata errors
2015-04-20 13:36:38 -04:00
ahci_sunxi.c
ata: ahci_platform: fix owner module reference mismatch for scsi host
2015-01-28 18:45:23 -05:00
ahci_tegra.c
ata: ahci_platform: fix owner module reference mismatch for scsi host
2015-01-28 18:45:23 -05:00
ahci_xgene.c
ata: ahci_xgene: dereferencing uninitialized pointer in probe
2016-03-11 12:40:34 -05:00
ata_generic.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
ata_piix.c
ata_piix: Add Device IDs for Intel 9 Series PCH
2014-08-28 08:53:40 -04:00
Kconfig
Merge branch 'for-4.7-dw' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2016-05-23 18:19:21 -07:00
libahci.c
Merge branch 'for-4.6-fixes' into for-4.7
2016-05-13 17:20:48 -04:00
libahci_platform.c
ahci: Store irq number in struct ahci_host_priv
2015-06-03 01:37:49 -04:00
libata-acpi.c
ACPI and power management updates for 3.15-rc1
2014-04-01 12:48:54 -07:00
libata-core.c
Merge branch 'for-4.7-zac' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2016-05-23 17:53:39 -07:00
libata-eh.c
libata: Implement ZBC OUT translation
2016-05-09 12:36:46 -04:00
libata-pmp.c
ata: pmp: add quirk for Marvell 4140 SATA PMP
2015-07-14 17:46:38 -04:00
libata-scsi.c
Merge branch 'for-4.7-zac' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2016-05-23 17:53:39 -07:00
libata-sff.c
libata: fix sff host state machine locking while polling
2016-02-01 11:33:21 -05:00
libata-trace.c
libata: NCQ encapsulation for ZAC MANAGEMENT OUT
2016-05-09 12:36:46 -04:00
libata-transport.c
libata: add ATA_HORKAGE_NOTRIM
2015-07-15 11:22:35 -04:00
libata-transport.h
libata-zpodd.c
libata: zpodd: eliminate odd_can_poweroff
2014-03-14 11:23:47 -04:00
libata.h
libata: Implement control mode page to select sense format
2016-04-04 12:07:41 -04:00
Makefile
ata: add AMD Seattle platform driver
2016-04-13 15:14:24 -04:00
pata_acpi.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_ali.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_amd.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_arasan_cf.c
Merge branch 'for-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2015-09-02 08:00:54 -07:00
pata_artop.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_at32.c
ata: drop owner assignment from platform_drivers
2014-10-20 16:20:17 +02:00
pata_at91.c
gpio: Include linux/gpio.h instead of asm/gpio.h
2016-02-16 00:20:03 +01:00
pata_atiixp.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_atp867x.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
pata_bf54x.c
gpio: Include linux/gpio.h instead of asm/gpio.h
2016-02-16 00:20:03 +01:00
pata_cmd64x.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_cmd640.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_cs5520.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
pata_cs5530.c
ata: Delete unnecessary checks before the function call "pci_dev_put"
2015-02-03 07:04:44 -05:00
pata_cs5535.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_cs5536.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_cypress.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_efar.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_ep93xx.c
ata: drop owner assignment from platform_drivers
2014-10-20 16:20:17 +02:00
pata_hpt3x2n.c
ata: delete non-required instances of include <linux/init.h>
2014-02-13 16:40:56 -05:00
pata_hpt3x3.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
pata_hpt37x.c
ata: delete non-required instances of include <linux/init.h>
2014-02-13 16:40:56 -05:00
pata_hpt366.c
ata: hpt366: convert to use match_string() helper
2016-03-17 15:09:34 -07:00
pata_icside.c
scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS
2016-04-15 16:53:14 -04:00
pata_imx.c
ata: drop owner assignment from platform_drivers
2014-10-20 16:20:17 +02:00
pata_isapnp.c
PNP: ata/pata_isapnp: Use module_pnp_driver to register driver
2015-03-18 22:39:17 +01:00
pata_it821x.c
pata_it821x: use "const char *" for string literals
2015-10-15 10:58:53 -04:00
pata_it8213.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_ixp4xx_cf.c
ata: drop owner assignment from platform_drivers
2014-10-20 16:20:17 +02:00
pata_jmicron.c
PCI: Disable async suspend/resume for JMicron multi-function SATA/AHCI
2015-08-24 15:27:11 -05:00
pata_legacy.c
pata_legacy: Remove dead code
2014-03-11 08:30:53 -04:00
pata_macio.c
PCI: Remove includes of asm/pci-bridge.h
2016-02-05 16:29:28 -06:00
pata_marvell.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_mpc52xx.c
ata: drop owner assignment from platform_drivers
2014-10-20 16:20:17 +02:00
pata_mpiix.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_netcell.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_ninja32.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
pata_ns87410.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_ns87415.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_octeon_cf.c
pata_octeon_cf: fix broken build
2015-06-08 18:03:04 +09:00
pata_of_platform.c
ata: pata_platform: fix owner module reference mismatch for scsi host
2015-01-28 18:45:23 -05:00
pata_oldpiix.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_opti.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_optidma.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_palmld.c
ata: drop owner assignment from platform_drivers
2014-10-20 16:20:17 +02:00
pata_pcmcia.c
ata: delete non-required instances of include <linux/init.h>
2014-02-13 16:40:56 -05:00
pata_pdc202xx_old.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_pdc2027x.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
pata_piccolo.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_platform.c
ata: pata_platform: fix owner module reference mismatch for scsi host
2015-01-28 18:45:23 -05:00
pata_pxa.c
ata: pata_pxa: dmaengine conversion
2015-09-10 17:02:04 -04:00
pata_radisys.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_rb532_cf.c
pata-rb532-cf: get rid of the irq_to_gpio() call
2016-02-18 11:26:27 -05:00
pata_rdc.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_rz1000.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_samsung_cf.c
libata: samsung_cf: fix handling platform_get_irq result
2015-09-25 11:50:15 -04:00
pata_sc1200.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_sch.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_serverworks.c
pata_serverworks: disable 64-KB DMA transfers on Broadcom OSB4 IDE Controller
2014-10-07 17:10:14 -04:00
pata_sil680.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
pata_sis.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_sl82c105.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_triflex.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pata_via.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
pdc_adma.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
sata_dwc_460ex.c
ata: sata_dwc_460ex: make debug messages neat
2016-05-12 10:54:12 -04:00
sata_fsl.c
ata/sata_fsl.c: add ATA_FLAG_NO_LOG_PAGE to blacklist the controller for log page reads
2015-12-07 10:25:57 -05:00
sata_highbank.c
remove lots of IS_ERR_VALUE abuses
2016-05-27 15:26:11 -07:00
sata_inic162x.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
sata_mv.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
sata_nv.c
ata:sata_nv - Change 1 to true for bool type variable.
2015-05-25 20:06:55 -04:00
sata_promise.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
sata_promise.h
sata_qstor.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
sata_rcar.c
ata: sata_rcar: Remove obsolete platform_device_id entries
2015-11-24 09:54:36 -05:00
sata_sil.c
sata_sil: disable trim
2015-11-30 10:02:49 -05:00
sata_sil24.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
sata_sis.c
ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers
2014-05-09 22:37:49 -04:00
sata_svw.c
powerpc updates for 4.1
2015-04-16 13:53:32 -05:00
sata_sx4.c
sata_sx4: correctly handling failed allocation
2015-12-31 21:33:42 -05:00
sata_uli.c
ata: delete non-required instances of include <linux/init.h>
2014-02-13 16:40:56 -05:00
sata_via.c
sata_via: Implement hotplug for VT6421
2016-02-25 13:22:16 -05:00
sata_vsc.c
ata: remove deprecated use of pci api
2015-04-08 10:55:05 -04:00
sis.h