Jason A. Donenfeld
c634a9107f
random: use expired timer rather than wq for mixing fast pool ...
commit 748bc4dd9e663f23448d8ad7e58c011a67ea1eca upstream.
Previously, the fast pool was dumped into the main pool periodically in
the fast pool's hard IRQ handler. This worked fine and there weren't
problems with it, until RT came around. Since RT converts spinlocks into
sleeping locks, problems cropped up. Rather than switching to raw
spinlocks, the RT developers preferred we make the transformation from
originally doing:
do_some_stuff()
spin_lock()
do_some_other_stuff()
spin_unlock()
to doing:
do_some_stuff()
queue_work_on(some_other_stuff_worker)
This is an ordinary pattern done all over the kernel. However, Sherry
noticed a 10% performance regression in qperf TCP over a 40gbps
InfiniBand card. Quoting her message:
> MT27500 Family [ConnectX-3] cards:
> Infiniband device 'mlx4_0' port 1 status:
> default gid: fe80:0000:0000:0000:0010:e000:0178:9eb1
> base lid: 0x6
> sm lid: 0x1
> state: 4: ACTIVE
> phys state: 5: LinkUp
> rate: 40 Gb/sec (4X QDR)
> link_layer: InfiniBand
>
> Cards are configured with IP addresses on private subnet for IPoIB
> performance testing.
> Regression identified in this bug is in TCP latency in this stack as reported
> by qperf tcp_lat metric:
>
> We have one system listen as a qperf server:
> [root@yourQperfServer ~]# qperf
>
> Have the other system connect to qperf server as a client (in this
> case, it’s X7 server with Mellanox card):
> [root@yourQperfClient ~]# numactl -m0 -N0 qperf 20.20.20.101 -v -uu -ub --time 60 --wait_server 20 -oo msg_size:4K:1024K:*2 tcp_lat
Rather than incur the scheduling latency from queue_work_on, we can
instead switch to running on the next timer tick, on the same core. This
also batches things a bit more -- once per jiffy -- which is okay now
that mix_interrupt_randomness() can credit multiple bits at once.
Reported-by: Sherry Yang <sherry.yang@oracle.com>
Tested-by: Paul Webb <paul.x.webb@oracle.com>
Cc: Sherry Yang <sherry.yang@oracle.com>
Cc: Phillip Goerl <phillip.goerl@oracle.com>
Cc: Jack Vogel <jack.vogel@oracle.com>
Cc: Nicky Veitch <nicky.veitch@oracle.com>
Cc: Colm Harrington <colm.harrington@oracle.com>
Cc: Ramanan Govindarajan <ramanan.govindarajan@oracle.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Tejun Heo <tj@kernel.org>
Cc: Sultan Alsawaf <sultan@kerneltoast.com>
Cc: stable@vger.kernel.org
Fixes: 58340f8e952b ("random: defer fast pool mixing to worker")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-10-15 07:54:40 +02:00
ACPI: processor: Remove freq Qos request for all CPUs
2022-09-05 10:27:44 +02:00
binder: fix UAF of ref->proc caused by race condition
2022-09-15 12:04:51 +02:00
libata: add ATA_HORKAGE_NOLPM for Pioneer BDR-207M and BDR-205
2022-10-05 10:37:42 +02:00
atm: idt77252: fix use-after-free bugs caused by tst_timer
2022-08-25 11:18:26 +02:00
x86/bugs: Report AMD retbleed vulnerability
2022-10-07 09:16:54 +02:00
loop: Check for overflow while configuring loop
2022-09-05 10:27:43 +02:00
Bluetooth: hci_intel: Add check for platform_driver_register
2022-08-25 11:17:47 +02:00
bus: hisi_lpc: fix missing platform_device_put() in hisi_lpc_acpi_probe()
2022-08-25 11:17:35 +02:00
random: use expired timer rather than wq for mixing fast pool
2022-10-15 07:54:40 +02:00
clk: iproc: Do not rely on node name for correct PLL setup
2022-10-05 10:37:45 +02:00
clocksource/drivers/ixp4xx: remove EXPORT_SYMBOL_GPL from ixp4xx_timer_setup()
2022-07-07 17:36:53 +02:00
x86/devicetable: Move x86 specific macro out of generic code
2022-10-07 09:16:54 +02:00
crypto: inside-secure - Add missing MODULE_DEVICE_TABLE for of
2022-08-25 11:17:48 +02:00
PM / devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events
2022-07-07 17:36:49 +02:00
dmaengine: xilinx_dma: Report error in case of dma_set_mask_and_coherent API failure
2022-10-15 07:54:37 +02:00
udmabuf: Set the DMA mask for the udmabuf device (v2)
2022-09-05 10:27:45 +02:00
extcon: Modify extcon device to be created after driver data is set
2022-06-14 18:12:00 +02:00
firewire: core: extend card->lock in fw_core_handle_bus_reset
2022-05-12 12:23:41 +02:00
firmware: arm_scmi: Add SCMI PM driver remove routine
2022-10-15 07:54:37 +02:00
fpga: altera-pr-ip: fix unsigned comparison with less than zero
2022-08-25 11:17:51 +02:00
gpio: mpc8xxx: Fix support for IRQ_TYPE_LEVEL_LOW flow_type in mpc85xx
2022-09-28 11:03:57 +02:00
Revert "drm/amdgpu: use dirty framebuffer helper"
2022-10-07 09:16:57 +02:00
hid: intel-ish-hid: ishtp: Fix ishtp client sending disordered message
2022-09-20 12:27:59 +02:00
Drivers: hv: Never allocate anything besides framebuffer from framebuffer memory region
2022-09-28 11:04:08 +02:00
hwmon: (gpio-fan) Fix array out of bounds access
2022-09-15 12:04:52 +02:00
intel_th: pci: Add Meteor Lake-P support
2022-08-25 11:18:13 +02:00
i2c: mux-gpmux: Add of_node_put() when breaking out of loop
2022-08-25 11:17:47 +02:00
intel_idle: Disable IBRS during long idle
2022-10-07 09:16:55 +02:00
iio: adc: mcp3911: use correct formula for AD conversion
2022-09-15 12:04:51 +02:00
RDMA/mlx5: Set local port to one when accessing counters
2022-09-15 12:04:55 +02:00
Input: melfas_mip4 - fix return value check in mip4_probe()
2022-10-05 10:37:44 +02:00
iommu/vt-d: avoid invalid memory access via node_online(NUMA_NO_NODE)
2022-08-25 11:18:15 +02:00
irqchip/tegra: Fix overflow implicit truncation warnings
2022-08-25 11:18:32 +02:00
macintosh/adb: fix oob read in do_adb_query() function
2022-08-11 12:57:53 +02:00
mailbox: forward the hrtimer if not queued and under a lock
2022-06-14 18:11:42 +02:00
md: call __md_stop_writes in md_stop
2022-09-05 10:27:44 +02:00
media: dvb_vb2: fix possible out of bound access
2022-10-05 10:37:43 +02:00
memstick/ms_block: Fix a memory leak
2022-08-25 11:17:55 +02:00
mfd: max77620: Fix refcount leak in max77620_initialise_fps
2022-08-25 11:18:04 +02:00
misc: fastrpc: fix memory corruption on open
2022-09-15 12:04:51 +02:00
mmc: core: Terminate infinite loop in SD-UHS voltage switch
2022-10-15 07:54:38 +02:00
mtd: st_spi_fsm: Add a clk_disable_unprepare() in .probe()'s error path
2022-08-25 11:17:51 +02:00
usbnet: Fix memory leak in usbnet_disconnect()
2022-10-05 10:37:44 +02:00
NFC: nxp-nci: don't print header length mismatch on i2c error
2022-07-21 20:59:25 +02:00
NTB: ntb_tool: uninitialized heap data in tool_fn_write()
2022-08-25 11:18:26 +02:00
nvdimm: Fix badblocks clear off-by-one error
2022-07-07 17:36:48 +02:00
nvme: Fix IOC_PR_CLEAR and IOC_PR_RELEASE ioctls for nvme devices
2022-10-05 10:37:45 +02:00
of: mdio: Add of_node_put() when breaking out of for_each_xx
2022-09-28 11:04:06 +02:00
opp: Fix error check in dev_pm_opp_attach_genpd()
2022-08-25 11:18:00 +02:00
parisc: ccio-dma: Add missing iounmap in error path in ccio_probe()
2022-09-28 11:03:57 +02:00
PCI: Add ACS quirk for Broadcom BCM5750x NICs
2022-08-25 11:18:31 +02:00
pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards
2022-06-14 18:11:50 +02:00
perf/arm_pmu_platform: fix tests for platform_get_irq() failure
2022-09-20 12:27:59 +02:00
phy: qcom-qmp: fix pipe-clock imbalance on power-on failure
2022-06-14 18:11:52 +02:00
pinctrl: amd: Don't save/restore interrupt status and wake status bits
2022-09-05 10:27:39 +02:00
platform/x86: acer-wmi: Acer Aspire One AOD270/Packard Bell Dot keymap fixes
2022-09-20 12:28:00 +02:00
power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe
2022-07-29 17:14:10 +02:00
pwm: lp3943: Fix duty calculation in case period was clamped
2022-06-14 18:11:51 +02:00
regulator: pfuze100: Fix the global-out-of-bounds access in pfuze100_regulator_probe()
2022-09-28 11:03:58 +02:00
remoteproc: qcom: wcnss: Fix handling of IRQs
2022-08-25 11:18:02 +02:00
rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
2022-10-15 07:54:38 +02:00
rtc: mt6397: check return value after calling platform_get_resource()
2022-06-14 18:11:53 +02:00
s390/dasd: fix Oops in dasd_alias_get_start_dev due to missing pavgroup
2022-09-28 11:04:08 +02:00
scsi: stex: Properly zero out the passthrough command structure
2022-10-15 07:54:39 +02:00
slimbus: qcom: Fix IRQ check in qcom_slim_probe
2022-05-18 09:47:27 +02:00
soc: sunxi: sram: Fix debugfs info for A64 SRAM C
2022-10-05 10:37:44 +02:00
soundwire: bus_type: fix remove and shutdown support
2022-08-25 11:17:54 +02:00
spi: spi-rspi: Fix PIO fallback on RZ platforms
2022-08-25 11:17:32 +02:00
staging: rtl8712: fix use after free bugs
2022-09-15 12:04:50 +02:00
tee: add overflow check in register_shm_helper()
2022-08-25 11:18:27 +02:00
thermal: sysfs: Fix cooling_device_stats_setup() error code path
2022-08-25 11:17:22 +02:00
thunderbolt: Use the actual buffer in tb_async_error()
2022-09-15 12:04:52 +02:00
serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting
2022-09-28 11:04:08 +02:00
USB: serial: qcserial: add new usb-id for Dell branded EM7455
2022-10-15 07:54:39 +02:00
vfio: Clear the caps->buf to NULL after free
2022-08-25 11:18:36 +02:00
vringh: Fix loop descriptors check in the indirect cases
2022-06-14 18:12:02 +02:00
video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write
2022-09-28 11:03:59 +02:00
vboxguest: Do not use devm for irq
2022-08-25 11:18:33 +02:00
virtio_mmio: Restore guest page size on resume
2022-07-21 20:59:24 +02:00
watchdog: armada_37xx_wdt: check the return value of devm_ioremap() in armada_37xx_wdt_probe()
2022-08-25 11:18:06 +02:00
xen/xenbus: fix return type in xenbus_file_read()
2022-08-25 11:18:26 +02:00
c634a9107f