Jan Kara
23a28f5f3f
Revert "mm/writeback: fix possible divide-by-zero in wb_dirty_limits(), again" ...
commit 30139c702048f1097342a31302cbd3d478f50c63 upstream.
Patch series "mm: Avoid possible overflows in dirty throttling".
Dirty throttling logic assumes dirty limits in page units fit into
32-bits. This patch series makes sure this is true (see patch 2/2 for
more details).
This patch (of 2):
This reverts commit 9319b647902cbd5cc884ac08a8a6d54ce111fc78.
The commit is broken in several ways. Firstly, the removed (u64) cast
from the multiplication will introduce a multiplication overflow on 32-bit
archs if wb_thresh * bg_thresh >= 1<<32 (which is actually common - the
default settings with 4GB of RAM will trigger this). Secondly, the
div64_u64() is unnecessarily expensive on 32-bit archs. We have
div64_ul() in case we want to be safe & cheap. Thirdly, if dirty
thresholds are larger than 1<<32 pages, then dirty balancing is going to
blow up in many other spectacular ways anyway so trying to fix one
possible overflow is just moot.
Link: https://lkml.kernel.org/r/20240621144017.30993-1-jack@suse.cz
Link: https://lkml.kernel.org/r/20240621144246.11148-1-jack@suse.cz
Fixes: 9319b647902c ("mm/writeback: fix possible divide-by-zero in wb_dirty_limits(), again")
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-By: Zach O'Keefe <zokeefe@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-07-18 11:40:51 +02:00
panic: Consolidate open-coded panic_on_warn checks
2023-02-06 07:52:50 +01:00
mm: bdi: initialize bdi_min_ratio when bdi is unregistered
2021-12-14 14:49:00 +01:00
mm/cma: use nth_page() in place of direct struct page manipulation
2023-11-28 16:50:19 +00:00
mm, vmscan: prevent infinite loop for costly GFP_NOIO | __GFP_RETRY_MAYFAIL allocations
2024-04-13 12:51:34 +02:00
mm: allow a controlled amount of unfairness in the page lock
2023-08-30 16:27:26 +02:00
v4l2: don't fall back to follow_pfn() if pin_user_pages_fast() fails
2022-12-08 11:23:06 +01:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
mm/hugetlb: fix races when looking up a CONT-PTE/PMD size hugetlb page
2022-12-19 12:24:15 +01:00
mm/thp: check and bail out if page in deferred queue already
2023-03-11 16:44:05 +01:00
mm/hugetlb: fix races when looking up a CONT-PTE/PMD size hugetlb page
2022-12-19 12:24:15 +01:00
mm/thp: fix vma_address() if virtual address below file offset
2021-06-30 08:47:52 -04:00
mm/khugepaged: fix collapse_pte_mapped_thp() to allow anon_vma
2023-01-24 07:18:01 +01:00
Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"
2022-09-15 12:04:49 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
mm: fix madivse_pageout mishandling on non-LRU page
2022-10-05 10:37:43 +02:00
Revert "mm: Always release pages to the buddy allocator in memblock_free_late()."
2023-02-22 12:50:39 +01:00
memcg: add refcnt for pcpu stock to avoid UAF problem in drain_all_stock()
2024-03-01 13:13:32 +01:00
memfd: fix F_SEAL_WRITE after shmem huge page allocated
2022-03-08 19:07:49 +01:00
mm/memory-failure: fix an incorrect use of tail pages
2024-04-13 12:51:31 +02:00
x86/mm/pat: fix VM_PAT handling in COW mappings
2024-04-13 12:51:40 +02:00
mm/memory_hotplug: use "unsigned long" for PFN in zone_for_pfn_range()
2021-09-22 12:26:43 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
memtest: use {READ,WRITE}_ONCE in memory scanning
2024-04-13 12:51:27 +02:00
mm/migrate: set swap entry values of THP tail pages properly.
2024-04-13 12:51:31 +02:00
mm: Fix TLB flush for not-first PFNMAP mappings in unmap_region()
2022-09-20 12:28:00 +02:00
mm/khugepaged: fix GUP-fast interaction by sending IPI
2022-12-14 11:30:42 +01:00
arm: remove CONFIG_ARCH_HAS_HOLES_MEMORYMODEL
2022-05-15 19:54:46 +02:00
mm/mremap: hold the rmap lock in write mode when moving page table entries.
2022-08-25 11:17:20 +02:00
oom_kill.c: futex: delay the OOM reaper to allow time for proper futex cleanup
2022-04-27 13:50:48 +02:00
Revert "mm/writeback: fix possible divide-by-zero in wb_dirty_limits(), again"
2024-07-18 11:40:51 +02:00
mm, vmscan: prevent infinite loop for costly GFP_NOIO | __GFP_RETRY_MAYFAIL allocations
2024-04-13 12:51:34 +02:00
mm: fix unexpected zeroed page mapping with zram swap
2022-05-12 12:23:48 +02:00
mm/thp: another PVMW_SYNC fix in page_vma_mapped_walk()
2021-06-30 08:47:55 -04:00
mm: pagewalk: Fix race between unmap and page walker
2022-10-15 07:54:36 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
mm/thp: fix __split_huge_pmd_locked() on shmem migration entry
2021-06-30 08:47:52 -04:00
vfs: fix readahead(2) on block devices
2023-11-20 10:30:08 +01:00
mm/rmap: Fix anon_vma->degree ambiguity leading to double-reuse
2022-09-05 10:27:46 +02:00
tmpfs: verify {g,u}id mount options correctly
2023-09-23 10:59:40 +02:00
mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag
2021-11-26 10:47:21 +01:00
mm: slab: fix kmem_cache_create failed when sysfs node not destroyed
2021-07-25 14:35:14 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
mm/swap: fix swap_info_struct race between swapoff and get_swap_pages()
2023-04-20 12:07:35 +02:00
mm/thp: unmap_mapping_page() to fix THP truncate_cleanup_page()
2021-06-30 08:47:53 -04:00
mm/usercopy: return 1 from hardened_usercopy __setup() handler
2022-04-15 14:18:30 +02:00
userfaultfd: fix mmap_changing checking in mfill_atomic_hugetlb
2024-03-01 13:13:33 +01:00
random: move randomize_page() into mm where it belongs
2022-06-22 14:11:17 +02:00
mm, vmscan: prevent infinite loop for costly GFP_NOIO | __GFP_RETRY_MAYFAIL allocations
2024-04-13 12:51:34 +02:00
arm: remove CONFIG_ARCH_HAS_HOLES_MEMORYMODEL
2022-05-15 19:54:46 +02:00
mm/z3fold: fix potential memory leak in z3fold_destroy_pool()
2021-07-14 16:53:47 +02:00
zsmalloc: fix races between asynchronous zspage free and page migration
2022-06-06 08:33:50 +02:00
23a28f5f3f