Duncan Laurie
32d33b29ba
TPM: Retry SaveState command in suspend path ...
If the TPM has already been sent a SaveState command before the driver
is loaded it may have problems sending that same command again later.
This issue is seen with the Chromebook Pixel due to a firmware bug in
the legacy mode boot path which is sending the SaveState command
before booting the kernel. More information is available at
http://crbug.com/203524
This change introduces a retry of the SaveState command in the suspend
path in order to work around this issue. A future firmware update
should fix this but this is also a trivial workaround in the driver
that has no effect on systems that do not show this problem.
When this does happen the TPM responds with a non-fatal TPM_RETRY code
that is defined in the specification:
The TPM is too busy to respond to the command immediately, but the
command could be resubmitted at a later time. The TPM MAY return
TPM_RETRY for any command at any time.
It can take several seconds before the TPM will respond again. I
measured a typical time between 3 and 4 seconds and the timeout is set
at a safe 5 seconds.
It is also possible to reproduce this with commands via /dev/tpm0.
The bug linked above has a python script attached which can be used to
test for this problem. I tested a variety of TPMs from Infineon,
Nuvoton, Atmel, and STMicro but was only able to reproduce this with
LPC and I2C TPMs from Infineon.
The TPM specification only loosely defines this behavior:
TPM Main Level 2 Part 3 v1.2 r116, section 3.3. TPM_SaveState:
The TPM MAY declare all preserved values invalid in response to any
command other than TPM_Init.
TCG PC Client BIOS Spec 1.21 section 8.3.1.
After issuing a TPM_SaveState command, the OS SHOULD NOT issue TPM
commands before transitioning to S3 without issuing another
TPM_SaveState command.
TCG PC Client TIS 1.21, section 4. Power Management:
The TPM_SaveState command allows a Static OS to indicate to the TPM
that the platform may enter a low power state where the TPM will be
required to enter into the D3 power state. The use of the term "may"
is significant in that there is no requirement for the platform to
actually enter the low power state after sending the TPM_SaveState
command. The software may, in fact, send subsequent commands after
sending the TPM_SaveState command.
Change-Id: I52b41e826412688e5b6c8ddd3bb16409939704e9
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com>
2013-04-17 09:31:32 -05:00
ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type
2013-03-04 14:23:40 +01:00
Merge branch 'for-linus' of git://git.linaro.org/people/rmk/linux-arm
2013-03-03 11:54:39 -08:00
ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type
2013-03-04 14:23:40 +01:00
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
ACPI and power management fixes for 3.9-rc2
2013-03-07 14:54:28 -08:00
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless into for-davem
2013-03-01 13:52:03 -05:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client
2013-02-28 17:43:09 -08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2013-02-21 17:40:58 -08:00
TPM: Retry SaveState command in suspend path
2013-04-17 09:31:32 -05:00
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
ImgTec Meta architecture changes for v3.9-rc1
2013-03-03 12:06:09 -08:00
proc connector: reject unprivileged listener bumps
2013-02-27 13:08:35 -05:00
cpufreq / intel_pstate: Do not load on VM that does not report max P state.
2013-03-06 23:40:11 +01:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2013-02-25 15:56:15 -08:00
dca: convert to idr_alloc()
2013-02-27 19:10:15 -08:00
Merge branch 'next' of git://git.infradead.org/users/vkoul/slave-dma
2013-03-03 10:20:22 -08:00
Merge branch 'linux_next' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac
2013-02-28 20:42:33 -08:00
firewire: convert to idr_alloc()
2013-02-27 19:10:15 -08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2013-03-09 16:51:13 -08:00
gpio/gpio-ich: fix ichx_gpio_check_available() return what callers expect
2013-03-02 13:20:21 +00:00
drm/tegra: drop "select DRM_HDMI"
2013-03-08 08:36:01 +10:00
Merge branch 'for-3.9/upstream-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
2013-03-08 14:42:52 -08:00
hsi: fix kernel-doc warnings
2013-03-01 13:39:00 -08:00
Drivers: hv: vmbus: Use the new infrastructure for delivering VMBUS interrupts
2013-02-27 10:15:53 -08:00
hwmon: (sht15) Check return value of regulator_enable()
2013-03-03 21:45:48 -08:00
idr: remove MAX_IDR_MASK and move left MAX_IDR_* into idr.c
2013-02-27 19:10:20 -08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2013-02-26 20:16:07 -08:00
Merge branch 'core-locking-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2013-02-22 19:25:09 -08:00
fs: Limit sys_mount to only request filesystem modules.
2013-03-03 19:36:31 -08:00
Atmel MXT touchscreen: increase reset timeouts
2013-03-09 10:31:01 -08:00
iommu, x86: Add DMA remap fault reason
2013-03-06 09:41:51 +01:00
ImgTec Meta architecture changes for v3.9-rc1
2013-03-03 12:06:09 -08:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2013-03-05 18:42:29 -08:00
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds
2013-02-26 09:29:02 -08:00
All trivial, thanks to the stuff which didn't quite make it time.
2013-02-26 14:49:12 -08:00
Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc
2013-02-23 17:09:55 -08:00
mailbox, pl320-ipc: remove __init from probe function
2013-03-04 14:23:11 +01:00
md updates for 3.9
2013-03-05 17:22:08 -08:00
arm-soc: late OMAP changes
2013-02-28 20:00:40 -08:00
memstick: move the dereference below the NULL test
2013-02-27 19:10:23 -08:00
mfd: convert to idr_alloc()
2013-02-27 19:10:17 -08:00
fs: Limit sys_mount to only request filesystem modules.
2013-03-03 19:36:31 -08:00
Merge branches 'devel-stable', 'fixes' and 'mmci' into for-linus
2013-03-03 00:32:50 +00:00
fs: Limit sys_mount to only request filesystem modules.
2013-03-03 19:36:31 -08:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2013-03-05 18:42:29 -08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2013-02-21 17:40:58 -08:00
fs: Limit sys_mount to only request filesystem modules.
2013-03-03 19:36:31 -08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2013-02-26 20:16:07 -08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2013-02-21 17:54:03 -08:00
ACPI / glue: Add .match() callback to struct acpi_bus_type
2013-03-04 14:23:40 +01:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2013-02-21 17:40:58 -08:00
Platform: x86: chromeos_laptop : Add basic platform data for atmel devices
2013-03-08 16:03:29 -08:00
ACPI / glue: Add .match() callback to struct acpi_bus_type
2013-03-04 14:23:40 +01:00
power: convert to idr_alloc()
2013-02-27 19:10:18 -08:00
drivers/pps/clients/pps-gpio.c: use devm_kzalloc
2013-02-27 19:10:23 -08:00
pwm: Changes for v3.9-rc1
2013-02-26 09:34:29 -08:00
Merge remote-tracking branch 'regulator/fix/twl' into tmp
2013-03-05 10:12:43 +08:00
remoteproc: convert to idr_alloc()
2013-02-27 19:10:18 -08:00
rpmsg: convert to idr_alloc()
2013-02-27 19:10:18 -08:00
rtc: stmp3xxx: add wdt-accessor function
2013-03-01 12:40:36 +01:00
qdio: remove unused parameters
2013-02-28 09:37:12 +01:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2013-02-26 20:16:07 -08:00
ACPI / glue: Add .match() callback to struct acpi_bus_type
2013-03-04 14:23:40 +01:00
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux into mips-for-linux-next
2013-02-22 10:07:30 +01:00
fs: Limit sys_mount to only request filesystem modules.
2013-03-03 19:36:31 -08:00
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending
2013-03-02 11:43:27 -08:00
Fix mis-merge of intel_powerclamp.c resulting in compile error
2013-02-28 20:23:09 -08:00
drivers/tty/hvc: Use strlcpy instead of strncpy
2013-03-05 16:56:27 +11:00
uio: convert to idr_alloc()
2013-02-27 19:10:19 -08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2013-03-09 16:51:13 -08:00
vfio: convert to idr_alloc()
2013-02-27 19:10:19 -08:00
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending
2013-02-26 11:42:23 -08:00
backlight: add new lp8788 backlight driver
2013-02-27 19:10:09 -08:00
All trivial, thanks to the stuff which didn't quite make it time.
2013-02-26 14:49:12 -08:00
arm-soc: i.MX DT changes
2013-02-28 19:59:34 -08:00
watchdog: sp805_wdt depends on ARM
2013-03-01 12:56:26 +01:00
fs: Limit sys_mount to only request filesystem modules.
2013-03-03 19:36:31 -08:00
new helper: file_inode(file)
2013-02-22 23:31:31 -05:00
Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc
2013-02-23 17:09:55 -08:00
32d33b29ba