Nicholas Bellinger
5259a06ef9
target: Fix percpu_ref_put race in transport_lun_remove_cmd
...
This patch fixes a percpu_ref_put race for se_lun->lun_ref in
transport_lun_remove_cmd() where ->lun_ref could end up being
put more than once per command via different target completion
and fabric release contexts.
It adds a cmpxchg() for se_cmd->lun_ref_active to ensure that
percpu_ref_put() is only ever called once per se_cmd.
This bug was manifesting itself as a LUN shutdown regression
bug in >= v3.13 code, where percpu_ref_kill() would end up
hanging indefinately due to the incorrect percpu_ref count.
(Change se_cmd->lun_ref_active from bool -> int to force at
least a 4-byte cmpxchg with MIPS ll/sc ins. - Fengguang)
Reported-by: Tommy Apel <tommyapeldk@gmail.com>
Cc: Tommy Apel <tommyapeldk@gmail.com>
Cc: <stable@vger.kernel.org> #3.13+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2014-01-30 03:58:34 -08:00
..
iscsi
target/iscsi: Fix network portal creation race
2014-01-30 03:57:59 -08:00
loopback
tcm_loop: Enable DIF/DIX modes in SCSI host LLD
2014-01-19 02:22:06 +00:00
sbp
tcm_fc
percpu_ida: Make percpu_ida_alloc + callers accept task state bitmask
2014-01-23 20:17:18 +00:00
Kconfig
target/iblock: Add blk_integrity + BIP passthrough support
2014-01-18 10:14:22 +00:00
Makefile
target_core_alua.c
target_core_alua: check for buffer overflow
2014-01-09 21:48:38 -08:00
target_core_alua.h
target_core_alua: Referrals configfs integration
2014-01-09 21:48:35 -08:00
target_core_configfs.c
target/configfs: Expose protection device attributes
2014-01-18 09:57:47 +00:00
target_core_device.c
target/configfs: Expose protection device attributes
2014-01-18 09:57:47 +00:00
target_core_fabric_configfs.c
target: Fix sizeof in kmalloc for some default_groups arrays
2013-12-16 12:42:20 -08:00
target_core_fabric_lib.c
target_core_file.c
target/file: Add DIF protection support to fd_execute_rw
2014-01-19 02:21:55 +00:00
target_core_file.h
target/file: Add DIF protection support to fd_execute_rw
2014-01-19 02:21:55 +00:00
target_core_hba.c
target_core_iblock.c
target/iblock: Add blk_integrity + BIP passthrough support
2014-01-18 10:14:22 +00:00
target_core_iblock.h
target_core_internal.h
target/configfs: Expose protection device attributes
2014-01-18 09:57:47 +00:00
target_core_pr.c
target core: rename (ex,im)plict -> (ex,im)plicit
2013-11-20 11:24:40 -08:00
target_core_pr.h
drivers: target: Move prototype declaration of function to header file target_core_pr.h
2014-01-09 21:48:36 -08:00
target_core_pscsi.c
target/pscsi: fix return value check
2013-10-25 10:42:09 -07:00
target_core_pscsi.h
target_core_rd.c
target/rd: Add DIF protection into rd_execute_rw
2014-01-19 02:22:06 +00:00
target_core_rd.h
target/rd: Add support for protection SGL setup + release
2014-01-19 02:22:05 +00:00
target_core_sbc.c
target: Report bad sector in sense data for DIF errors
2014-01-25 06:58:53 +00:00
target_core_spc.c
target/spc: Expose ATO bit in control mode page
2014-01-18 09:53:14 +00:00
target_core_stat.c
target: Convert se_device statistics to atomic_long_t
2013-11-13 18:34:55 -08:00
target_core_tmr.c
target: Convert se_device statistics to atomic_long_t
2013-11-13 18:34:55 -08:00
target_core_tpg.c
target: Don't use void* when passing dev in core_tpg_add_lun
2013-12-16 13:29:20 -08:00
target_core_transport.c
target: Fix percpu_ref_put race in transport_lun_remove_cmd
2014-01-30 03:58:34 -08:00
target_core_ua.c
target: Remove unused ua_dev_list member in struct se_ua
2013-12-16 12:39:04 -08:00
target_core_ua.h
target core: rename (ex,im)plict -> (ex,im)plicit
2013-11-20 11:24:40 -08:00
target_core_xcopy.c
drivers: target: Move prototype declaration of function to header file target_core_pr.h
2014-01-09 21:48:36 -08:00
target_core_xcopy.h