Benjamin Coddington
3b83759fd4
nfsd: Fix race to FREE_STATEID and cl_revoked ...
commit 3b816601e279756e781e6c4d9b3f3bd21a72ac67 upstream.
We have some reports of linux NFS clients that cannot satisfy a linux knfsd
server that always sets SEQ4_STATUS_RECALLABLE_STATE_REVOKED even though
those clients repeatedly walk all their known state using TEST_STATEID and
receive NFS4_OK for all.
Its possible for revoke_delegation() to set NFS4_REVOKED_DELEG_STID, then
nfsd4_free_stateid() finds the delegation and returns NFS4_OK to
FREE_STATEID. Afterward, revoke_delegation() moves the same delegation to
cl_revoked. This would produce the observed client/server effect.
Fix this by ensuring that the setting of sc_type to NFS4_REVOKED_DELEG_STID
and move to cl_revoked happens within the same cl_lock. This will allow
nfsd4_free_stateid() to properly remove the delegation from cl_revoked.
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2217103
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2176575
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Cc: stable@vger.kernel.org # v4.17+
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-08-30 16:27:25 +02:00
9p: missing chunk of "fs/9p: Don't update file type when updating file attributes"
2022-06-22 14:11:02 +02:00
affs: initialize fsdata in affs_truncate()
2023-02-06 07:52:36 +01:00
afs: Fix vlserver probe RTT handling
2023-06-21 15:44:12 +02:00
btrfs: fix BUG_ON condition in btrfs_cancel_balance
2023-08-30 16:27:15 +02:00
ceph: defer stopping mdsc delayed_work
2023-08-11 11:54:01 +02:00
cifs: Release folio lock on fscache read hit.
2023-08-30 16:27:19 +02:00
coda: Avoid partial allocation of sig_inputArgs
2023-03-11 16:43:56 +01:00
configfs: fix possible memory leak in configfs_create_dir()
2023-01-18 11:41:09 +01:00
fscrypt: add fscrypt_symlink_getattr() for computing st_size
2021-09-12 08:56:38 +02:00
debugfs: regset32: Add Runtime PM support
2023-05-17 11:35:32 +02:00
fsnotify: fix fsnotify hooks in pseudo filesystems
2022-02-01 17:24:34 +01:00
fs: dlm: fix mismatch of plock results from userspace
2023-08-30 16:27:21 +02:00
erofs: fix compact 4B support for 16k block size
2023-07-27 08:37:35 +02:00
ext2: Drop fragment support
2023-08-11 11:53:59 +02:00
ext4: fix to check return value of freeze_bdev() in ext4_shutdown()
2023-08-11 11:53:47 +02:00
Revert "f2fs: fix potential corruption when moving a directory"
2023-07-27 08:37:26 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
fscache: Fix cookie key hashing
2021-09-22 12:26:25 +02:00
fuse: revalidate: don't invalidate if interrupted
2023-07-27 08:37:40 +02:00
gfs2: Fix possible data races in gfs2_show_options()
2023-08-30 16:27:10 +02:00
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
2023-03-11 16:43:59 +01:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
hugetlbfs: fix null-ptr-deref in hugetlbfs_parse_param()
2023-01-18 11:41:38 +01:00
iomap: iomap_write_failed fix
2022-06-14 18:11:36 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint
2023-08-11 11:53:43 +02:00
jffs2: reduce stack usage in jffs2_build_xattr_subsystem()
2023-07-27 08:37:25 +02:00
FS: JFS: Check for read-only mounted filesystem in txBegin
2023-08-30 16:27:10 +02:00
kernfs: fix use-after-free in __kernfs_remove
2022-11-03 23:56:54 +09:00
lockd: lockd server-side shouldn't set fl_ops
2021-09-22 12:26:34 +02:00
minix: fix bug when opening a file with O_DIRECT
2022-04-15 14:18:35 +02:00
NFSv4: Fix dropped lock for racing OPEN and delegation return
2023-08-30 16:27:24 +02:00
nfsd: Fix race to FREE_STATEID and cl_revoked
2023-08-30 16:27:25 +02:00
nilfs2: fix use-after-free of nilfs_root in dirtying inodes via iput
2023-08-16 18:19:23 +02:00
fanotify: disallow mount/sb marks on kernel internal pseudo fs
2023-07-27 08:37:26 +02:00
ntfs: check overflow when iterating ATTR_RECORDs
2022-11-25 17:42:22 +01:00
ocfs2: check new file size on fallocate call
2023-06-21 15:44:10 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
orangefs: Fix kmemleak in orangefs_{kernel,client}_debug_init()
2023-01-18 11:41:39 +01:00
ovl: check type and offset of struct vfsmount in ovl_entry
2023-08-30 16:27:09 +02:00
mm: hugetlb: proc: check for hugetlb shared PMD in /proc/PID/smaps
2023-02-22 12:50:28 +01:00
pstore/ram: Add check for kstrdup
2023-07-27 08:37:06 +02:00
qnx4: work around gcc false positive warning bug
2021-09-30 10:09:26 +02:00
quota: fix warning in dqgrab()
2023-08-30 16:27:09 +02:00
reiserfs: Add security prefix to xattr name in reiserfs_security_write()
2023-05-17 11:35:33 +02:00
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-22 12:50:39 +01:00
fs/sysv: Null check to prevent null-ptr-deref bug
2023-08-11 11:53:59 +02:00
tracefs: Only clobber mode/uid/gid on remount if asked
2022-09-20 12:28:00 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
udf: Fix uninitialized array access for some pathnames
2023-08-30 16:27:09 +02:00
fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY
2023-04-05 11:16:42 +02:00
xfs: verify buffer contents when we skip log replay
2023-06-28 10:18:42 +02:00
aio: fix mremap after fork null-deref
2023-02-22 12:50:35 +01:00
vfs: Check the truncate maximum size in inode_newsize_ok()
2022-08-25 11:17:21 +02:00
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
2023-01-18 11:41:46 +01:00
elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings
2021-10-06 15:42:35 +02:00
binfmt: Fix error return code in load_elf_fdpic_binary()
2023-01-18 11:41:46 +01:00
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
2023-01-18 11:41:46 +01:00
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2023-01-18 11:41:33 +01:00
mm: fs: initialize fsdata passed to write_begin/write_end interface
2022-11-25 17:42:22 +01:00
chardev: fix error handling in cdev_device_add()
2023-01-18 11:41:25 +01:00
compat_ioctl: remove /dev/random commands
2022-06-22 14:11:03 +02:00
dax: fix cache flush on PMD-mapped pages
2022-06-14 18:11:41 +02:00
epoll: ep_autoremove_wake_function should use list_del_init_careful
2023-06-28 10:18:35 +02:00
exec: Force single empty string when argv is empty
2022-06-06 08:33:50 +02:00
fcntl: fix potential deadlock for &fasync_struct.fa_lock
2021-09-15 09:47:28 +02:00
fs: prevent out-of-bounds array speculation when closing a file descriptor
2023-03-17 08:32:47 +01:00
SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()
2022-05-25 09:14:34 +02:00
writeback: fix call of incorrect macro
2023-05-17 11:35:58 +02:00
fs: avoid empty option when generating legacy mount string
2023-07-27 08:37:25 +02:00
fs: Establish locking order for unrelated directories
2023-07-27 08:37:26 +02:00
fs: Establish locking order for unrelated directories
2023-07-27 08:37:26 +02:00
io_uring: have io_kill_timeout() honor the request references
2023-06-05 08:17:32 +02:00
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
2023-01-18 11:40:55 +01:00
mbcache: Avoid nesting of cache->c_list_lock under bit locks
2023-01-18 11:41:59 +01:00
fs: no need to check source
2023-07-27 08:37:26 +02:00
fs: warn about impending deprecation of mandatory locks
2021-08-26 08:36:22 -04:00
pipe: increase minimum default pipe size to 2 pages
2021-08-12 13:21:02 +02:00
pnode: terminate at peers of source
2023-01-18 11:41:44 +01:00
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:25:11 +01:00
seq_file: disallow extremely large seq buffer allocations
2021-07-20 16:10:54 +02:00
io_uring: disable polling pollfree files
2022-09-05 10:27:47 +02:00
Revert "fs: check FMODE_LSEEK to control internal pipe splicing"
2022-10-17 17:24:32 +02:00
stat: fix inconsistency between struct stat and struct compat_stat
2022-04-27 13:50:48 +02:00
statfs: enforce statfs[64] structure initialization
2023-05-30 12:44:07 +01:00
fs: Protect reconfiguration of sb read-write from racing writes
2023-08-11 11:53:59 +02:00
userfaultfd: open userfaultfds with O_RDONLY
2022-10-26 13:22:21 +02:00
fs: don't audit the capability check in simple_xattr_list()
2023-01-18 11:40:53 +01:00
3b83759fd4