Heiner Kallweit
584ce30c72
rtc: ds1307: improve weekday handling ...
The current code for checking and fixing the weekday in ds1307_probe
faces some issues:
- This check is applied to all chips even if its applicable (AFAIK)
to mcp794xx only
- The check uses MCP794XX constants for registers and bits even though
it's executed also on other chips (ok, this could be fixed easily)
- It relies on tm_wday being properly populated when core calls set_time
and set_alarm. This is not guaranteed at all.
First two issue we could solve by moving the check to the
mcp794xx-specific initialization (where also VBATEN flag is set).
The proposed alternative is in the set_alarm path for mcp794xx only and
calculates the alarm weekday based on the current weekday in the RTC
timekeeping regs and the difference between alarm date and current date.
So we are fine with any weekday even if it doesn't match the date.
Still there are cases where this could fail, e.g.:
- rtc date/time + weekday have power-on-reset default values
- alarm is set to actual date/time + x
- set_time is called (may change diff between rtc weekday and actual
weekday)
But similar issues we have with the current code too:
- rtc date/time + weekday have power-on-reset default values
- alarm is set to rtc date/time + x
- set_time is called before the alarm triggers
Using random rtc date/time with relative alarms simply can interfere
with set_time. I'm not totally convinced of either option yet.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
2017-10-12 14:16:09 +02:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
ANDROID: binder: don't queue async transactions to thread.
2017-09-01 09:22:50 +02:00
Merge branch 'for-4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2017-09-06 22:41:21 -07:00
firmware: Restore support for built-in firmware
2017-09-16 10:58:48 -07:00
The highlights include:
2017-09-12 20:03:53 -07:00
ARM: SoC driver updates for v4.14
2017-09-10 20:40:00 -07:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
The diff is dominated by the Allwinner A10/A20 SoCs getting converted to
2017-09-13 11:04:14 -07:00
Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus
2017-09-15 20:43:33 -07:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus
2017-09-15 20:43:33 -07:00
dmaengine updates for 4.14-rc1
2017-09-07 14:03:05 -07:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
dmaengine updates for 4.14-rc1
2017-09-07 14:03:05 -07:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
- New Drivers
2017-09-07 13:51:13 -07:00
amd fixes pull
2017-09-15 17:52:52 -07:00
media updates for v4.14-rc1
2017-09-07 12:53:14 -07:00
Merge branch 'x86-platform-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2017-09-07 09:25:15 -07:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
i2c: i2c-stm32f7: add driver
2017-09-14 17:34:43 +02:00
Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block
2017-09-07 11:59:42 -07:00
Power management updates for v4.14-rc1
2017-09-05 12:19:08 -07:00
- New Drivers
2017-09-07 13:51:13 -07:00
IB/mlx4: fix sprintf format warning
2017-09-13 18:53:15 -07:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
2017-09-16 11:24:26 -07:00
IOMMU Updates for Linux v4.14
2017-09-09 15:03:24 -07:00
Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus
2017-09-15 20:43:33 -07:00
isdn: isdnloop: fix logic error in isdnloop_sendbuf
2017-09-07 20:03:54 -07:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
powerpc/macintosh: constify wf_sensor_ops structures
2017-09-01 16:42:54 +10:00
Just behavorial changes to a controller driver:
2017-09-07 13:23:37 -07:00
Char/Misc drivers for 4.14-rc1
2017-09-05 11:08:17 -07:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-09-14 18:13:32 -07:00
ARM: SoC driver updates for v4.14
2017-09-10 20:40:00 -07:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
mm: treewide: remove GFP_TEMPORARY allocation flag
2017-09-13 18:53:16 -07:00
mmc: renesas_sdhi: Add r8a7743/5 support
2017-09-01 15:31:01 +02:00
This pull request contains updates for UBI:
2017-09-16 12:08:10 -07:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2017-09-16 11:28:59 -07:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
nvme-pci: implement the HMB entry number and size limitations
2017-09-11 12:29:40 -04:00
dma-mapping updates for 4.14:
2017-09-12 13:30:06 -07:00
Char/Misc drivers for 4.14-rc1
2017-09-05 11:08:17 -07:00
Revert "PCI: Avoid race while enabling upstream bridges"
2017-09-15 01:33:51 -05:00
Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus
2017-09-15 20:43:33 -07:00
pinctrl/amd: save pin registers over suspend/resume
2017-09-12 15:58:45 +02:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
power supply and reset changes for the v4.14 series
2017-09-09 14:44:39 -07:00
drivers/pps: use surrounding "if PPS" to remove numerous dependency checks
2017-09-08 18:26:51 -07:00
pwm: Changes for v4.14-rc1
2017-09-11 13:04:32 -07:00
- New Drivers
2017-09-07 13:51:13 -07:00
rpmsg updates for v4.14
2017-09-09 14:34:38 -07:00
Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus
2017-09-15 20:43:33 -07:00
rpmsg: glink: initialize ret to zero to ensure error status check is correct
2017-09-04 10:52:30 -07:00
rtc: ds1307: improve weekday handling
2017-10-12 14:16:09 +02:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2017-09-12 06:01:59 -07:00
SCSI misc on 20170913
2017-09-13 10:47:14 -07:00
Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus
2017-09-15 20:43:33 -07:00
ACPI updates for v4.14-rc1
2017-09-05 12:45:03 -07:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-09-14 18:54:01 -07:00
Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-09-14 18:13:32 -07:00
Merge branches 'thermal-core', 'thermal-soc', 'thermal-intel' and 'const-thermal-zone-structure' into next
2017-09-08 11:20:04 +08:00
ACPI updates for v4.14-rc1
2017-09-05 12:45:03 -07:00
dmi: Mark all struct dmi_system_id instances const
2017-09-14 11:59:30 +02:00
Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-09-14 18:13:32 -07:00
lib/interval_tree: fast overlap detection
2017-09-08 18:26:49 -07:00
fbdev changes for v4.14:
2017-09-14 13:33:33 -07:00
SCSI misc on 20170907
2017-09-07 21:11:05 -07:00
power supply and reset changes for the v4.14 series
2017-09-09 14:44:39 -07:00
Merge branch '4.14-features' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus
2017-09-15 20:43:33 -07:00
mm: treewide: remove GFP_TEMPORARY allocation flag
2017-09-13 18:53:16 -07:00
584ce30c72