Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Daniel Borkmann 585f5a6252 bpf, sockmap: fix sock_map_ctx_update_elem race with exist/noexist ... The current code in sock_map_ctx_update_elem() allows for BPF_EXIST and BPF_NOEXIST map update flags. While on array-like maps this approach is rather uncommon, e.g. bpf_fd_array_map_update_elem() and others enforce map update flags to be BPF_ANY such that xchg() can be used directly, the current implementation in sock map does not guarantee that such operation with BPF_EXIST / BPF_NOEXIST is atomic. The initial test does a READ_ONCE(stab->sock_map[i]) to fetch the socket from the slot which is then tested for NULL / non-NULL. However later after __sock_map_ctx_update_elem(), the actual update is done through osock = xchg(&stab->sock_map[i], sock). Problem is that in the meantime a different CPU could have updated / deleted a socket on that specific slot and thus flag contraints won't hold anymore. I've been thinking whether best would be to just break UAPI and do an enforcement of BPF_ANY to check if someone actually complains, however trouble is that already in BPF kselftest we use BPF_NOEXIST for the map update, and therefore it might have been copied into applications already. The fix to keep the current behavior intact would be to add a map lock similar to the sock hash bucket lock only for covering the whole map. Fixes: 174a79ff95 ("bpf: sockmap with sk redirect support") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: John Fastabend <john.fastabend@gmail.com> Acked-by: Song Liu <songliubraving@fb.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org>		2018-08-16 14:58:08 -07:00
..
bpf	bpf, sockmap: fix sock_map_ctx_update_elem race with exist/noexist	2018-08-16 14:58:08 -07:00
cgroup	kernfs: allow creating kernfs objects with arbitrary uid/gid	2018-07-20 23:44:35 -07:00
configs	kconfig: tinyconfig: remove stale stack protector fixups	2018-06-15 07:15:28 +09:00
debug	treewide: kzalloc() -> kcalloc()	2018-06-12 16:19:22 -07:00
dma	dma-mapping updates for 4.19	2018-08-14 11:11:52 -07:00
events	arm64 updates for 4.19	2018-08-14 16:39:13 -07:00
gcov	gcov: remove CONFIG_GCOV_FORMAT_AUTODETECT	2018-06-08 18:56:02 +09:00
irq	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-08-13 10:47:26 -07:00
livepatch
locking	Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-08-13 10:49:41 -07:00
power	Power management updates for 4.19-rc1	2018-08-14 13:12:24 -07:00
printk	Merge branch 'for-4.19-nmi' into for-linus	2018-08-14 13:36:15 +02:00
rcu	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-08-13 11:25:07 -07:00
sched	Merge branch 'l1tf-final' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-08-14 09:46:06 -07:00
time	Merge branch 'parisc-4.19-1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux	2018-08-13 19:18:02 -07:00
trace	Printk changes for 4.19	2018-08-15 11:18:53 -07:00
.gitignore
acct.c
async.c
audit.c	audit: use ktime_get_coarse_real_ts64() for timestamps	2018-07-17 14:45:08 -04:00
audit.h
audit_fsnotify.c	fsnotify: add fsnotify_add_inode_mark() wrappers	2018-05-18 14:58:22 +02:00
audit_tree.c	audit: check audit_enabled in audit_tree_log_remove_rule()	2018-06-28 11:41:02 -04:00
audit_watch.c	audit: fix use-after-free in audit_add_watch	2018-07-18 11:43:36 -04:00
auditfilter.c	audit: rename FILTER_TYPE to FILTER_EXCLUDE	2018-06-19 10:39:54 -04:00
auditsc.c	audit/stable-4.18 PR 20180814	2018-08-15 10:46:54 -07:00
backtracetest.c
bounds.c
capability.c
compat.c	time: Enable get/put_compat_itimerspec64 always	2018-06-24 14:39:47 +02:00
configs.c
context_tracking.c
cpu.c	cpu/hotplug: Non-SMP machines do not make use of booted_once	2018-08-14 15:00:00 -07:00
cpu_pm.c
crash_core.c	mm: split page_type out from _mapcount	2018-06-07 17:34:37 -07:00
crash_dump.c
cred.c
delayacct.c
dma.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
elfcore.c
exec_domain.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
exit.c
extable.c
fail_function.c	bpf/error-inject/kprobes: Clear current_kprobe and enable preempt in kprobe	2018-06-21 12:33:19 +02:00
fork.c	for-4.19/block-20180812	2018-08-14 10:23:25 -07:00
freezer.c	PM / reboot: Eliminate race between reboot and suspend	2018-08-06 12:35:20 +02:00
futex.c
futex_compat.c
groups.c
hung_task.c	kernel/hung_task.c: show all hung tasks before panic	2018-06-07 17:34:39 -07:00
iomem.c	memremap: split devm_memremap_pages() and memremap() infrastructure	2018-05-15 23:08:33 -07:00
irq_work.c
jump_label.c
kallsyms.c
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt	kconfig: include kernel/Kconfig.preempt from init/Kconfig	2018-08-02 08:06:54 +09:00
kcov.c	sched/core / kcov: avoid kcov_area during task switch	2018-06-15 07:55:24 +09:00
kexec.c	kexec: add call to LSM hook in original kexec_load syscall	2018-07-16 12:31:57 -07:00
kexec_core.c	kexec: yield to scheduler when loading kimage segments	2018-06-15 07:55:24 +09:00
kexec_file.c	treewide: Use array_size() in vzalloc()	2018-06-12 16:19:22 -07:00
kexec_internal.h
kmod.c
kprobes.c	kprobes: Replace %p with other pointer types	2018-06-21 17:33:42 +02:00
ksysfs.c
kthread.c	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-08-13 11:25:07 -07:00
latencytop.c
Makefile	kbuild: move bin2c back to scripts/ from scripts/basic/	2018-07-18 01:18:05 +09:00
memremap.c	mm: fix exports that inadvertently make put_page() EXPORT_SYMBOL_GPL	2018-07-26 19:38:03 -07:00
module-internal.h
module.c	module: replace the existing LSM hook in init_module	2018-07-16 12:31:57 -07:00
module_signing.c
notifier.c
nsproxy.c
padata.c
panic.c	Kbuild: rename CC_STACKPROTECTOR[_STRONG] config variables	2018-06-14 12:21:18 +09:00
params.c
pid.c
pid_namespace.c
profile.c
ptrace.c
range.c
reboot.c	PM / reboot: Eliminate race between reboot and suspend	2018-08-06 12:35:20 +02:00
relay.c	kernel/relay.c: change return type to vm_fault_t	2018-06-15 07:55:24 +09:00
resource.c	libnvdimm for 4.18	2018-06-08 17:21:52 -07:00
rseq.c	rseq: uapi: Declare rseq_cs field as union, update includes	2018-07-10 22:18:52 +02:00
seccomp.c	audit/stable-4.18 PR 20180605	2018-06-06 16:34:00 -07:00
signal.c	signal: Remove no longer required irqsave/restore	2018-06-10 06:14:01 +02:00
smp.c	cpu/hotplug: Fix SMT supported evaluation	2018-08-07 12:25:30 +02:00
smpboot.c	smpboot: Remove cpumask from the API	2018-07-03 09:20:44 +02:00
smpboot.h
softirq.c	nohz: Fix missing tick reprogram when interrupting an inline softirq	2018-08-03 15:52:10 +02:00
stacktrace.c
stop_machine.c	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-08-13 11:25:07 -07:00
sys.c	sysinfo: Remove get_monotonic_boottime()	2018-06-19 09:56:27 +02:00
sys_ni.c	Merge branch 'core-rseq-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-06-10 10:17:09 -07:00
sysctl.c	sched/sysctl: Remove unused sched_time_avg_ms sysctl	2018-07-16 00:16:29 +02:00
sysctl_binary.c
task_work.c
taskstats.c
test_kprobes.c	kprobes: Remove jprobe API implementation	2018-06-21 12:33:05 +02:00
torture.c	torture: Keep old-school dmesg format	2018-06-25 11:30:10 -07:00
tracepoint.c	tracepoints: Fix the descriptions of tracepoint_probe_register{_prio}	2018-05-28 12:49:51 -04:00
tsacct.c
ucount.c
uid16.c
uid16.h
umh.c	umh: fix race condition	2018-06-07 16:56:28 -04:00
up.c
user-return-notifier.c
user.c
user_namespace.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
utsname.c
utsname_sysctl.c
watchdog.c	watchdog/softlockup: Fix cpu_stop_queue_work() double-queue bug	2018-07-15 23:51:19 +02:00
watchdog_hld.c	watchdog: Reduce message verbosity	2018-08-03 12:19:08 +02:00
workqueue.c	treewide: kzalloc() -> kcalloc()	2018-06-12 16:19:22 -07:00
workqueue_internal.h	workqueue: Set worker->desc to workqueue name by default	2018-05-18 08:47:13 -07:00