Matt Helsley
5a7aadfe2f
Freezer: Fix buggy resume test for tasks frozen with cgroup freezer ...
When the cgroup freezer is used to freeze tasks we do not want to thaw
those tasks during resume. Currently we test the cgroup freezer
state of the resuming tasks to see if the cgroup is FROZEN. If so
then we don't thaw the task. However, the FREEZING state also indicates
that the task should remain frozen.
This also avoids a problem pointed out by Oren Ladaan: the freezer state
transition from FREEZING to FROZEN is updated lazily when userspace reads
or writes the freezer.state file in the cgroup filesystem. This means that
resume will thaw tasks in cgroups which should be in the FROZEN state if
there is no read/write of the freezer.state file to trigger this
transition before suspend.
NOTE: Another "simple" solution would be to always update the cgroup
freezer state during resume. However it's a bad choice for several reasons:
Updating the cgroup freezer state is somewhat expensive because it requires
walking all the tasks in the cgroup and checking if they are each frozen.
Worse, this could easily make resume run in N^2 time where N is the number
of tasks in the cgroup. Finally, updating the freezer state from this code
path requires trickier locking because of the way locks must be ordered.
Instead of updating the freezer state we rely on the fact that lazy
updates only manage the transition from FREEZING to FROZEN. We know that
a cgroup with the FREEZING state may actually be FROZEN so test for that
state too. This makes sense in the resume path even for partially-frozen
cgroups -- those that really are FREEZING but not FROZEN.
Reported-by: Oren Ladaan <orenl@cs.columbia.edu>
Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
Cc: stable@kernel.org
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
2010-03-26 23:51:44 +01:00
microblaze: Enable GCOV_PROFILE_ALL
2009-09-21 14:29:21 +02:00
Merge branch 'for-next' into for-linus
2010-03-08 16:55:37 +01:00
Freezer: Fix buggy resume test for tasks frozen with cgroup freezer
2010-03-26 23:51:44 +01:00
timekeeping: Prevent oops when GENERIC_TIME=n
2010-03-02 09:22:25 +01:00
Merge branch 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-03-18 16:52:46 -07:00
copy_signal() cleanup: kill taskstats_tgid_init() and acct_init_pacct()
2010-03-12 15:52:39 -08:00
Fix misspelling of "should" and "shouldn't" in comments.
2010-02-05 12:22:30 +01:00
new helper: iterate_mounts()
2010-03-03 14:07:57 -05:00
Audit: reorganize struct audit_watch to save 8 bytes
2009-09-24 03:50:25 -04:00
Lose the first argument of audit_inode_child()
2010-02-08 14:38:36 -05:00
kbuild: move bounds.h to include/generated
2009-12-12 13:08:14 +01:00
capabilities: Use RCU to protect task lookup in sys_capget
2009-12-10 09:42:48 +11:00
cgroups: remove duplicate include
2010-03-24 16:31:19 -07:00
Freezer: Fix buggy resume test for tasks frozen with cgroup freezer
2010-03-26 23:51:44 +01:00
kernel/cpu.c: delete deprecated definition in cpu_up()
2010-03-06 11:26:28 -08:00
cpuset: alloc nodemask_t on the heap rather than the stack
2010-03-24 16:31:21 -07:00
kernel/cred.c: use kmem_cache_free
2010-02-03 10:21:57 +11:00
headers: taskstats_kern.h trim
2009-09-18 09:48:52 -07:00
early_res: Need to save the allocation name in drop_range_partial()
2010-03-01 23:23:02 -08:00
elf coredump: add extended numbering support
2010-03-06 11:26:46 -08:00
Merge branch 'core-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-03-13 14:43:01 -08:00
Merge branch 'core-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-03-13 14:43:01 -08:00
sched: fix nr_uninterruptible accounting of frozen tasks really
2009-07-18 14:19:53 +02:00
futex: Handle futex value corruption gracefully
2010-02-03 15:13:22 +01:00
futex: Protect pid lookup in compat code with RCU
2009-12-09 14:22:14 +01:00
hrtimers: Convert to raw_spinlocks
2009-12-14 23:55:34 +01:00
softlockup: Fix hung_task_check_count sysctl
2009-11-27 06:21:57 +01:00
Merge branch 'perf/core' into perf/urgent
2010-03-04 11:47:52 +01:00
itimers: Fix racy writes to cpu_itimer fields
2009-11-18 16:32:12 +01:00
hw-breakpoints: Fix broken hw-breakpoint sample module
2009-11-10 11:23:29 +01:00
mutex: Better control mutex adaptive spinning config
2009-12-03 11:50:11 +01:00
percpu: add __percpu sparse annotations to core kernel subsystems
2010-02-17 11:17:38 +09:00
kfifo: Don't use integer as NULL pointer
2010-02-16 15:11:08 -08:00
Merge branch 'core-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-02-04 16:07:41 -08:00
kmod: fix resource leak in call_usermodehelper_pipe()
2010-01-11 09:34:04 -08:00
kprobes: Calculate the index correctly when freeing the out-of-line execution slot
2010-03-11 14:06:16 +01:00
Merge branch 'for-next' into for-linus
2010-03-08 16:55:37 +01:00
cpuset: fix the problem that cpuset_mem_spread_node() returns an offline node
2010-03-24 16:31:21 -07:00
Merge branch 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-03-18 16:52:46 -07:00
lockdep: BFS cleanup
2009-07-24 10:53:29 +02:00
seq_file: constify seq_operations
2009-09-23 07:39:29 -07:00
elf coredump: replace ELF_CORE_EXTRA_* macros by functions
2010-03-06 11:26:45 -08:00
sysfs: Use sysfs_attr_init and sysfs_bin_attr_init on module dynamic attributes
2010-03-07 17:04:51 -08:00
headers: remove sched.h from interrupt.h
2009-10-11 11:20:58 -07:00
locking: Implement new raw_spinlock
2009-12-14 23:55:32 +01:00
mutex: Better control mutex adaptive spinning config
2009-12-03 11:50:11 +01:00
sched: Use lockdep-based checking on rcu_dereference()
2010-02-25 10:34:26 +01:00
cgroups: let ss->can_attach and ss->attach do whole threadgroups at a time
2009-09-24 07:20:58 -07:00
nsproxy: remove INIT_NSPROXY()
2010-03-12 15:52:40 -08:00
padata: Allocate the cpumask for the padata instance
2010-03-04 13:30:22 +08:00
panic: fix panic_timeout accuracy when running on a hypervisor
2010-03-06 11:26:33 -08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2010-03-12 16:04:50 -08:00
perf: Fix unexported generic perf_arch_fetch_caller_regs
2010-03-17 12:26:49 +01:00
Merge branch 'core-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-03-13 14:43:01 -08:00
pid_ns: zap_pid_ns_processes: use SEND_SIG_NOINFO instead of force_sig()
2010-03-12 15:52:40 -08:00
pm_qos: clean up racy global "name" variable
2009-10-14 15:31:10 +02:00
kernel core: use helpers for rlimits
2010-03-06 11:26:33 -08:00
posix-timers.c: Don't export local functions
2010-02-05 14:54:10 +01:00
printk: avoid warning when CONFIG_PRINTK is disabled
2010-03-06 11:26:33 -08:00
kernel/profile.c: Switch /proc/irq/prof_cpu_mask to seq_file
2009-09-20 20:15:40 +02:00
ptrace: Fix ptrace_regset() comments and diagnose errors specifically
2010-02-23 13:45:26 -08:00
x86: Change range end to start+size
2010-02-10 17:47:17 -08:00
rcu: Export rcu_scheduler_active
2010-02-26 08:20:46 +01:00
rcu: Eliminate unneeded function wrapping
2009-11-22 18:58:16 +01:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu
2010-03-03 07:34:18 -08:00
rcu: Fix accelerated grace periods for last non-dynticked CPU
2010-02-27 09:53:52 +01:00
rcu: Increase RCU CPU stall timeouts if PROVE_RCU
2010-03-11 13:38:01 +01:00
rcu: Fix holdoff for accelerated GPs for last non-dynticked CPU
2010-02-28 09:17:42 +01:00
rcu: Stop overflowing signed integers
2010-02-25 10:34:57 +01:00
splice: comparing unsigned int < 0
2010-03-06 11:26:32 -08:00
memcg: some modification to softlimit under hierarchical memory reclaim.
2009-10-01 16:11:13 -07:00
Merge branch 'x86-mm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-03-03 09:11:02 -08:00
sched: Convert pi_lock to raw_spinlock
2009-12-14 23:55:33 +01:00
rtmutes: Convert rtmutex.lock to raw_spinlock
2009-12-14 23:55:33 +01:00
Merge branch 'sched-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-03-13 14:46:18 -08:00
sched: Fix cpu_clock() in NMIs, on !CONFIG_HAVE_UNSTABLE_SCHED_CLOCK
2009-12-15 09:04:36 +01:00
Merge branch 'for-next' into for-linus
2010-03-08 16:55:37 +01:00
sched: Convert cpupri lock to raw_spinlock
2009-12-14 23:55:33 +01:00
sched: Convert rq->lock to raw_spinlock
2009-12-14 23:55:33 +01:00
sched, rcu: Fix rcu_dereference() for RCU-lockdep
2010-03-01 09:29:58 +01:00
sched: Discard some old bits
2009-12-09 10:03:07 +01:00
sched: Remove the sched_class load_balance methods
2010-01-21 13:40:09 +01:00
Merge branch 'sched-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
2010-03-13 14:46:18 -08:00
kernel core: use helpers for rlimits
2010-03-06 11:26:33 -08:00
SLOW_WORK: Move slow_work's proc file to debugfs
2009-12-01 08:20:31 -08:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/sysctl-2.6
2009-12-08 07:38:50 -08:00
SLOW_WORK: Move slow_work's proc file to debugfs
2009-12-01 08:20:31 -08:00
generic-ipi: Optimize accesses by using DEFINE_PER_CPU_SHARED_ALIGNED for IPI data
2010-01-18 09:02:59 +01:00
hrtimer, softirq: Fix hrtimer->softirq trampoline
2010-02-03 18:17:40 +01:00
softlockup: Add sched_clock_tick() to avoid kernel warning on kgdb resume
2010-02-01 08:22:32 +01:00
locking: Cleanup the name space completely
2009-12-14 23:55:33 +01:00
rcu: Introduce lockdep-based checking to RCU read-side primitives
2010-02-25 09:40:59 +01:00
percpu: add __percpu sparse annotations to core kernel subsystems
2010-02-17 11:17:38 +09:00
Add generic sys_olduname()
2010-03-12 15:52:32 -08:00
Add generic sys_ipc wrapper
2010-03-12 15:52:32 -08:00
sysctl extern cleanup: lockdep
2010-03-12 15:53:10 -08:00
Switch may_open() and break_lease() to passing O_...
2010-03-03 13:00:21 -05:00
ipv4 05/05: add sysctl to accept packets with local source addresses
2009-12-03 12:14:38 -08:00
const: struct nla_policy
2010-02-18 14:30:18 -08:00
Revert "time: Remove xtime_cache"
2009-12-22 14:10:37 -08:00
perf: Fix perf_event_do_pending() fallback callsite
2010-01-21 13:40:39 +01:00
trivial: fix typo "to to" in multiple files
2009-09-21 15:14:55 +02:00
mm: clean up mm_counter
2010-03-06 11:26:23 -08:00
headers: utsname.h redux
2009-09-23 18:13:10 -07:00
core: Clean up user return notifers use of per_cpu
2009-12-02 10:22:59 +01:00
sched: Remove USER_SCHED
2010-01-21 13:40:18 +01:00
sysctl kernel: Remove binary sysctl logic
2009-11-12 02:04:55 -08:00
locking, sched: Give waitqueue spinlocks their own lockdep classes
2009-08-10 14:43:09 +02:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq
2009-12-10 09:35:44 -08:00
5a7aadfe2f