android_kernel_motorola_sm6375/drivers/firewire
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Stefan Richter 5ae73518cb firewire: core: fix Model_ID in modalias
The modalias string of devices that represent units on a FireWire node
did not show Module_ID entries within unit directories.  This was
because firewire-core searched only the root directory of the
configuration ROM for a Model_ID entry.

We now search first the root directory, then the unit directory.  IOW
honor a unit directory's Model_ID if present, otherwise fall back to the
root directory's model ID (if present).

Furthermore, apply the same change to Vendor_ID.  This had the same
issue but it was less apparent because most devices provide Vendor_ID
only in the root directory.

And finally, also use this strategy for the remaining two IDs in the
modalias, Specifier_ID and Version.  It does not actually make sense to
look for them elsewhere than in the unit directory because they are
mandatory there.  However, a uniform search order simplifies the
implementation and has no adverse affect in practice.

Side notes:
  - The older counterpart of this, nodemgr.c of ieee1394, looked for
    Vendor_ID first in the root directory, then in the unit directory,
    and for Model_ID only in the unit directory.
  - There is a single mainline driver which requires Vendor_ID and
    Model_ID --- the firedtv driver.  This one worked because FireDTVs
    provide Vendor_ID in the root directory and Model_ID identically in
    root directory and unit directory.
  - Apart from firedtv, there are currently no drivers known to me
    (including userspace drivers) that look at the Vendor_ID or Model_ID
    of the modalias.

Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
2010-03-24 22:01:47 +01:00
..
core-card.c
core-cdev.c firewire: core: combine a bit of repeated code 2010-02-24 20:36:55 +01:00
core-device.c firewire: core: fix Model_ID in modalias 2010-03-24 22:01:47 +01:00
core-iso.c firewire: core: fw_iso_resource_manage: fix error handling 2010-03-15 14:29:44 +01:00
core-topology.c
core-transaction.c firewire: remove incomplete Bus_Time CSR support 2010-02-20 22:33:14 +01:00
core.h firewire: remove incomplete Bus_Time CSR support 2010-02-20 22:33:14 +01:00
Kconfig
Makefile
net.c
ohci.c firewire: ohci: add cycle timer quirk for the TI TSB12LV22 2010-03-17 23:24:42 +01:00
ohci.h
sbp2.c