Breno Leitao
5d7cea681d
net: netconsole: Disable target before netpoll cleanup ...
commit 97d9fba9a812cada5484667a46e14a4c976ca330 upstream.
Currently, netconsole cleans up the netpoll structure before disabling
the target. This approach can lead to race conditions, as message
senders (write_ext_msg() and write_msg()) check if the target is
enabled before using netpoll. The sender can validate that the target is
enabled, but, the netpoll might be de-allocated already, causing
undesired behaviours.
This patch reverses the order of operations:
1. Disable the target
2. Clean up the netpoll structure
This change eliminates the potential race condition, ensuring that
no messages are sent through a partially cleaned-up netpoll structure.
Fixes: 2382b15bccstable@vger.kernel.org
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20240712143415.1141039-1-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-08-19 05:33:35 +02:00
ACPI: processor_idle: Fix invalid comparison with insertion sort for latency
2024-07-27 10:38:32 +02:00
amba: bus: fix refcount leak
2023-09-23 10:59:52 +02:00
binder: fix max_thread type inconsistency
2024-06-16 13:28:48 +02:00
ata: libata-core: Fix double free on error
2024-07-05 09:08:31 +02:00
atm: idt77252: fix a memleak in open_card_ubr0
2024-02-23 08:25:06 +01:00
drivers: core: synchronize really_probe() and dev_uevent()
2024-07-05 09:08:18 +02:00
null_blk: Fix the WARNING: modpost: missing MODULE_DESCRIPTION()
2024-06-16 13:28:45 +02:00
Bluetooth: ath3k: Fix multiple issues reported by checkpatch.pl
2024-07-05 09:08:21 +02:00
bus: tegra-aconnect: Update dependency to ARCH_TEGRA
2024-03-26 18:22:15 -04:00
hpet: Support 32-bit userspace
2024-07-18 11:40:55 +02:00
clk: Don't hold prepare_lock when calling kref_put()
2024-05-17 11:43:53 +02:00
clocksource/drivers/timer-atmel-tcb: Fix initialization on SAM9 hardware
2023-11-28 16:50:13 +00:00
cpufreq: exit() callback is optional
2024-06-16 13:28:34 +02:00
crypto: qat - Fix ADF_DEV_RESET_SYNC memory leak
2024-06-16 13:28:51 +02:00
PM / devfreq: Fix leak in devfreq_dev_release()
2023-09-23 10:59:54 +02:00
dmaengine: ioatdma: Fix missing kmem_cache_destroy()
2024-07-05 09:08:23 +02:00
dma-buf/sw-sync: don't enable IRQ from sync_print_obj()
2024-06-16 13:28:47 +02:00
EDAC, i10nm: make skx_common.o a separate module
2024-08-19 05:33:25 +02:00
extcon: max8997: select IRQ_DOMAIN instead of depending on it
2024-06-16 13:28:43 +02:00
firewire: nosy: ensure user_length is taken into account when fetching packet contents
2024-05-17 11:43:54 +02:00
firmware: turris-mox-rwtm: Initialize completion before mailbox
2024-08-19 05:33:28 +02:00
fsi: master-ast-cf: Add MODULE_FIRMWARE macro
2023-09-23 10:59:37 +02:00
gpio: davinci: Validate the obtained number of IRQs
2024-07-05 09:08:28 +02:00
drm/qxl: Add check for drm_cvt_mode
2024-08-19 05:33:32 +02:00
greybus: Fix use-after-free bug in gb_interface_release due to race condition.
2024-07-05 09:08:20 +02:00
HID: logitech-dj: Fix memory leak in logi_dj_recv_switch_to_dj_mode()
2024-07-05 09:08:16 +02:00
hv_utils: drain the timesync packets on onchannelcallback
2024-07-05 09:08:20 +02:00
hwmon: (max6697) Fix swapped temp{1,8} critical alarms
2024-08-19 05:33:26 +02:00
intel_th: pci: Add Lunar Lake support
2024-07-05 09:08:19 +02:00
i2c: rcar: bring hardware to known state when probing
2024-07-18 11:40:56 +02:00
i3c: master: cdns: Update maximum prescaler value for i2c clock
2024-02-23 08:25:02 +01:00
iio: chemical: bme680: Fix sensor data read operation
2024-07-05 09:08:29 +02:00
bnxt_re: Fix imm_data endianness
2024-08-19 05:33:34 +02:00
Input: elan_i2c - do not leave interrupt disabled on suspend failure
2024-08-19 05:33:33 +02:00
interconnect: Treat xlate() returning NULL node as an error
2024-01-08 11:29:45 +01:00
iommu/amd: Fix sysfs leak in iommu init
2024-07-05 09:08:16 +02:00
irqchip/alpine-msi: Fix off-by-one in allocation error path
2024-06-16 13:28:34 +02:00
mISDN: Update parameter type of dsp_cmx_send()
2023-08-16 18:19:23 +02:00
leds: trigger: Unregister sysfs attributes before calling deactivate()
2024-08-19 05:33:31 +02:00
macintosh/therm_windtunnel: fix module unload.
2024-08-19 05:33:34 +02:00
mailbox: ti-msgmgr: Fill non-message tx data fields with 0x0
2023-07-27 08:37:23 +02:00
mcb: fix error handling for different scenarios when parsing
2023-11-28 16:50:19 +00:00
md/raid5: fix deadlock that raid5d() wait for itself to clear MD_SB_CHANGE_PENDING
2024-06-16 13:28:50 +02:00
media: renesas: vsp1: Store RPF partition configuration per RPF instance
2024-08-19 05:33:31 +02:00
memory: brcmstb_dpfe: fix testing array offset after use
2023-07-27 08:37:14 +02:00
memstick r592: make memstick_debug_get_tpc_name() static
2023-07-27 08:37:10 +02:00
mfd: omap-usb-tll: Use struct_size to allocate tll
2024-08-19 05:33:32 +02:00
mei: demote client disconnect warning on suspend to debug
2024-07-27 10:38:29 +02:00
mmc: sdhci: Do not lock spinlock around mmc_gpio_get_ro()
2024-07-05 09:08:29 +02:00
mtd: make mtd_test.c a separate module
2024-08-19 05:33:33 +02:00
net: netconsole: Disable target before netpoll cleanup
2024-08-19 05:33:35 +02:00
NFC: trf7970a: disable all regulators on removal
2024-05-02 16:18:33 +02:00
ntb: Fix calculation ntb_transport_tx_free_entry()
2023-09-23 10:59:55 +02:00
nd_btt: Make BTT lanes preemptible
2023-11-20 10:30:12 +01:00
nvme-multipath: find NUMA path only for online numa-node
2024-07-18 11:40:52 +02:00
nvmem: meson-efuse: Fix return value of nvmem callbacks
2024-07-18 11:40:55 +02:00
of: gpio unittest kfree() wrong object
2024-02-23 08:25:15 +01:00
OPP: Fix passing 0 to PTR_ERR in _opp_attach_genpd()
2023-09-23 10:59:40 +02:00
parisc: iosapic.c: Fix sparse warnings
2023-10-10 21:46:39 +02:00
parport: parport_serial: Add Brainboxes device IDs and geometry
2024-01-25 14:34:21 -08:00
PCI: Fix resource double counting on remove & rescan
2024-08-19 05:33:32 +02:00
pcmcia: ds: fix possible name leak in error path in pcmcia_device_add()
2023-11-20 10:30:14 +01:00
perf/smmuv3: Enable HiSilicon Erratum 162001900 quirk for HIP08/09
2023-09-23 11:00:03 +02:00
phy: ti: phy-omap-usb2: Fix NULL pointer dereference for SRP
2024-02-23 08:25:06 +01:00
pinctrl: freescale: mxs: Fix refcount of child
2024-08-19 05:33:34 +02:00
platform/chrome: cros_ec_debugfs: fix wrong EC message version
2024-08-19 05:33:25 +02:00
PNP: ACPI: fix fortify warning
2024-02-23 08:24:54 +01:00
power: rt9455: hide unused rt9455_boost_voltage_values
2024-05-17 11:43:48 +02:00
powercap: RAPL: Fix CONFIG_IOSF_MBI dependency
2023-07-27 08:37:06 +02:00
ptp: Fix error message on failed pin verification
2024-07-05 09:08:11 +02:00
pwm: stm32: Always do lazy disabling
2024-08-19 05:33:26 +02:00
regulator: core: Fix modpost error "regulator_get_regmap" undefined
2024-07-05 09:08:23 +02:00
reset: hisilicon: hi6220: fix Wvoid-pointer-to-enum-cast warning
2024-01-25 14:34:20 -08:00
rpmsg: virtio: Free driver_override when rpmsg_remove()
2024-02-23 08:24:48 +01:00
rtc: interface: Add RTC offset to alarm after fix-up
2024-08-19 05:33:35 +02:00
s390/sclp: Fix sclp_init() cleanup on failure
2024-07-27 10:38:31 +02:00
scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed
2024-07-27 10:38:31 +02:00
slimbus: core: Remove usage of the deprecated ida_simple_xx() API
2024-04-13 12:51:26 +02:00
soc: ti: wkup_m3_ipc: Send NULL dummy message instead of pointer message
2024-07-05 09:08:28 +02:00
soundwire: cadence: fix invalid PDI offset
2024-06-16 13:28:41 +02:00
spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices
2024-07-27 10:38:32 +02:00
wifi: wilc1000: fix ies_len type in connect path
2024-07-18 11:40:50 +02:00
scsi: target: Fix SELinux error when systemd-modules loads the target module
2024-05-17 11:43:51 +02:00
thermal: core: prevent potential string overflow
2023-11-20 10:30:09 +01:00
tty: mcf: MCF54418 has 10 UARTS
2024-07-05 09:08:30 +02:00
uio: Fix use-after-free in uio_open
2024-01-25 14:34:21 -08:00
USB: move snd_usb_pipe_sanity_check into the USB core
2024-08-19 05:33:30 +02:00
vfio/platform: Create persistent IRQ handlers
2024-04-13 12:51:34 +02:00
vhost: Add smp_rmb() in vhost_vq_avail_empty()
2024-05-02 16:18:29 +02:00
fbdev: savage: Handle err return when savagefb_check_var failed
2024-06-16 13:28:50 +02:00
virtio: delete vq in vp_find_vqs_msix() when request_irq() fails
2024-06-16 13:28:46 +02:00
w1: fix loop in w1_fini()
2023-07-27 08:37:19 +02:00
watchdog: stm32_iwdg: initialize default timeout
2024-03-26 18:22:24 -04:00
xen/events: close evtchn after mapping cleanup
2024-04-13 12:51:29 +02:00
5d7cea681d