Julia Lawall
5daf47bb4e
net/rds: Add missing mutex_unlock
...
Add a mutex_unlock missing on the error path. In each case, whenever the
label out is reached from elsewhere in the function, mutex is not locked.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/ )
// <smpl>
@@
expression E1;
@@
* mutex_lock(E1);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
* mutex_unlock(E1);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Zach Brown <zach.brown@oracle.com>
Acked-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-05-29 00:18:48 -07:00
..
9p
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
802
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
8021q
net: Remove unnecessary semicolons after switch statements
2010-05-17 17:44:35 -07:00
appletalk
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
atm
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
ax25
net: sk_sleep() helper
2010-04-20 16:37:13 -07:00
bluetooth
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
bridge
bridge: fix build for CONFIG_SYSFS disabled
2010-05-18 12:26:27 -07:00
caif
caif: Bugfix - use MSG_TRUNC in receive
2010-05-23 23:57:43 -07:00
can
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
core
skb: make skb_recycle_check() return a bool value
2010-05-29 00:12:13 -07:00
dcb
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
dccp
net/dccp: expansion of error code size
2010-05-24 18:37:02 -07:00
decnet
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
dsa
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
econet
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
ethernet
net: Inline skb_pull() in eth_type_trans().
2010-05-02 02:21:44 -07:00
ieee802154
ieee802154: Fix possible NULL pointer dereference in wpan_phy_alloc
2010-05-23 23:11:07 -07:00
ipv4
net: fix lock_sock_bh/unlock_sock_bh
2010-05-27 00:30:53 -07:00
ipv6
IPv6: fix Mobile IPv6 regression
2010-05-28 23:02:35 -07:00
ipx
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
irda
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
iucv
net/iucv: Add missing spin_unlock
2010-05-26 21:09:51 -07:00
key
pfkey: add severity to printk
2010-05-17 23:23:13 -07:00
l2tp
l2tp_eth: fix memory allocation
2010-04-23 16:37:33 -07:00
lapb
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
llc
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-05-12 00:05:35 -07:00
mac80211
mac80211: make a function static
2010-05-28 13:41:27 -04:00
netfilter
xt_tee: use skb_dst_drop()
2010-05-28 03:41:17 -07:00
netlabel
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
netlink
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
netrom
net: sk_sleep() helper
2010-04-20 16:37:13 -07:00
packet
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-21 01:14:25 -07:00
phonet
Phonet: fix potential use-after-free in pep_sock_close()
2010-05-25 16:08:39 -07:00
rds
net/rds: Add missing mutex_unlock
2010-05-29 00:18:48 -07:00
rfkill
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
rose
net: sk_sleep() helper
2010-04-20 16:37:13 -07:00
rxrpc
net: sock_def_readable() and friends RCU conversion
2010-05-01 15:00:15 -07:00
sched
cls_cgroup: Store classid in struct sock
2010-05-24 00:12:34 -07:00
sctp
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
sunrpc
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6
2010-05-20 21:04:44 -07:00
tipc
tipc: Reduce footprint by un-inlining tipc_msg_* routines
2010-05-12 23:02:29 -07:00
unix
unix/garbage: kill copy of the skb queue walker
2010-05-03 15:39:58 -07:00
wanrouter
wimax
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6
2010-05-20 21:04:44 -07:00
wireless
cfg80211: add missing braces
2010-05-21 14:40:01 -04:00
x25
X25: Remove bkl in sockopts
2010-05-17 17:39:28 -07:00
xfrm
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
compat.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
Kconfig
l2tp: Split pppol2tp patch into separate l2tp and ppp parts
2010-04-03 14:56:02 -07:00
Makefile
l2tp: Split pppol2tp patch into separate l2tp and ppp parts
2010-04-03 14:56:02 -07:00
nonet.c
socket.c
cls_cgroup: Store classid in struct sock
2010-05-24 00:12:34 -07:00
sysctl_net.c
net: Remove unnecessary returns from void function()s
2010-05-17 23:23:14 -07:00
TUNABLE