Jason A. Donenfeld
4e4e4524fc
UPSTREAM: wireguard: send: annotate intentional data race in checking empty queue
KCSAN reports a race in wg_packet_send_keepalive, which is intentional:
BUG: KCSAN: data-race in wg_packet_send_keepalive / wg_packet_send_staged_packets
write to 0xffff88814cd91280 of 8 bytes by task 3194 on cpu 0:
__skb_queue_head_init include/linux/skbuff.h:2162 [inline]
skb_queue_splice_init include/linux/skbuff.h:2248 [inline]
wg_packet_send_staged_packets+0xe5/0xad0 drivers/net/wireguard/send.c:351
wg_xmit+0x5b8/0x660 drivers/net/wireguard/device.c:218
__netdev_start_xmit include/linux/netdevice.h:4940 [inline]
netdev_start_xmit include/linux/netdevice.h:4954 [inline]
xmit_one net/core/dev.c:3548 [inline]
dev_hard_start_xmit+0x11b/0x3f0 net/core/dev.c:3564
__dev_queue_xmit+0xeff/0x1d80 net/core/dev.c:4349
dev_queue_xmit include/linux/netdevice.h:3134 [inline]
neigh_connected_output+0x231/0x2a0 net/core/neighbour.c:1592
neigh_output include/net/neighbour.h:542 [inline]
ip6_finish_output2+0xa66/0xce0 net/ipv6/ip6_output.c:137
ip6_finish_output+0x1a5/0x490 net/ipv6/ip6_output.c:222
NF_HOOK_COND include/linux/netfilter.h:303 [inline]
ip6_output+0xeb/0x220 net/ipv6/ip6_output.c:243
dst_output include/net/dst.h:451 [inline]
NF_HOOK include/linux/netfilter.h:314 [inline]
ndisc_send_skb+0x4a2/0x670 net/ipv6/ndisc.c:509
ndisc_send_rs+0x3ab/0x3e0 net/ipv6/ndisc.c:719
addrconf_dad_completed+0x640/0x8e0 net/ipv6/addrconf.c:4295
addrconf_dad_work+0x891/0xbc0
process_one_work kernel/workqueue.c:2633 [inline]
process_scheduled_works+0x5b8/0xa30 kernel/workqueue.c:2706
worker_thread+0x525/0x730 kernel/workqueue.c:2787
kthread+0x1d7/0x210 kernel/kthread.c:388
ret_from_fork+0x48/0x60 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:242
read to 0xffff88814cd91280 of 8 bytes by task 3202 on cpu 1:
skb_queue_empty include/linux/skbuff.h:1798 [inline]
wg_packet_send_keepalive+0x20/0x100 drivers/net/wireguard/send.c:225
wg_receive_handshake_packet drivers/net/wireguard/receive.c:186 [inline]
wg_packet_handshake_receive_worker+0x445/0x5e0 drivers/net/wireguard/receive.c:213
process_one_work kernel/workqueue.c:2633 [inline]
process_scheduled_works+0x5b8/0xa30 kernel/workqueue.c:2706
worker_thread+0x525/0x730 kernel/workqueue.c:2787
kthread+0x1d7/0x210 kernel/kthread.c:388
ret_from_fork+0x48/0x60 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:242
value changed: 0xffff888148fef200 -> 0xffff88814cd91280
Mark this race as intentional by using the skb_queue_empty_lockless()
function rather than skb_queue_empty(), which uses READ_ONCE()
internally to annotate the race.
Bug: 254441685
Cc: stable@vger.kernel.org
Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Link: https://patch.msgid.link/20240704154517.1572127-5-Jason@zx2c4.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit 381a7d453fa2ac5f854a154d3c9b1bbb90c4f94f)
Signed-off-by: Lee Jones <joneslee@google.com>
Change-Id: I2c7bfa280efeb3dbbc6ba5559a22a1d019edb489
|
2025-09-24 12:16:42 +02:00 |
| .. |
|
accessibility
|
|
|
|
acpi
|
This is the 5.4.296 stable release
|
2025-07-18 10:57:54 +00:00 |
|
amba
|
|
|
|
android
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
ata
|
ata: pata_cs5536: fix build on 32-bit UML
|
2025-07-17 18:24:57 +02:00 |
|
atm
|
atm: idt77252: Add missing dma_map_error()
|
2025-07-17 18:25:05 +02:00 |
|
auxdisplay
|
|
|
|
base
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
bcma
|
|
|
|
block
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
bluetooth
|
Merge tag 'ASB-2025-06-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-06-30 10:49:17 +03:00 |
|
bus
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
cdrom
|
|
|
|
char
|
Merge tag 'ASB-2025-06-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-06-30 10:49:17 +03:00 |
|
clk
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
clocksource
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
connector
|
|
|
|
counter
|
|
|
|
cpufreq
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
cpuidle
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
crypto
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
dax
|
|
|
|
dca
|
|
|
|
devfreq
|
|
|
|
dio
|
|
|
|
dma
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
dma-buf
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
edac
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
eisa
|
|
|
|
extcon
|
|
|
|
firewire
|
|
|
|
firmware
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
fpga
|
fpga: altera-cvp: Increase credit timeout
|
2025-06-04 14:32:32 +02:00 |
|
fsi
|
|
|
|
gnss
|
|
|
|
gpio
|
gpio: zynq: Fix wakeup source leaks on device unbind
|
2025-05-02 07:39:17 +02:00 |
|
gpu
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
greybus
|
|
|
|
hid
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
hsi
|
HSI: ssi_protocol: Fix use after free vulnerability in ssi_protocol Driver Due to Race Condition
|
2025-05-02 07:39:18 +02:00 |
|
hv
|
|
|
|
hwmon
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
hwspinlock
|
|
|
|
hwtracing
|
Merge tag 'ASB-2025-05-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-05-18 08:00:20 +00:00 |
|
i2c
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
i3c
|
Merge tag 'ASB-2025-06-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-06-30 10:49:17 +03:00 |
|
ide
|
|
|
|
idle
|
|
|
|
iio
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
infiniband
|
This is the 5.4.296 stable release
|
2025-07-18 10:57:54 +00:00 |
|
input
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
interconnect
|
|
|
|
iommu
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
ipack
|
|
|
|
irqchip
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
isdn
|
|
|
|
leds
|
Merge tag 'ASB-2025-05-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-05-18 08:00:20 +00:00 |
|
lightnvm
|
|
|
|
macintosh
|
|
|
|
mailbox
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
mcb
|
mcb: fix a double free bug in chameleon_parse_gdd()
|
2025-05-02 07:39:26 +02:00 |
|
md
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
media
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
memory
|
|
|
|
memstick
|
|
|
|
message
|
|
|
|
mfd
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
misc
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
mmc
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
mtd
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
mux
|
|
|
|
net
|
UPSTREAM: wireguard: send: annotate intentional data race in checking empty queue
|
2025-09-24 12:16:42 +02:00 |
|
nfc
|
|
|
|
ntb
|
ntb: reduce stack usage in idt_scan_mws
|
2025-05-02 07:39:28 +02:00 |
|
nubus
|
|
|
|
nvdimm
|
libnvdimm/labels: Fix divide error in nd_label_data_init()
|
2025-06-04 14:32:30 +02:00 |
|
nvme
|
nvmet-tcp: don't restore null sk_state_change
|
2025-06-04 14:32:35 +02:00 |
|
nvmem
|
Merge tag 'ASB-2025-05-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-05-18 08:00:20 +00:00 |
|
of
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
opp
|
|
|
|
oprofile
|
|
|
|
parisc
|
|
|
|
parport
|
|
|
|
pci
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
pcmcia
|
|
|
|
perf
|
Merge tag 'ASB-2025-06-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-06-30 10:49:17 +03:00 |
|
phy
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
pinctrl
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
platform
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
pnp
|
|
|
|
power
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
powercap
|
|
|
|
pps
|
|
|
|
ps3
|
|
|
|
ptp
|
|
|
|
pwm
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
rapidio
|
drivers/rapidio/rio_cm.c: prevent possible heap overwrite
|
2025-06-27 11:02:56 +01:00 |
|
ras
|
|
|
|
regulator
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
remoteproc
|
|
|
|
reset
|
|
|
|
rpmsg
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
rtc
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
s390
|
scsi: s390: zfcp: Ensure synchronous unit_add
|
2025-06-27 11:02:56 +01:00 |
|
sbus
|
|
|
|
scsi
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
sfi
|
|
|
|
sh
|
|
|
|
siox
|
|
|
|
slimbus
|
Merge tag 'ASB-2025-05-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-05-18 08:00:20 +00:00 |
|
soc
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
soundwire
|
|
|
|
spi
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
spmi
|
|
|
|
ssb
|
|
|
|
staging
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
target
|
This is the 5.4.294 stable release
|
2025-06-05 07:11:21 +00:00 |
|
tc
|
|
|
|
tee
|
tee: Prevent size calculation wraparound on 32-bit kernels
|
2025-06-27 11:02:55 +01:00 |
|
thermal
|
Merge tag 'ASB-2025-06-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-06-30 10:49:17 +03:00 |
|
thunderbolt
|
thunderbolt: Do not double dequeue a configuration request
|
2025-06-27 11:02:44 +01:00 |
|
tty
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
uio
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
usb
|
Merge tag 'ASB-2025-09-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-12 18:48:05 +03:00 |
|
vfio
|
|
|
|
vhost
|
|
|
|
video
|
Merge tag 'ASB-2025-08-05_11-5.4' of https://android.googlesource.com/kernel/common into android13-5.4-lahaina
|
2025-09-01 13:17:46 +03:00 |
|
virt
|
|
|
|
virtio
|
|
|
|
visorbus
|
|
|
|
vlynq
|
|
|
|
vme
|
|
|
|
w1
|
|
|
|
watchdog
|
watchdog: da9052_wdt: respect TWDMIN
|
2025-06-27 11:02:55 +01:00 |
|
xen
|
xen/swiotlb: relax alignment requirements
|
2025-06-04 14:32:37 +02:00 |
|
zorro
|
|
|
|
Kconfig
|
|
|
|
Makefile
|
|
|
|
OWNERS
|
|
|