Filipe Manana
60d9f50308
Btrfs: fix fsync not persisting changed attributes of a directory ...
While logging an inode we follow its ancestors and for each one we mark
it as logged in the current transaction, even if we have not logged it.
As a consequence if we change an attribute of an ancestor, such as the
UID or GID for example, and then explicitly fsync it, we end up not
logging the inode at all despite returning success to user space, which
results in the attribute being lost if a power failure happens after
the fsync.
Sample reproducer:
$ mkfs.btrfs -f /dev/sdb
$ mount /dev/sdb /mnt
$ mkdir /mnt/dir
$ chown 6007:6007 /mnt/dir
$ sync
$ chown 9003:9003 /mnt/dir
$ touch /mnt/dir/file
$ xfs_io -c fsync /mnt/dir/file
# fsync our directory after fsync'ing the new file, should persist the
# new values for the uid and gid.
$ xfs_io -c fsync /mnt/dir
<power failure>
$ mount /dev/sdb /mnt
$ stat -c %u:%g /mnt/dir
6007:6007
--> should be 9003:9003, the uid and gid were not persisted, despite
the explicit fsync on the directory prior to the power failure
Fix this by not updating the logged_trans field of ancestor inodes when
logging an inode, since we have not logged them. Let only future calls to
btrfs_log_inode() to mark inodes as logged.
This could be triggered by my recent fsync fuzz tester for fstests, for
which an fstests patch exists titled "fstests: generic, fsync fuzz tester
with fsstress".
Fixes: 12fcfd22festable@vger.kernel.org # 4.4+
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2019-05-28 18:56:50 +02:00
Pull request for inlusion in 5.1
2019-03-17 09:10:56 -07:00
afs: Fix in-progess ops to ignore server-level callback invalidation
2019-04-13 08:37:37 +01:00
autofs: clear O_NONBLOCK on the pipe
2019-03-07 18:32:01 -08:00
bfs: extra sanity checking and static inode bitmap
2019-01-04 13:13:47 -08:00
Btrfs: fix fsync not persisting changed attributes of a directory
2019-05-28 18:56:50 +02:00
fscache, cachefiles: remove redundant variable 'cache'
2018-11-30 16:00:58 +00:00
ceph: fix ci->i_head_snapc leak
2019-04-23 21:37:54 +02:00
cifs: fix page reference leak with readv/writev
2019-04-24 12:33:59 -05:00
fscrypt updates for v5.1
2019-03-09 10:54:24 -08:00
debugfs: fix use-after-free on symlink traversal
2019-04-01 00:31:02 -04:00
fs/devpts: always delete dcache dentry-s in dput()
2019-01-24 13:38:30 -05:00
socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes
2019-02-03 11:17:31 -08:00
crypto: clarify name of WEAK_KEY request flag
2019-01-25 18:41:52 +08:00
\n
2019-03-07 09:01:33 -08:00
Miscellaneous ext4 bug fixes for 5.1.
2019-03-24 13:41:37 -07:00
f2fs-for-5.1-rc1
2019-03-15 13:42:53 -07:00
fat: enable .splice_write to support splice on O_DIRECT file
2019-03-07 18:32:01 -08:00
fscache: fix race between enablement and dropping of object
2018-11-30 15:57:31 +00:00
Merge branch 'page-refs' (page ref overflow)
2019-04-14 15:09:40 -07:00
We've only got three patches ready for this merge window:
2019-03-09 11:52:11 -08:00
hfs: do not free node before using
2018-11-30 14:56:14 -08:00
hfsplus: return file attributes on statx
2019-01-04 13:13:47 -08:00
hpfs: fix spelling mistake "partion" -> "partition"
2019-03-12 09:58:03 -07:00
hugetlbfs: fix memory leak for resv_map
2019-04-05 16:02:31 -10:00
jbd2: jbd2_get_transaction does not need to return a value
2019-03-01 00:36:57 -05:00
jffs2: fix use-after-free on symlink traversal
2019-04-01 00:31:02 -04:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-12 14:08:19 -07:00
NFS: fix mount/umount race in nlmclnt.
2019-03-18 22:39:34 -04:00
NFSv4.1 fix incorrect return value in copy_file_range
2019-04-11 15:23:48 -04:00
nfsd: wake blocked file lock waiters before sending callback
2019-04-22 15:38:41 -04:00
XArray: Change xa_insert to return -EBUSY
2019-02-06 13:12:15 -05:00
fanotify: Allow copying of file handle to userspace
2019-03-19 09:29:07 +01:00
mm: convert totalram_pages and totalhigh_pages variables to atomic
2018-12-28 12:11:47 -08:00
ocfs2: fix inode bh swapping mixup in ocfs2_reflink_inodes_lock
2019-03-29 10:01:37 -07:00
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-12 13:27:20 -07:00
ovl: Do not lose security.capability xattr over metadata file copy-up
2019-02-13 11:14:46 +01:00
fs/proc/proc_sysctl.c: Fix a NULL pointer dereference
2019-04-26 09:18:05 -07:00
pstore/ram: Avoid needless alloc during header write
2019-02-12 13:45:53 -08:00
quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls.
2018-12-18 18:29:15 +01:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-16 10:31:02 -07:00
ubifs: fix use-after-free on symlink traversal
2019-04-01 00:31:02 -04:00
udf: Propagate errors from udf_truncate_extents()
2019-03-18 16:30:02 +01:00
xfs: serialize unaligned dio writes against all other dio writes
2019-03-26 08:37:55 -07:00
aio: use kmem_cache_free() instead of kfree()
2019-04-04 20:13:59 -04:00
a.out: remove core dumping support
2019-03-05 10:00:35 -08:00
fs/binfmt_elf.c: spread const a little
2019-03-07 18:32:01 -08:00
exec: load_script: Do not exec truncated interpreter path
2019-02-18 16:49:36 -08:00
block: fix the return errno for direct IO
2019-04-11 21:22:21 -06:00
fs: fix guard_bio_eod to check for real EOD errors
2019-02-28 13:59:41 -07:00
fs/dax: Deposit pagetable even when installing zero page
2019-03-13 13:58:46 -07:00
fs/dcache: Track & report number of negative dentries
2019-01-30 11:02:11 -08:00
block: allow bio_for_each_segment_all() to iterate over multi-page bvec
2019-02-15 08:40:11 -07:00
fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()
2019-02-01 15:46:24 -08:00
epoll: use rwlock in order to reduce ep_poll_callback() contention
2019-03-07 18:32:01 -08:00
exec: increase BINPRM_BUF_SIZE to 256
2019-03-07 18:32:01 -08:00
io_uring-2019-03-06
2019-03-08 14:48:40 -08:00
fs: add fget_many() and fput_many()
2019-02-28 08:24:23 -07:00
vfs: Implement a filesystem superblock creation/configuration context
2019-02-28 03:29:26 -05:00
writeback: synchronize sync(2) against cgroup writeback membership switches
2019-01-22 14:39:38 -07:00
vfs: Implement logging through fs_context
2019-02-28 03:29:37 -05:00
fs: fs_parser: fix printk format warning
2019-03-29 10:01:38 -07:00
fs: common implementation of file type
2019-01-21 17:48:13 +01:00
fs/inode.c: inode_set_flags(): replace opencoded set_mask_bits()
2019-03-05 21:07:13 -08:00
vfs: Add configuration parser helpers
2019-02-28 03:28:53 -05:00
io_uring: remove 'state' argument from io_{read,write} path
2019-04-23 08:17:58 -06:00
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
block: add BIO_NO_PAGE_REF flag
2019-03-18 10:44:48 -06:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-12 14:08:19 -07:00
locks: wake any locks blocked on request before deadlock check
2019-03-25 08:36:24 -04:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-12 14:08:19 -07:00
saner handling of temporary namespaces
2019-01-30 17:44:07 -05:00
block: allow bio_for_each_segment_all() to iterate over multi-page bvec
2019-02-15 08:40:11 -07:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-12 14:08:19 -07:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-12 14:08:19 -07:00
fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock
2019-04-06 07:01:55 -10:00
Merge branch 'page-refs' (page ref overflow)
2019-04-14 15:09:40 -07:00
separate copying and locking mount tree on cross-userns copies
2019-01-30 17:14:50 -05:00
separate copying and locking mount tree on cross-userns copies
2019-01-30 17:14:50 -05:00
fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock
2019-04-06 07:01:55 -10:00
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
y2038: syscalls: rename y2038 compat syscalls
2019-02-07 00:13:27 +01:00
There tracing fixes:
2019-04-26 11:09:55 -07:00
fs: move generic stat response attr handling to vfs_getattr_nosec
2019-02-01 01:55:45 -05:00
vfs: add vfs_get_fsid() helper
2019-02-07 16:38:35 +01:00
vfs: Add some logging to the core users of the fs_context log
2019-02-28 03:29:38 -05:00
y2038: syscalls: rename y2038 compat syscalls
2019-02-07 00:13:27 +01:00
coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping
2019-04-19 09:46:05 -07:00
y2038: syscalls: rename y2038 compat syscalls
2019-02-07 00:13:27 +01:00
60d9f50308