Jin Yao
0a4c06f0db
perf report: Fix no branch type statistics report issue
...
commit c3b10649a80e9da2892c1fd3038c53abd57588f6 upstream.
Previously we could get the report of branch type statistics.
For example:
# perf record -j any,save_type ...
# t perf report --stdio
#
# Branch Statistics:
#
COND_FWD: 40.6%
COND_BWD: 4.1%
CROSS_4K: 24.7%
CROSS_2M: 12.3%
COND: 44.7%
UNCOND: 0.0%
IND: 6.1%
CALL: 24.5%
RET: 24.7%
But now for the recent perf, it can't report the branch type statistics.
It's a regression issue caused by commit 40c39e3046 ("perf report: Fix
a no annotate browser displayed issue"), which only counts the branch
type statistics for browser mode.
This patch moves the branch_type_count() outside of ui__has_annotation()
checking, then branch type statistics can work for stdio mode.
Fixes: 40c39e3046 ("perf report: Fix a no annotate browser displayed issue")
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20200313134607.12873-1-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-04-21 09:04:52 +02:00
..
arch
perf arm-spe: Fix endless record after being terminated
2020-03-12 13:00:22 +01:00
bench
perf bench futex-wake: Restore thread count default to online CPU count
2020-03-18 07:17:57 +01:00
Documentation
perf docs: Correct and clarify jitdump spec
2019-09-30 17:29:51 -03:00
examples /bpf
include /bpf
jvmti
perf jvmti: Link against tools/lib/ctype.h to have weak strlcpy()
2019-10-15 11:47:38 -03:00
lib
libperf: Add perf_evlist__poll() function
2019-09-25 09:51:49 -03:00
pmu-events
perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description
2020-01-17 19:48:30 +01:00
python
scripts
perf scripts python: exported-sql-viewer.py: Fix use of TRUE with SQLite
2019-12-13 08:42:16 +01:00
tests
perf tests: Disable bp_signal testing for arm64
2019-12-31 16:44:12 +01:00
trace
ui
perf ui gtk: Add missing zalloc object
2020-03-05 16:43:50 +01:00
util
perf map: Fix off by one in strncpy() size argument
2020-04-02 15:11:02 +02:00
.gitignore
Build
builtin-annotate.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-bench.c
builtin-buildid-cache.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-buildid-list.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-c2c.c
perf c2c: Fix return type for histogram sorting comparision functions
2020-02-05 21:22:40 +00:00
builtin-config.c
builtin-data.c
builtin-diff.c
perf diff: Use llabs() with 64-bit values
2020-01-04 19:18:26 +01:00
builtin-evlist.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
builtin-ftrace.c
builtin-help.c
builtin-inject.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-kallsyms.c
builtin-kmem.c
perf kmem: Fix memory leak in compact_gfp_flags()
2019-10-16 10:08:32 -03:00
builtin-kvm.c
perf tools: Propagate get_cpuid() error
2019-09-30 17:29:54 -03:00
builtin-list.c
perf list: Allow plurals for metric, metricgroup
2019-09-25 09:51:42 -03:00
builtin-lock.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-mem.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-probe.c
builtin-record.c
libperf: Add perf_evlist__poll() function
2019-09-25 09:51:49 -03:00
builtin-report.c
perf report: Fix no branch type statistics report issue
2020-04-21 09:04:52 +02:00
builtin-sched.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
builtin-script.c
perf script: Fix --reltime with --time
2020-01-23 08:23:01 +01:00
builtin-stat.c
libperf: Move 'sample_id' from 'struct evsel' to 'struct perf_evsel'
2019-09-25 09:51:47 -03:00
builtin-timechart.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-top.c
perf evsel: Move config terms to a separate header
2019-09-25 16:26:40 -03:00
builtin-trace.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
builtin-version.c
builtin.h
check-headers.sh
tools headers uapi: Sync linux/fs.h with the kernel sources
2019-09-30 17:29:22 -03:00
command-list.txt
CREDITS
design.txt
Makefile
tools: Let O= makes handle a relative path with -C option
2020-04-01 11:02:00 +02:00
Makefile.config
perf tools: Support Python 3.8+ in Makefile
2020-04-17 10:50:21 +02:00
Makefile.perf
libtraceevent: Move traceevent plugins in its own subdirectory
2019-09-25 09:51:43 -03:00
MANIFEST
perf-archive.sh
perf-completion.sh
perf-read-vdso.c
perf-sys.h
perf tools: Make usage of test_attr__* optional for perf-sys.h
2019-10-31 21:38:41 +01:00
perf-with-kcore.sh
perf.c
libperf: Merge libperf_set_print() into libperf_init()
2019-09-25 09:51:49 -03:00
perf.h