Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Maximilian Heyne ee4e9c1976 ext4: fix corruption during on-line resize ... [ Upstream commit a6b3bfe176e8a5b05ec4447404e412c2a3fc92cc ] We observed a corruption during on-line resize of a file system that is larger than 16 TiB with 4k block size. With having more then 2^32 blocks resize_inode is turned off by default by mke2fs. The issue can be reproduced on a smaller file system for convenience by explicitly turning off resize_inode. An on-line resize across an 8 GiB boundary (the size of a meta block group in this setup) then leads to a corruption: dev=/dev/<some_dev> # should be >= 16 GiB mkdir -p /corruption /sbin/mke2fs -t ext4 -b 4096 -O ^resize_inode $dev $((2 * 2**21 - 2**15)) mount -t ext4 $dev /corruption dd if=/dev/zero bs=4096 of=/corruption/test count=$((2*2**21 - 4*2**15)) sha1sum /corruption/test # 79d2658b39dcfd77274e435b0934028adafaab11 /corruption/test /sbin/resize2fs $dev $((2*2**21)) # drop page cache to force reload the block from disk echo 1 > /proc/sys/vm/drop_caches sha1sum /corruption/test # 3c2abc63cbf1a94c9e6977e0fbd72cd832c4d5c3 /corruption/test 2^21 = 2^15*2^6 equals 8 GiB whereof 2^15 is the number of blocks per block group and 2^6 are the number of block groups that make a meta block group. The last checksum might be different depending on how the file is laid out across the physical blocks. The actual corruption occurs at physical block 63*2^15 = 2064384 which would be the location of the backup of the meta block group's block descriptor. During the on-line resize the file system will be converted to meta_bg starting at s_first_meta_bg which is 2 in the example - meaning all block groups after 16 GiB. However, in ext4_flex_group_add we might add block groups that are not part of the first meta block group yet. In the reproducer we achieved this by substracting the size of a whole block group from the point where the meta block group would start. This must be considered when updating the backup block group descriptors to follow the non-meta_bg layout. The fix is to add a test whether the group to add is already part of the meta block group or not. Fixes: 01f795f9e0 ("ext4: add online resizing support for meta_bg and 64-bit file systems") Cc: <stable@vger.kernel.org> Signed-off-by: Maximilian Heyne <mheyne@amazon.de> Tested-by: Srivathsa Dara <srivathsa.d.dara@oracle.com> Reviewed-by: Srivathsa Dara <srivathsa.d.dara@oracle.com> Link: https://lore.kernel.org/r/20240215155009.94493-1-mheyne@amazon.de Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-04-13 12:51:26 +02:00
..
9p	9p: missing chunk of "fs/9p: Don't update file type when updating file attributes"	2022-06-22 14:11:02 +02:00
adfs
affs	affs: initialize fsdata in affs_truncate()	2023-02-06 07:52:36 +01:00
afs	afs: Revert "afs: Hide silly-rename files from userspace"	2024-03-26 18:22:24 -04:00
autofs	autofs: fix memory leak of waitqueues in autofs_catatonic_mode	2023-09-23 11:00:02 +02:00
befs
bfs
btrfs	btrfs: fix off-by-one chunk length calculation at contains_pending_extent()	2024-04-13 12:51:25 +02:00
cachefiles	cachefiles: fix memory leak in cachefiles_add_cache()	2024-03-06 14:36:10 +00:00
ceph	ceph: fix deadlock or deadcode of misusing dget()	2024-02-23 08:25:03 +01:00
cifs	smb: client: fix OOB in smbCalcSize()	2024-01-08 11:29:47 +01:00
coda	coda: Avoid partial allocation of sig_inputArgs	2023-03-11 16:43:56 +01:00
configfs	configfs: fix possible memory leak in configfs_create_dir()	2023-01-18 11:41:09 +01:00
cramfs
crypto
debugfs	new helper: lookup_positive_unlocked()	2023-09-23 10:59:40 +02:00
devpts	fsnotify: fix fsnotify hooks in pseudo filesystems	2022-02-01 17:24:34 +01:00
dlm	dlm: fix plock lookup when using multiple lockspaces	2023-09-23 10:59:55 +02:00
ecryptfs	ecryptfs: Reject casefold directory inodes	2024-02-23 08:24:56 +01:00
efivarfs
efs
erofs	erofs: ensure that the post-EOF tails are all zeroed	2023-09-23 10:59:36 +02:00
exportfs
ext2	ext2: fix datatype of block number in ext2_xattr_set2()	2023-09-23 11:00:04 +02:00
ext4	ext4: fix corruption during on-line resize	2024-04-13 12:51:26 +02:00
f2fs	f2fs: fix to check return value of f2fs_reserve_new_block()	2024-02-23 08:25:00 +01:00
fat	fat: fix uninitialized field in nostale filehandles	2024-04-13 12:51:23 +02:00
freevxfs
fscache
fuse	fuse: don't unhash root	2024-04-13 12:51:25 +02:00
gfs2	gfs2: Fix kernel NULL pointer dereference in gfs2_rgrp_dump	2024-01-25 14:34:24 -08:00
hfs	hfs: fix missing hfs_bnode_get() in __hfs_bnode_create	2023-03-11 16:43:59 +01:00
hfsplus	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
hostfs
hpfs
hugetlbfs	fs,hugetlb: fix NULL pointer dereference in hugetlbs_fill_super	2024-03-06 14:36:10 +00:00
iomap	iomap: Set all uptodate bits for an Uptodate page	2024-03-01 13:13:35 +01:00
isofs	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
jbd2	jbd2: correct the printing of write_flags in jbd2_write_superblock()	2024-01-25 14:34:20 -08:00
jffs2	jffs2: reduce stack usage in jffs2_build_xattr_subsystem()	2023-07-27 08:37:25 +02:00
jfs	jfs: fix array-index-out-of-bounds in diNewExt	2024-02-23 08:24:55 +01:00
kernfs	fs/kernfs/dir: obey S_ISGID	2024-02-23 08:25:03 +01:00
lockd	fs: lockd: avoid possible wrong NULL parameter	2023-09-23 10:59:48 +02:00
minix	minix: fix bug when opening a file with O_DIRECT	2022-04-15 14:18:35 +02:00
nfs	NFS: Fix an off by one in root_nfs_cat()	2024-03-26 18:22:24 -04:00
nfs_common
nfsd	nfsd: fix file memleak on client_opens_release	2023-11-28 16:50:21 +00:00
nilfs2	nilfs2: replace WARN_ONs for invalid DAT metadata block requests	2024-03-01 13:13:32 +01:00
nls	fs/nls: make load_nls() take a const parameter	2023-09-23 10:59:38 +02:00
notify	fanotify: disallow mount/sb marks on kernel internal pseudo fs	2023-07-27 08:37:26 +02:00
ntfs	ntfs: check overflow when iterating ATTR_RECORDs	2022-11-25 17:42:22 +01:00
ocfs2	fs: move S_ISGID stripping into the vfs_*() helpers	2024-02-23 08:24:49 +01:00
omfs	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
openpromfs
orangefs	orangefs: Fix kmemleak in orangefs_{kernel,client}_debug_init()	2023-01-18 11:41:39 +01:00
overlayfs	ovl: skip overlayfs superblocks at global sync	2023-12-08 08:44:27 +01:00
proc	procfs: block chmod on /proc/thread-self/comm	2023-09-23 10:59:55 +02:00
pstore	pstore/ram: Fix crash when setting number of cpus to an odd number	2024-02-23 08:24:55 +01:00
qnx4
qnx6
quota	quota: Fix rcu annotations of inode dquot pointers	2024-03-26 18:22:20 -04:00
ramfs
reiserfs	reiserfs: Check the return value from __getblk()	2023-09-23 10:59:40 +02:00
romfs
squashfs	revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"	2023-02-22 12:50:39 +01:00
sysfs
sysv	fs/sysv: Null check to prevent null-ptr-deref bug	2023-08-11 11:53:59 +02:00
tracefs	tracefs: Add missing lockdown check to tracefs_create_dir()	2023-09-23 11:00:06 +02:00
ubifs	ubifs: Set page uptodate in the correct place	2024-04-13 12:51:23 +02:00
udf	udf: initialize newblock to 0	2023-09-23 10:59:56 +02:00
ufs
unicode
verity	fsverity: skip PKCS#7 parser when keyring is empty	2023-09-23 10:59:55 +02:00
xfs	xfs: verify buffer contents when we skip log replay	2023-06-28 10:18:42 +02:00
aio.c	fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio	2024-03-01 13:13:38 +01:00
anon_inodes.c
attr.c	attr: block mode changes of symlinks	2023-09-23 11:00:06 +02:00
bad_inode.c
binfmt_aout.c	binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf	2023-01-18 11:41:46 +01:00
binfmt_elf.c
binfmt_elf_fdpic.c	fs: binfmt_elf_efpic: fix personality for ELF-FDPIC	2023-10-10 21:46:42 +02:00
binfmt_em86.c
binfmt_flat.c	binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf	2023-01-18 11:41:46 +01:00
binfmt_misc.c	binfmt_misc: fix shift-out-of-bounds in check_special_flags	2023-01-18 11:41:33 +01:00
binfmt_script.c
block_dev.c	block: Don't invalidate pagecache for invalid falloc modes	2024-01-08 11:29:48 +01:00
buffer.c	mm: fs: initialize fsdata passed to write_begin/write_end interface	2022-11-25 17:42:22 +01:00
char_dev.c	chardev: fix error handling in cdev_device_add()	2023-01-18 11:41:25 +01:00
compat.c
compat_binfmt_elf.c
compat_ioctl.c	lsm: new security_file_ioctl_compat() hook	2024-02-23 08:25:15 +01:00
coredump.c
d_path.c
dax.c	dax: fix cache flush on PMD-mapped pages	2022-06-14 18:11:41 +02:00
dcache.c	fast_dput(): handle underflows gracefully	2024-02-23 08:25:00 +01:00
dcookies.c
direct-io.c
drop_caches.c
eventfd.c	eventfd: prevent underflow for eventfd semaphores	2023-09-23 10:59:40 +02:00
eventpoll.c	epoll: ep_autoremove_wake_function should use list_del_init_careful	2023-06-28 10:18:35 +02:00
exec.c	exec: Force single empty string when argv is empty	2022-06-06 08:33:50 +02:00
fcntl.c
fhandle.c	do_sys_name_to_handle(): use kzalloc() to fix kernel-infoleak	2024-03-26 18:22:13 -04:00
file.c	fs: prevent out-of-bounds array speculation when closing a file descriptor	2023-03-17 08:32:47 +01:00
file_table.c	SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()	2022-05-25 09:14:34 +02:00
filesystems.c
fs-writeback.c	writeback: fix call of incorrect macro	2023-05-17 11:35:58 +02:00
fs_context.c	fs: avoid empty option when generating legacy mount string	2023-07-27 08:37:25 +02:00
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fsopen.c
inode.c	fs: move S_ISGID stripping into the vfs_*() helpers	2024-02-23 08:24:49 +01:00
internal.h	fs: Establish locking order for unrelated directories	2023-07-27 08:37:26 +02:00
io_uring.c	io_uring: drop any code related to SCM_RIGHTS	2024-03-26 18:22:12 -04:00
ioctl.c
Kconfig
Kconfig.binfmt
libfs.c	libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value	2023-01-18 11:40:55 +01:00
locks.c	locks: fix KASAN: use-after-free in trace_event_raw_event_filelock_lock	2023-09-23 11:00:02 +02:00
Makefile
mbcache.c	mbcache: Avoid nesting of cache->c_list_lock under bit locks	2023-01-18 11:41:59 +01:00
mount.h
mpage.c
namei.c	fs: move S_ISGID stripping into the vfs_*() helpers	2024-02-23 08:24:49 +01:00
namespace.c
no-block.c
nsfs.c
open.c
pipe.c
pnode.c	pnode: terminate at peers of source	2023-01-18 11:41:44 +01:00
pnode.h
posix_acl.c
proc_namespace.c
read_write.c
readdir.c
select.c	fs/select: rework stack allocation hack for clang	2024-03-26 18:22:13 -04:00
seq_file.c
signalfd.c	io_uring: disable polling pollfree files	2022-09-05 10:27:47 +02:00
splice.c	Revert "fs: check FMODE_LSEEK to control internal pipe splicing"	2022-10-17 17:24:32 +02:00
stack.c
stat.c	stat: fix inconsistency between struct stat and struct compat_stat	2022-04-27 13:50:48 +02:00
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-30 12:44:07 +01:00
super.c	fs: Protect reconfiguration of sb read-write from racing writes	2023-08-11 11:53:59 +02:00
sync.c	ovl: skip overlayfs superblocks at global sync	2023-12-08 08:44:27 +01:00
timerfd.c
userfaultfd.c	userfaultfd: open userfaultfds with O_RDONLY	2022-10-26 13:22:21 +02:00
utimes.c
xattr.c	fs: don't audit the capability check in simple_xattr_list()	2023-01-18 11:40:53 +01:00