Nick Dyer
68807a0c20
Input: atmel_mxt_ts - fix invalid return from mxt_get_bootloader_version
The patch e57a66aa85: "Input: atmel_mxt_ts - read and report
bootloader version" from May 18, 2014, leads to the following static
checker warning:
drivers/input/touchscreen/atmel_mxt_ts.c:437 mxt_get_bootloader_version()
warn: signedness bug returning '(-5)'
drivers/input/touchscreen/atmel_mxt_ts.c
429 static u8 mxt_get_bootloader_version(struct mxt_data *data, u8 val)
430 {
431 struct device *dev = &data->client->dev;
432 u8 buf[3];
433
434 if (val & MXT_BOOT_EXTENDED_ID) {
435 if (mxt_bootloader_read(data, &buf[0], 3) != 0) {
436 dev_err(dev, "%s: i2c failure\n", __func__);
437 return -EIO;
^^^^
This gets truncated into a number from 0-255 and anyway the caller
doesn't check for errors.
(reported by Dan Carpenter)
Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
|
2014-06-07 23:20:24 -07:00 |
| .. |
|
gameport
|
Input: delete non-required instances of include <linux/init.h>
|
2014-01-06 23:23:57 -08:00 |
|
joystick
|
Merge branch 'next' into for-linus
|
2014-01-23 08:10:44 -08:00 |
|
keyboard
|
Input: omap-keypad - remove platform data support
|
2014-05-29 00:33:32 -07:00 |
|
misc
|
Input: max8997_haptic - add error handling for regulator and pwm
|
2014-06-07 23:20:24 -07:00 |
|
mouse
|
Input: elantech - don't set bit 1 of reg_10 when the no_hw_res quirk is set
|
2014-06-07 23:20:23 -07:00 |
|
serio
|
Linux 3.15-rc5
|
2014-05-14 16:49:19 -07:00 |
|
tablet
|
Input: wacom - process outbound for newer Cintiqs
|
2014-05-29 00:09:16 -07:00 |
|
touchscreen
|
Input: atmel_mxt_ts - fix invalid return from mxt_get_bootloader_version
|
2014-06-07 23:20:24 -07:00 |
|
apm-power.c
|
|
|
|
evbug.c
|
|
|
|
evdev.c
|
Linux 3.15-rc5
|
2014-05-14 16:49:19 -07:00 |
|
ff-core.c
|
|
|
|
ff-memless.c
|
|
|
|
input-compat.c
|
|
|
|
input-compat.h
|
|
|
|
input-mt.c
|
Input: MT - handle semi-mt devices in core
|
2013-04-07 21:02:32 -07:00 |
|
input-polldev.c
|
Input: implement managed polled input devices
|
2014-05-14 16:40:04 -07:00 |
|
input.c
|
Merge branch 'next' into for-linus
|
2014-01-23 08:10:44 -08:00 |
|
joydev.c
|
|
|
|
Kconfig
|
Input: mousedev - allow disabling even without CONFIG_EXPERT
|
2013-10-31 08:46:07 -07:00 |
|
Makefile
|
|
|
|
matrix-keymap.c
|
input: Export matrix_keypad_parse_of_params()
|
2013-04-19 00:31:13 +02:00 |
|
mousedev.c
|
Input: mousedev - fix race when creating mixed device
|
2014-03-29 14:44:23 -07:00 |
|
sparse-keymap.c
|
treewide: Fix typo in Documentation/DocBook
|
2014-02-19 14:58:17 +01:00 |