Karl Beldan
11b2357d5d
mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats
...
ATM an HT rc_stats line is 106 chars.
Times 8(MCS_GROUP_RATES)*3(SS)*2(GI)*2(BW) + CCK(4), i.e. x100, this is
well above the current 8192 - sizeof(*ms) currently allocated.
Fix this by squeezing the output as follows (not that we're short on
memory but this also improves readability and range, the new format adds
one more digit to *ok/*cum and ok/cum):
- Before (HT) (106 ch):
type rate throughput ewma prob this prob retry this succ/attempt success attempts
CCK/LP 5.5M 0.0 0.0 0.0 0 0( 0) 0 0
HT20/LGI ABCDP MCS0 0.0 0.0 0.0 1 0( 0) 0 0
- After (75 ch):
type rate tpt eprob *prob ret *ok(*cum) ok( cum)
CCK/LP 5.5M 0.0 0.0 0.0 0 0( 0) 0( 0)
HT20/LGI ABCDP MCS0 0.0 0.0 0.0 1 0( 0) 0( 0)
- Align non-HT format Before (non-HT) (83 ch):
rate throughput ewma prob this prob this succ/attempt success attempts
ABCDP 6 0.0 0.0 0.0 0( 0) 0 0
54 0.0 0.0 0.0 0( 0) 0 0
- After (61 ch):
rate tpt eprob *prob *ok(*cum) ok( cum)
ABCDP 1 0.0 0.0 0.0 0( 0) 0( 0)
54 0.0 0.0 0.0 0( 0) 0( 0)
*This also adds dynamic checks for overflow, lowers the size of the
non-HT request (allowing > 30 entries) and replaces the buddy-rounded
allocations (s/sizeof(*ms) + 8192/8192).
Signed-off-by: Karl Beldan <[email protected] >
Acked-by: Felix Fietkau <[email protected] >
Signed-off-by: Johannes Berg <[email protected] >
2014-10-20 16:37:01 +02:00
..
aes_ccm.c
mac80211: remove VLAIS usage from mac80211
2014-04-09 10:55:27 +02:00
aes_ccm.h
aes_cmac.c
aes_cmac.h
agg-rx.c
mac80211: fix offloaded BA session traffic after hw restart
2014-09-03 13:40:38 +02:00
agg-tx.c
mac80211: introduce refcount for queue_stop_reasons
2014-06-23 14:22:25 +02:00
cfg.c
mac80211: return the vif's chandef in ieee80211_cfg_get_channel()
2014-10-09 11:01:58 +02:00
cfg.h
mac80211: make cfg80211 ops and privid const
2014-02-04 21:48:21 +01:00
chan.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless
2014-09-08 11:14:56 -04:00
debug.h
debugfs.c
mac80211: replace SMPS hw flags with wiphy feature bits
2014-09-11 13:37:02 +02:00
debugfs.h
mac80211: fix some missing includes
2014-04-09 14:49:43 +02:00
debugfs_key.c
debugfs_key.h
debugfs_netdev.c
mac80211: replace SMPS hw flags with wiphy feature bits
2014-09-11 13:37:02 +02:00
debugfs_netdev.h
mac80211: fix some missing includes
2014-04-09 14:49:43 +02:00
debugfs_sta.c
This time, I have some rate minstrel improvements, support for a very
2014-09-15 14:51:23 -04:00
debugfs_sta.h
driver-ops.h
mac80211: extend set_coverage_class signature
2014-09-05 13:54:07 +02:00
ethtool.c
cfg80211: make ethtool the driver's responsibility
2014-06-23 11:05:33 +02:00
event.c
ht.c
mac80211: set Rx highest rate in ht_cap
2014-07-21 12:14:04 +02:00
ibss.c
mac80211: add Intel Mobile Communications copyright
2014-09-05 13:52:06 +02:00
ieee80211_i.h
mac80211: support DTPC IE (from Cisco Client eXtensions)
2014-09-08 10:52:00 +02:00
iface.c
mac80211: add Intel Mobile Communications copyright
2014-09-05 13:52:06 +02:00
Kconfig
mac80211: remove PID rate control
2014-06-23 11:05:23 +02:00
key.c
mac80211: clear key material when freeing keys
2014-09-11 12:07:23 +02:00
key.h
led.c
led.h
main.c
mac80211: add Intel Mobile Communications copyright
2014-09-05 13:52:06 +02:00
Makefile
cfg80211: make ethtool the driver's responsibility
2014-06-23 11:05:33 +02:00
mesh.c
mac80211: move csa counters from sdata to beacon/presp
2014-06-23 14:22:06 +02:00
mesh.h
mesh_hwmp.c
mac80211: remove unnecessary break after return
2014-07-15 16:27:00 -07:00
mesh_pathtbl.c
mac80211: Replace rcu_dereference() with rcu_access_pointer()
2014-08-27 12:14:10 +02:00
mesh_plink.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless
2014-09-08 11:14:56 -04:00
mesh_ps.c
mac80211: clear sequence/fragment number in QoS-null frames
2014-03-05 15:49:54 +01:00
mesh_sync.c
mac80211: remove BUG_ON usage
2014-04-29 17:59:27 +02:00
michael.c
michael.h
mac80211: fix some missing includes
2014-04-09 14:49:43 +02:00
mlme.c
This time, I have some rate minstrel improvements, support for a very
2014-09-15 14:51:23 -04:00
offchannel.c
mac80211: introduce refcount for queue_stop_reasons
2014-06-23 14:22:25 +02:00
pm.c
mac80211: introduce refcount for queue_stop_reasons
2014-06-23 14:22:25 +02:00
rate.c
mac80211: fix typo in starting baserate for rts_cts_rate_idx
2014-10-14 11:16:16 +02:00
rate.h
mac80211: remove PID rate control
2014-06-23 11:05:23 +02:00
rc80211_minstrel.c
mac80211: Unify rate statistic variables between Minstrel & Minstrel_HT
2014-09-11 12:08:31 +02:00
rc80211_minstrel.h
mac80211: Unify rate statistic variables between Minstrel & Minstrel_HT
2014-09-11 12:08:31 +02:00
rc80211_minstrel_debugfs.c
mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats
2014-10-20 16:37:01 +02:00
rc80211_minstrel_ht.c
mac80211: improve minstrel_ht rate sorting by throughput & probability
2014-09-11 12:10:14 +02:00
rc80211_minstrel_ht.h
mac80211: improve minstrel_ht rate sorting by throughput & probability
2014-09-11 12:10:14 +02:00
rc80211_minstrel_ht_debugfs.c
mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats
2014-10-20 16:37:01 +02:00
rx.c
mac80211: add Intel Mobile Communications copyright
2014-09-05 13:52:06 +02:00
scan.c
mac80211: add Intel Mobile Communications copyright
2014-09-05 13:52:06 +02:00
spectmgmt.c
sta_info.c
Merge tag 'master-2014-09-16' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next
2014-09-26 15:39:24 -04:00
sta_info.h
mac80211: fix warning on htmldocs for last_tdls_pkt_time
2014-10-09 10:33:29 +02:00
status.c
mac80211: add TDLS connection timeout
2014-09-11 12:18:47 +02:00
tdls.c
mac80211: set network header in TDLS frames
2014-09-11 12:25:22 +02:00
tkip.c
tkip.h
trace.c
trace.h
mac80211: extend set_coverage_class signature
2014-09-05 13:54:07 +02:00
tx.c
Merge tag 'master-2014-09-16' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next
2014-09-26 15:39:24 -04:00
util.c
mac80211: support DTPC IE (from Cisco Client eXtensions)
2014-09-08 10:52:00 +02:00
vht.c
mac80211: disable VHT for TDLS
2014-07-21 12:14:04 +02:00
wep.c
mac80211: remove weak WEP IV accounting
2014-06-23 11:05:31 +02:00
wep.h
wme.c
mac80211: add Intel Mobile Communications copyright
2014-09-05 13:52:06 +02:00
wme.h
wpa.c
mac80211: annotate MMIC head/tailroom warning
2014-09-08 11:22:42 +02:00
wpa.h