Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Paolo Abeni 59801e88c9 net: relax socket state check at accept time. ... commit 26afda78cda3da974fd4c287962c169e9462c495 upstream. Christoph reported the following splat: WARNING: CPU: 1 PID: 772 at net/ipv4/af_inet.c:761 __inet_accept+0x1f4/0x4a0 Modules linked in: CPU: 1 PID: 772 Comm: syz-executor510 Not tainted 6.9.0-rc7-g7da7119fe22b #56 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2.el7 04/01/2014 RIP: 0010:__inet_accept+0x1f4/0x4a0 net/ipv4/af_inet.c:759 Code: 04 38 84 c0 0f 85 87 00 00 00 41 c7 04 24 03 00 00 00 48 83 c4 10 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc e8 ec b7 da fd <0f> 0b e9 7f fe ff ff e8 e0 b7 da fd 0f 0b e9 fe fe ff ff 89 d9 80 RSP: 0018:ffffc90000c2fc58 EFLAGS: 00010293 RAX: ffffffff836bdd14 RBX: 0000000000000000 RCX: ffff888104668000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: dffffc0000000000 R08: ffffffff836bdb89 R09: fffff52000185f64 R10: dffffc0000000000 R11: fffff52000185f64 R12: dffffc0000000000 R13: 1ffff92000185f98 R14: ffff88810754d880 R15: ffff8881007b7800 FS: 000000001c772880(0000) GS:ffff88811b280000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fb9fcf2e178 CR3: 00000001045d2002 CR4: 0000000000770ef0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: <TASK> inet_accept+0x138/0x1d0 net/ipv4/af_inet.c:786 do_accept+0x435/0x620 net/socket.c:1929 __sys_accept4_file net/socket.c:1969 [inline] __sys_accept4+0x9b/0x110 net/socket.c:1999 __do_sys_accept net/socket.c:2016 [inline] __se_sys_accept net/socket.c:2013 [inline] __x64_sys_accept+0x7d/0x90 net/socket.c:2013 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x58/0x100 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x76/0x7e RIP: 0033:0x4315f9 Code: fd ff 48 81 c4 80 00 00 00 e9 f1 fe ff ff 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 ab b4 fd ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007ffdb26d9c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002b RAX: ffffffffffffffda RBX: 0000000000400300 RCX: 00000000004315f9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000004 RBP: 00000000006e1018 R08: 0000000000400300 R09: 0000000000400300 R10: 0000000000400300 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000040cdf0 R14: 000000000040ce80 R15: 0000000000000055 </TASK> The reproducer invokes shutdown() before entering the listener status. After commit 94062790aedb ("tcp: defer shutdown(SEND_SHUTDOWN) for TCP_SYN_RECV sockets"), the above causes the child to reach the accept syscall in FIN_WAIT1 status. Eric noted we can relax the existing assertion in __inet_accept() Reported-by: Christoph Paasch <cpaasch@apple.com> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/490 Suggested-by: Eric Dumazet <edumazet@google.com> Fixes: 94062790aedb ("tcp: defer shutdown(SEND_SHUTDOWN) for TCP_SYN_RECV sockets") Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/r/23ab880a44d8cfd967e84de8b93dbf48848e3d8c.1716299669.git.pabeni@redhat.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Nikolay Kuratov <kniv@yandex-team.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-07-27 10:38:33 +02:00
..
bpfilter
netfilter	netfilter: tproxy: bail out if IP has been disabled on the device	2024-06-16 13:28:47 +02:00
af_inet.c	net: relax socket state check at accept time.	2024-07-27 10:38:33 +02:00
ah4.c
arp.c
cipso_ipv4.c	cipso: fix total option length computation	2024-07-05 09:08:22 +02:00
datagram.c
devinet.c	ipv4: properly combine dev_base_seq and ipv4.dev_addr_genid	2024-03-01 13:13:37 +01:00
esp4.c	net: ipv4: fix return value check in esp_remove_trailer	2023-10-25 11:53:21 +02:00
esp4_offload.c	xfrm: Linearize the skb after offloading if needed.	2023-06-28 10:18:38 +02:00
fib_frontend.c	ipv4: Fix incorrect table ID in IOCTL path	2023-03-22 13:28:06 +01:00
fib_lookup.h
fib_notifier.c
fib_rules.c
fib_semantics.c	ipv4: fib: annotate races around nh->nh_saddr_genid and nh->nh_saddr	2023-10-25 11:53:21 +02:00
fib_trie.c	ipv4: annotate data-races around fi->fib_dead	2023-09-23 10:59:58 +02:00
fou.c
gre_demux.c
gre_offload.c
icmp.c	icmp: guard against too small mtu	2023-04-20 12:07:33 +02:00
igmp.c	ipv4: igmp: fix refcnt uaf issue when receiving igmp query packet	2023-12-08 08:44:27 +01:00
inet_connection_sock.c	tcp: properly terminate timers for kernel sockets	2024-04-13 12:51:33 +02:00
inet_diag.c	inet_diag: Initialize pad field in struct inet_diag_req_v2	2024-07-18 11:40:50 +02:00
inet_fragment.c
inet_hashtables.c	Revert "tcp: avoid the lookup process failing to get sk in ehash table"	2023-07-27 08:37:44 +02:00
inet_timewait_sock.c	tcp: Fix NEW_SYN_RECV handling in inet_twsk_purge()	2024-05-02 16:18:37 +02:00
inetpeer.c
ip_forward.c
ip_fragment.c
ip_gre.c	ip_gre: do not report erspan version on GRE interface	2024-04-13 12:51:40 +02:00
ip_input.c
ip_options.c
ip_output.c	net: ipv4: fix a memleak in ip_setup_cork	2024-02-23 08:25:05 +01:00
ip_sockglue.c	ipv{4,6}/raw: fix output xfrm lookup wrt protocol	2023-06-05 08:17:33 +02:00
ip_tunnel.c	net: ip_tunnel: make sure to pull inner header in ip_tunnel_rcv()	2024-03-26 18:22:17 -04:00
ip_tunnel_core.c
ip_vti.c	ip_vti: fix potential slab-use-after-free in decode_session6	2023-08-30 16:27:16 +02:00
ipcomp.c
ipconfig.c
ipip.c
ipmr.c
ipmr_base.c
Kconfig
Makefile
metrics.c
netfilter.c
netlink.c
nexthop.c
ping.c
proc.c
protocol.c
raw.c	ipv{4,6}/raw: fix output xfrm lookup wrt protocol	2023-06-05 08:17:33 +02:00
raw_diag.c
route.c	net: fix __dst_negative_advice() race	2024-06-16 13:28:52 +02:00
syncookies.c	tcp: fix cookie_init_timestamp() overflows	2023-11-20 10:30:10 +01:00
sysctl_net_ipv4.c
tcp.c	tcp: add TCP_INFO status for failed client TFO	2024-07-18 11:40:53 +02:00
tcp_bbr.c
tcp_bic.c
tcp_bpf.c
tcp_cdg.c
tcp_cong.c
tcp_cubic.c
tcp_dctcp.c	tcp: Fix shift-out-of-bounds in dctcp_update_alpha().	2024-06-16 13:28:45 +02:00
tcp_dctcp.h
tcp_diag.c
tcp_fastopen.c	tcp: add TCP_INFO status for failed client TFO	2024-07-18 11:40:53 +02:00
tcp_highspeed.c
tcp_htcp.c
tcp_hybla.c
tcp_illinois.c
tcp_input.c	tcp: fix incorrect undo caused by DSACK of TLP retransmit	2024-07-18 11:40:53 +02:00
tcp_ipv4.c	tcp: avoid premature drops in tcp_add_backlog()	2024-06-16 13:28:35 +02:00
tcp_lp.c
tcp_metrics.c	tcp_metrics: validate source addr length	2024-07-18 11:40:50 +02:00
tcp_minisocks.c
tcp_nv.c
tcp_offload.c
tcp_output.c	tcp: defer shutdown(SEND_SHUTDOWN) for TCP_SYN_RECV sockets	2024-05-17 11:43:53 +02:00
tcp_rate.c
tcp_recovery.c	tcp: fix excessive TLP and RACK timeouts from HZ rounding	2023-10-25 11:53:21 +02:00
tcp_scalable.c
tcp_timer.c	tcp: avoid too many retransmit packets	2024-07-18 11:40:56 +02:00
tcp_ulp.c
tcp_vegas.c
tcp_vegas.h
tcp_veno.c
tcp_westwood.c
tcp_yeah.c
tunnel4.c
udp.c	udp: Set SOCK_RCU_FREE earlier in udp_lib_get_port().	2024-07-18 11:40:53 +02:00
udp_diag.c
udp_impl.h
udp_offload.c
udp_tunnel.c
udplite.c	udplite: Fix NULL pointer dereference in __sk_mem_raise_allocated().	2023-05-30 12:44:09 +01:00
xfrm4_input.c	xfrm: Preserve vlan tags for transport mode software GRO	2024-05-17 11:43:53 +02:00
xfrm4_output.c
xfrm4_policy.c
xfrm4_protocol.c
xfrm4_state.c
xfrm4_tunnel.c