Nicholas Bellinger
6f48655fac
target: Fix node_acl demo-mode + uncached dynamic shutdown regression
...
This patch fixes a generate_node_acls = 1 + cache_dynamic_acls = 0
regression, that was introduced by
commit 01d4d67355
Author: Nicholas Bellinger <nab@linux-iscsi.org>
Date: Wed Dec 7 12:55:54 2016 -0800
which originally had the proper list_del_init() usage, but was
dropped during list review as it was thought unnecessary by HCH.
However, list_del_init() usage is required during the special
generate_node_acls = 1 + cache_dynamic_acls = 0 case when
transport_free_session() does a list_del(&se_nacl->acl_list),
followed by target_complete_nacl() doing the same thing.
This was manifesting as a general protection fault as reported
by Justin:
kernel: general protection fault: 0000 [#1 ] SMP
kernel: Modules linked in:
kernel: CPU: 0 PID: 11047 Comm: iscsi_ttx Not tainted 4.13.0-rc2.x86_64.1+ #20
kernel: Hardware name: Intel Corporation S5500BC/S5500BC, BIOS S5500.86B.01.00.0064.050520141428 05/05/2014
kernel: task: ffff88026939e800 task.stack: ffffc90007884000
kernel: RIP: 0010:target_put_nacl+0x49/0xb0
kernel: RSP: 0018:ffffc90007887d70 EFLAGS: 00010246
kernel: RAX: dead000000000200 RBX: ffff8802556ca000 RCX: 0000000000000000
kernel: RDX: dead000000000100 RSI: 0000000000000246 RDI: ffff8802556ce028
kernel: RBP: ffffc90007887d88 R08: 0000000000000001 R09: 0000000000000000
kernel: R10: ffffc90007887df8 R11: ffffea0009986900 R12: ffff8802556ce020
kernel: R13: ffff8802556ce028 R14: ffff8802556ce028 R15: ffffffff88d85540
kernel: FS: 0000000000000000(0000) GS:ffff88027fc00000(0000) knlGS:0000000000000000
kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
kernel: CR2: 00007fffe36f5f94 CR3: 0000000009209000 CR4: 00000000003406f0
kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
kernel: DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
kernel: Call Trace:
kernel: transport_free_session+0x67/0x140
kernel: transport_deregister_session+0x7a/0xc0
kernel: iscsit_close_session+0x92/0x210
kernel: iscsit_close_connection+0x5f9/0x840
kernel: iscsit_take_action_for_connection_exit+0xfe/0x110
kernel: iscsi_target_tx_thread+0x140/0x1e0
kernel: ? wait_woken+0x90/0x90
kernel: kthread+0x124/0x160
kernel: ? iscsit_thread_get_cpumask+0x90/0x90
kernel: ? kthread_create_on_node+0x40/0x40
kernel: ret_from_fork+0x22/0x30
kernel: Code: 00 48 89 fb 4c 8b a7 48 01 00 00 74 68 4d 8d 6c 24 08 4c
89 ef e8 e8 28 43 00 48 8b 93 20 04 00 00 48 8b 83 28 04 00 00 4c 89
ef <48> 89 42 08 48 89 10 48 b8 00 01 00 00 00 00 ad de 48 89 83 20
kernel: RIP: target_put_nacl+0x49/0xb0 RSP: ffffc90007887d70
kernel: ---[ end trace f12821adbfd46fed ]---
To address this, go ahead and use proper list_del_list() for all
cases of se_nacl->acl_list deletion.
Reported-by: Justin Maggard <jmaggard01@gmail.com>
Tested-by: Justin Maggard <jmaggard01@gmail.com>
Cc: Justin Maggard <jmaggard01@gmail.com>
Cc: stable@vger.kernel.org # 4.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2017-08-09 20:55:19 -07:00
arch
xen/x86: fix cpu hotplug
2017-07-23 08:13:11 +02:00
block
bfq: dispatch request to prevent queue stalling after the request completion
2017-07-12 08:32:04 -06:00
certs
modsign: add markers to endif-statements in certs/Makefile
2017-07-14 11:01:37 +10:00
crypto
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2017-07-14 22:49:50 -07:00
Documentation
TTY/Serial fixes for 4.13-rc2
2017-07-22 09:00:24 -07:00
drivers
target: Fix node_acl demo-mode + uncached dynamic shutdown regression
2017-08-09 20:55:19 -07:00
firmware
firmware/Makefile: force recompilation if makefile changes
2017-05-08 17:15:10 -07:00
fs
NFS client bugfixes for 4.13
2017-07-21 16:26:01 -07:00
include
iscsi-target: Fix iscsi_np reset hung task during parallel delete
2017-08-06 14:41:41 -07:00
init
random: do not ignore early device randomness
2017-07-12 16:26:00 -07:00
ipc
ipc/util.h: update documentation for ipc_getref() and ipc_putref()
2017-07-12 16:26:02 -07:00
kernel
Three minor updates
2017-07-21 13:59:51 -07:00
lib
Add wait_for_random_bytes() and get_random_*_wait() functions so that
2017-07-15 12:44:02 -07:00
mm
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-07-15 12:00:42 -07:00
net
NFS client bugfixes for 4.13
2017-07-21 16:26:01 -07:00
samples
Merge branch 'akpm' (patches from Andrew)
2017-07-13 12:38:49 -07:00
scripts
Properly alphabetize MAINTAINERS file
2017-07-23 16:06:21 -07:00
security
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
sound
sound fixes for 4.13-rc1
2017-07-14 12:44:00 -07:00
tools
Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2017-07-21 11:12:48 -07:00
usr
ramfs: clarify help text that compression applies to ramfs as well as legacy ramdisk.
2017-07-06 16:24:30 -07:00
virt
Second batch of KVM updates for v4.13
2017-07-15 10:18:16 -07:00
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap
power supply and reset changes for the v4.12 series (part 2)
2017-05-12 12:02:21 -07:00
COPYING
CREDITS
Kbuild
Kconfig
MAINTAINERS
Properly alphabetize MAINTAINERS file
2017-07-23 16:06:21 -07:00
Makefile
Linux 4.13-rc2
2017-07-23 16:15:17 -07:00
README