Luis Chamberlain
72647ea377
blktrace: break out of blktrace setup on concurrent calls ...
[ Upstream commit 1b0b283648163dae2a214ca28ed5a99f62a77319 ]
We use one blktrace per request_queue, that means one per the entire
disk. So we cannot run one blktrace on say /dev/vda and then /dev/vda1,
or just two calls on /dev/vda.
We check for concurrent setup only at the very end of the blktrace setup though.
If we try to run two concurrent blktraces on the same block device the
second one will fail, and the first one seems to go on. However when
one tries to kill the first one one will see things like this:
The kernel will show these:
```
debugfs: File 'dropped' in directory 'nvme1n1' already present!
debugfs: File 'msg' in directory 'nvme1n1' already present!
debugfs: File 'trace0' in directory 'nvme1n1' already present!
``
And userspace just sees this error message for the second call:
```
blktrace /dev/nvme1n1
BLKTRACESETUP(2) /dev/nvme1n1 failed: 5/Input/output error
```
The first userspace process #1 will also claim that the files
were taken underneath their nose as well. The files are taken
away form the first process given that when the second blktrace
fails, it will follow up with a BLKTRACESTOP and BLKTRACETEARDOWN.
This means that even if go-happy process #1 is waiting for blktrace
data, we *have* been asked to take teardown the blktrace.
This can easily be reproduced with break-blktrace [0] run_0005.sh test.
Just break out early if we know we're already going to fail, this will
prevent trying to create the files all over again, which we know still
exist.
[0] https://github.com/mcgrof/break-blktrace
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-06-30 15:37:05 -04:00
bpf: Don't return EINVAL from {get,set}sockopt when optlen > PAGE_SIZE
2020-06-30 15:36:56 -04:00
Revert "cgroup: Add memory barriers to plug cgroup_rstat_updated() race window"
2020-06-07 13:18:46 +02:00
kgdb: Prevent infinite recursive entries to the debugger
2020-06-22 09:30:54 +02:00
dma-direct: fix data truncation in dma_direct_get_required_mask()
2020-04-29 16:33:00 +02:00
perf: Add cond_resched() to task_function_call()
2020-06-17 16:40:36 +02:00
kernel/gcov/fs.c: gcov_seq_next() should increase position index
2020-04-29 16:33:00 +02:00
genirq/debugfs: Add missing sanity checks to interrupt injection
2020-04-17 10:50:11 +02:00
livepatch: Nullify obj->mod in klp_module_coming()'s error path
2019-08-19 13:03:37 +02:00
locktorture: Print ratio of acquisitions, not failures
2020-04-23 10:36:44 +02:00
PM: hibernate: Freeze kernel threads in software_resume()
2020-05-06 08:15:09 +02:00
printk: queue wake_up_klogd irq_work only if per-CPU areas are ready
2020-05-02 08:48:42 +02:00
rcu: Allow only one expedited GP to run concurrently with wakeups
2020-03-05 16:43:50 +01:00
sched/core: Fix PI boosting between RT and DEADLINE tasks
2020-06-30 15:37:02 -04:00
time/sched_clock: Expire timer in hardirq context
2020-04-17 10:50:02 +02:00
blktrace: break out of blktrace setup on concurrent calls
2020-06-30 15:37:05 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:30:59 +02:00
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:30:59 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
audit_get_nd(): don't unlock parent too early
2019-11-10 11:56:55 -05:00
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:30:59 +02:00
audit: enforce op for string fields
2019-05-28 17:46:43 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
kernel/configs: Replace GPL boilerplate code with SPDX identifier
2019-07-30 18:34:15 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
sched/core: Fix illegal RCU from offline CPUs
2020-06-22 09:31:01 +02:00
kernel/cpu_pm: Fix uninitted local in cpu_pm
2020-06-22 09:31:22 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
keys: Fix request_key() cache
2020-01-17 19:48:42 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 25
2019-05-21 11:52:39 +02:00
kernel/elfcore.c: include proper prototypes
2019-09-25 17:51:39 -07:00
exit: Move preemption fixup up, move blocking operations down
2020-06-22 09:31:01 +02:00
extable: Add function to search only kernel exception table
2019-08-21 22:23:48 +10:00
fail_function: no need to check return value of debugfs_create functions
2019-06-03 15:49:06 +02:00
fork: prevent accidental access to clone3 features
2020-05-20 08:20:22 +02:00
Revert "libata, freezer: avoid block device removal while system is frozen"
2019-10-06 09:11:37 -06:00
futex: Unbreak futex hashing
2020-03-25 08:25:58 +01:00
kheaders: substituting --sort in archive creation
2019-10-17 09:08:19 +09:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
mm/nvdimm: add is_ioremap_addr and use that to check ioremap address
2019-07-12 11:05:40 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
jump_label: Don't warn on __exit jump entries
2019-08-29 15:10:10 +01:00
kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol
2019-08-27 16:19:56 +01:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
sched/rt, Kconfig: Unbreak def/oldconfig with CONFIG_PREEMPT=y
2019-07-22 18:05:11 +02:00
kexec_load: Disable at runtime if the kernel is locked down
2019-08-19 21:54:15 -07:00
kexec: bail out upon SIGKILL when allocating memory.
2019-09-25 17:51:40 -07:00
kexec_elf: support 32 bit ELF files
2019-09-06 23:58:44 +02:00
Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2019-09-28 08:14:15 -07:00
kheaders: Move from proc to sysfs
2019-05-24 20:16:01 +02:00
kmod: make request_module() return an error when autoloading is disabled
2020-04-17 10:50:22 +02:00
kprobes: Suppress the suspicious RCU warning on kprobes
2020-06-30 15:37:05 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 170
2019-05-30 11:26:39 -07:00
kthread: make __kthread_queue_delayed_work static
2019-10-16 09:20:58 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
Merge branch 'next-integrity' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity
2019-09-27 19:37:27 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
module: avoid setting info->name early in case we can fall back to info->mod->name
2020-02-24 08:36:54 +01:00
MODSIGN: Export module signature definitions
2019-08-05 18:39:56 -04:00
MODSIGN: Export module signature definitions
2019-08-05 18:39:56 -04:00
x86/mm: split vmalloc_sync_all()
2020-03-25 08:25:58 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
padata: add separate cpuhp node for CPUHP_PADATA_DEAD
2020-06-17 16:40:22 +02:00
panic: ensure preemption is disabled during panic()
2019-10-07 15:47:19 -07:00
lockdown: Lock down module params that specify hardware parameters (eg. ioport)
2019-08-19 21:54:16 -07:00
kernel/pid.c: convert struct pid count to refcount_t
2019-07-16 19:23:24 -07:00
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
ptrace: reintroduce usage of subjective credentials in ptrace_has_cap()
2020-01-23 08:22:36 +01:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
kernel/relay.c: handle alloc_percpu returning NULL in relay_open
2020-06-07 13:18:47 +02:00
/dev/mem: Revoke mappings when a driver claims the region
2020-06-24 17:50:35 +02:00
signal: Remove task parameter from force_sig
2019-05-27 09:36:28 -05:00
seccomp: Add missing compat_ioctl for notify
2020-04-17 10:50:09 +02:00
signal: check sig before setting info in kill_pid_usb_asyncio
2020-05-02 08:48:55 +02:00
smp: Warn on function calls from softirq context
2019-07-20 11:27:16 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-07-08 11:01:13 -07:00
stacktrace: Don't skip first entry on noncurrent tasks
2019-11-04 21:19:25 +01:00
stop_machine: Avoid potential race behaviour
2019-10-17 12:47:12 +02:00
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-09-17 12:35:15 -07:00
arch: handle arches who do not yet define clone3
2019-06-21 01:54:53 +02:00
kernel: sysctl: make drop_caches write-only
2020-01-04 19:18:32 +01:00
taskstats: fix data-race
2020-01-09 10:19:54 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 25
2019-05-21 11:52:39 +02:00
torture: Remove exporting of internal functions
2019-08-01 14:30:22 -07:00
The main changes in this release include:
2019-07-18 11:51:00 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
umh: fix memory leak on execve failure
2020-05-20 08:20:13 +02:00
smp: Remove smp_call_function() and on_each_cpu() return values
2019-06-23 14:26:26 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
Keyrings namespacing
2019-07-08 19:36:47 -07:00
Keyrings namespacing
2019-07-08 19:36:47 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
watchdog/softlockup: Enforce that timestamp is valid on boot
2020-02-24 08:36:52 +01:00
workqueue: don't use wq_select_unbound_cpu() for bound works
2020-03-18 07:17:50 +01:00
72647ea377