Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
zhenwei pi cfdd25cd42 crypto: public_key: fix overflow during implicit conversion ... commit f985911b7bc75d5c98ed24d8aaa8b94c590f7c6a upstream. Hit kernel warning like this, it can be reproduced by verifying 256 bytes datafile by keyctl command, run script: RAWDATA=rawdata SIGDATA=sigdata modprobe pkcs8_key_parser rm -rf *.der *.pem *.pfx rm -rf $RAWDATA dd if=/dev/random of=$RAWDATA bs=256 count=1 openssl req -nodes -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem \ -subj "/C=CN/ST=GD/L=SZ/O=vihoo/OU=dev/CN=xx.com/emailAddress=yy@xx.com" KEY_ID=`openssl pkcs8 -in key.pem -topk8 -nocrypt -outform DER | keyctl \ padd asymmetric 123 @s` keyctl pkey_sign $KEY_ID 0 $RAWDATA enc=pkcs1 hash=sha1 > $SIGDATA keyctl pkey_verify $KEY_ID 0 $RAWDATA $SIGDATA enc=pkcs1 hash=sha1 Then the kernel reports: WARNING: CPU: 5 PID: 344556 at crypto/rsa-pkcs1pad.c:540 pkcs1pad_verify+0x160/0x190 ... Call Trace: public_key_verify_signature+0x282/0x380 ? software_key_query+0x12d/0x180 ? keyctl_pkey_params_get+0xd6/0x130 asymmetric_key_verify_signature+0x66/0x80 keyctl_pkey_verify+0xa5/0x100 do_syscall_64+0x35/0xb0 entry_SYSCALL_64_after_hwframe+0x44/0xae The reason of this issue, in function 'asymmetric_key_verify_signature': '.digest_size(u8) = params->in_len(u32)' leads overflow of an u8 value, so use u32 instead of u8 for digest_size field. And reorder struct public_key_signature, it saves 8 bytes on a 64-bit machine. Cc: stable@vger.kernel.org Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-09-22 12:26:21 +02:00
..
internal	crypto: shash - avoid comparing pointers to exported functions under CFI	2021-07-14 16:53:13 +02:00
acompress.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:04:05 +02:00
aead.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:04:05 +02:00
aes.h	crypto: aes - helper function to validate key length for AES algorithms	2019-08-09 15:11:43 +10:00
akcipher.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:04:05 +02:00
algapi.h	crypto: api - Remove redundant #ifdef in crypto_yield()	2019-08-02 14:45:13 +10:00
arc4.h	crypto: arc4 - refactor arc4 core code into separate library	2019-06-20 14:18:33 +08:00
asym_tpm_subtype.h	KEYS: asym_tpm: extract key size & public key [ver #2]	2018-10-26 09:30:46 +01:00
authenc.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
b128ops.h
blowfish.h
cast5.h
cast6.h	crypto: x86 - Regularize glue function prototypes	2021-03-20 10:39:47 +01:00
cast_common.h
cbc.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
chacha.h	crypto: chacha - constify ctx and iv arguments	2019-06-13 14:31:40 +08:00
cryptd.h	crypto: cryptd - remove ability to instantiate ablkciphers	2019-04-18 22:15:04 +08:00
ctr.h	crypto: ctr - add helper for performing a CTR encryption walk	2019-07-26 14:56:07 +10:00
des.h	crypto: des - remove now unused __des3_ede_setkey()	2019-08-22 14:57:33 +10:00
dh.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
drbg.h	crypto: drbg - add FIPS 140-2 CTRNG for noise source	2019-05-23 14:01:06 +08:00
ecdh.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
engine.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
gcm.h	crypto: gcm - helper functions for assoclen/authsize check	2019-08-09 15:11:41 +10:00
gf128mul.h
ghash.h	crypto: ghash - add comment and improve help text	2019-07-27 21:08:38 +10:00
hash.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:04:05 +02:00
hash_info.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
hmac.h
if_alg.h	crypto: algif_aead - Only wake up when ctx->more is zero	2020-08-21 13:05:30 +02:00
kpp.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:04:05 +02:00
md5.h
nhpoly1305.h	crypto: nhpoly1305 - add NHPoly1305 support	2018-11-20 14:26:56 +08:00
null.h	crypto: null - Remove VLA usage of skcipher	2018-09-28 12:46:08 +08:00
padlock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
pcrypt.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335	2019-06-05 17:37:06 +02:00
pkcs7.h	PKCS#7: Introduce pkcs7_get_digest()	2019-08-05 18:40:19 -04:00
poly1305.h	crypto: poly1305 - add Poly1305 core API	2018-11-20 14:26:56 +08:00
public_key.h	crypto: public_key: fix overflow during implicit conversion	2021-09-22 12:26:21 +02:00
rng.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:04:05 +02:00
scatterwalk.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
serpent.h	crypto: x86 - Regularize glue function prototypes	2021-03-20 10:39:47 +01:00
sha.h	crypto: sha256 - Remove sha256/224_init code duplication	2019-09-05 14:54:54 +10:00
sha1_base.h	crypto: add header include guards	2019-08-02 14:44:02 +10:00
sha3.h	crypto: sha3-generic - export init/update/final routines	2018-01-26 01:10:34 +11:00
sha256_base.h	crypto: sha256 - Remove sha256/224_init code duplication	2019-09-05 14:54:54 +10:00
sha512_base.h	crypto: add header include guards	2019-08-02 14:44:02 +10:00
skcipher.h	crypto: api - check for ERR pointers in crypto_destroy_tfm()	2021-05-11 14:04:05 +02:00
sm3.h
sm3_base.h	crypto: add header include guards	2019-08-02 14:44:02 +10:00
sm4.h	crypto: sm4 - export encrypt/decrypt routines to other drivers	2018-05-05 14:52:51 +08:00
streebog.h	crypto: streebog - fix unaligned memory accesses	2019-04-08 14:42:55 +08:00
twofish.h
xts.h	crypto: x86 - Regularize glue function prototypes	2021-03-20 10:39:47 +01:00