Zhou Qingyang
df14d2bed8
spi: spi-zynq-qspi: Fix a NULL pointer dereference in zynq_qspi_exec_mem_op()
...
[ Upstream commit ab3824427b848da10e9fe2727f035bbeecae6ff4 ]
In zynq_qspi_exec_mem_op(), kzalloc() is directly used in memset(),
which could lead to a NULL pointer dereference on failure of
kzalloc().
Fix this bug by adding a check of tmpbuf.
This bug was found by a static analyzer. The analysis employs
differential checking to identify inconsistent security operations
(e.g., checks or kfrees) between two code paths and confirms that the
inconsistent operations are not recovered in the current function or
the callers, so they constitute bugs.
Note that, as a bug found by static analysis, it can be a false
positive or hard to trigger. Multiple researchers have cross-reviewed
the bug.
Builds with CONFIG_SPI_ZYNQ_QSPI=m show no new warnings,
and our static analyzer no longer warns about this code.
Fixes: 67dca5e580 ("spi: spi-mem: Add support for Zynq QSPI controller")
Signed-off-by: Zhou Qingyang <zhou1615@umn.edu>
Link: https://lore.kernel.org/r/20211130172253.203700-1-zhou1615@umn.edu
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-03-02 11:41:10 +01:00
..
atmel-quadspi.c
internals.h
Kconfig
Makefile
spi-altera.c
spi-armada-3700.c
spi: change clk_disable_unprepare to clk_unprepare
2021-12-29 12:23:34 +01:00
spi-at91-usart.c
spi-ath79.c
spi: ath79: remove spi-master setup and cleanup assignment
2021-05-11 14:04:05 +02:00
spi-atmel.c
spi-au1550.c
spi-axi-spi-engine.c
spi-bcm-qspi.c
spi: bcm-qspi: check for valid cs before applying chip select
2022-02-08 18:24:30 +01:00
spi-bcm-qspi.h
spi-bcm63xx-hsspi.c
spi-bcm63xx.c
spi-bcm2835.c
spi: bcm2835: Fix out-of-bounds access with more than 4 slaves
2021-06-16 11:59:39 +02:00
spi-bcm2835aux.c
spi-bitbang-txrx.h
spi-bitbang.c
spi: Cleanup on failure of initial setup
2021-06-16 11:59:38 +02:00
spi-brcmstb-qspi.c
spi-butterfly.c
spi-cadence.c
spi: cadence: Correct initialisation of runtime PM again
2021-07-28 13:30:56 +02:00
spi-cavium-octeon.c
spi-cavium-thunderx.c
spi-cavium.c
spi-cavium.h
spi-clps711x.c
spi-coldfire-qspi.c
spi-davinci.c
spi-dln2.c
spi: dln2: Fix reference leak to master
2021-05-11 14:04:06 +02:00
spi-dw-mid.c
spi-dw-mmio.c
spi-dw-pci.c
spi-dw.c
spi-dw.h
spi-efm32.c
spi-ep93xx.c
spi-falcon.c
spi-fsl-cpm.c
spi-fsl-cpm.h
spi-fsl-dspi.c
spi: spi-fsl-dspi: Fix issue with uninitialized dma_slave_config
2021-09-15 09:47:29 +02:00
spi-fsl-espi.c
spi-fsl-lib.c
spi-fsl-lib.h
spi-fsl-lpspi.c
spi: fsl-lpspi: Fix PM reference leak in lpspi_prepare_xfer_hardware()
2021-05-14 09:44:21 +02:00
spi-fsl-qspi.c
spi-fsl-spi.c
spi: Cleanup on failure of initial setup
2021-06-16 11:59:38 +02:00
spi-fsl-spi.h
spi-geni-qcom.c
spi: spi-geni-qcom: Fix use-after-free on unbind
2021-06-03 08:59:06 +02:00
spi-gpio.c
spi-img-spfi.c
spi-imx.c
spi: imx: mx51-ecspi: Fix low-speed CONFIGREG delay calculation
2021-08-12 13:20:56 +02:00
spi-iproc-qspi.c
spi-jcore.c
spi-lantiq-ssc.c
spi-lm70llp.c
spi-loopback-test.c
spi: spi-loopback-test: Fix 'tx_buf' might be 'rx_buf'
2021-07-14 16:53:10 +02:00
spi-lp8841-rtc.c
spi-mem.c
spi-meson-spicc.c
spi: meson-spicc: add IRQ check in meson_spicc_probe
2022-02-08 18:24:30 +01:00
spi-meson-spifc.c
spi: spi-meson-spifc: Add missing pm_runtime_disable() in meson_spifc_probe
2022-01-27 09:19:37 +01:00
spi-mpc52xx-psc.c
spi-mpc52xx.c
spi-mpc512x-psc.c
spi-mt65xx.c
spi: mediatek: Avoid NULL pointer crash in interrupt
2022-02-08 18:24:30 +01:00
spi-mt7621.c
spi-mxic.c
spi-mxs.c
spi-npcm-fiu.c
spi-npcm-pspi.c
spi-nxp-fspi.c
spi: spi-nxp-fspi: move the register operation after the clock enable
2021-06-30 08:47:44 -04:00
spi-oc-tiny.c
spi-omap-100k.c
spi: omap-100k: Fix the length judgment problem
2021-07-14 16:53:10 +02:00
spi-omap-uwire.c
spi: Cleanup on failure of initial setup
2021-06-16 11:59:38 +02:00
spi-omap2-mcspi.c
spi: Cleanup on failure of initial setup
2021-06-16 11:59:38 +02:00
spi-orion.c
spi-pic32-sqi.c
spi-pic32.c
spi: spi-pic32: Fix issue with uninitialized dma_slave_config
2021-09-15 09:47:29 +02:00
spi-pl022.c
spi: spl022: fix Microwire full duplex mode
2021-11-17 09:48:21 +01:00
spi-ppc4xx.c
spi-pxa2xx-dma.c
spi-pxa2xx-pci.c
spi-pxa2xx.c
spi: Cleanup on failure of initial setup
2021-06-16 11:59:38 +02:00
spi-pxa2xx.h
spi-qcom-qspi.c
spi-qup.c
spi: qup: fix PM reference leak in spi_qup_remove()
2021-05-11 14:04:06 +02:00
spi-rb4xx.c
spi-rockchip.c
spi-rspi.c
spi-s3c24xx-fiq.h
spi-s3c24xx-fiq.S
spi-s3c24xx.c
spi-s3c64xx.c
spi-sc18is602.c
spi-sh-hspi.c
spi-sh-msiof.c
spi-sh-sci.c
spi-sh.c
spi-sifive.c
spi-sirf.c
spi-slave-mt27xx.c
spi-slave-system-control.c
spi-slave-time.c
spi-sprd-adi.c
spi: sprd: Fix the wrong WDG_LOAD_VAL
2021-09-15 09:47:30 +02:00
spi-sprd.c
spi: sprd: Add missing MODULE_DEVICE_TABLE
2021-06-16 11:59:34 +02:00
spi-st-ssc4.c
spi-stm32-qspi.c
spi: stm32-qspi: Always wait BUSY bit to be cleared in stm32_qspi_wait_cmd()
2021-06-23 14:41:27 +02:00
spi-stm32.c
spi: stm32h7: fix full duplex irq handler handling
2021-08-08 09:04:07 +02:00
spi-sun4i.c
spi-sun6i.c
spi: spi-sun6i: Fix chipselect/clock bug
2021-07-14 16:53:24 +02:00
spi-synquacer.c
spi-tegra20-sflash.c
spi-tegra20-slink.c
spi: Fix tegra20 build with CONFIG_PM=n
2021-09-30 10:09:26 +02:00
spi-tegra114.c
spi-test.h
spi-ti-qspi.c
spi: spi-ti-qspi: Free DMA resources
2021-05-11 14:04:02 +02:00
spi-tle62x0.c
spi-topcliff-pch.c
spi: spi-topcliff-pch: Fix potential double free in pch_spi_process_messages()
2021-07-14 16:53:10 +02:00
spi-txx9.c
spi-uniphier.c
spi-xcomm.c
spi-xilinx.c
spi-xlp.c
spi-xtensa-xtfpga.c
spi-zynq-qspi.c
spi: spi-zynq-qspi: Fix a NULL pointer dereference in zynq_qspi_exec_mem_op()
2022-03-02 11:41:10 +01:00
spi-zynqmp-gqspi.c
spi.c
spi: Make of_register_spi_device also set the fwnode
2021-07-14 16:53:09 +02:00
spidev.c