Christian Brauner
7f2923c4f7
sysctl: handle overflow in proc_get_long ...
proc_get_long() is a funny function. It uses simple_strtoul() and for a
good reason. proc_get_long() wants to always succeed the parse and
return the maybe incorrect value and the trailing characters to check
against a pre-defined list of acceptable trailing values. However,
simple_strtoul() explicitly ignores overflows which can cause funny
things like the following to happen:
echo 18446744073709551616 > /proc/sys/fs/file-max
cat /proc/sys/fs/file-max
0
(Which will cause your system to silently die behind your back.)
On the other hand kstrtoul() does do overflow detection but does not
return the trailing characters, and also fails the parse when anything
other than '\n' is a trailing character whereas proc_get_long() wants to
be more lenient.
Now, before adding another kstrtoul() function let's simply add a static
parse strtoul_lenient() which:
- fails on overflow with -ERANGE
- returns the trailing characters to the caller
The reason why we should fail on ERANGE is that we already do a partial
fail on overflow right now. Namely, when the TMPBUFLEN is exceeded. So
we already reject values such as 184467440737095516160 (21 chars) but
accept values such as 18446744073709551616 (20 chars) but both are
overflows. So we should just always reject 64bit overflows and not
special-case this based on the number of chars.
Link: http://lkml.kernel.org/r/20190107222700.15954-2-christian@brauner.io
Signed-off-by: Christian Brauner <christian@brauner.io>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Waiman Long <longman@redhat.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-03-07 18:32:02 -08:00
Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-03-06 07:59:36 -08:00
kernel: cgroup: add poll file operation
2019-03-05 21:07:17 -08:00
kvm_config: add CONFIG_VIRTIO_MENU
2018-10-24 20:55:56 -04:00
kdb: use bool for binary state indicators
2018-12-30 08:31:52 +00:00
swiotlb: clear io_tlb_start and io_tlb_end in swiotlb_exit
2019-01-16 09:59:17 -05:00
perf/core improvements and fixes:
2019-02-28 08:29:50 +01:00
irqchip updates for Linux 5.1
2019-02-23 10:53:31 +01:00
livepatch: Replace synchronize_sched() with synchronize_rcu()
2018-12-01 12:38:50 -08:00
Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-03-06 07:59:36 -08:00
Power management updates for 5.1-rc1
2019-03-06 12:59:46 -08:00
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-03-06 07:59:36 -08:00
Merge branch 'akpm' (patches from Andrew)
2019-03-06 10:31:36 -08:00
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-03-05 14:49:11 -08:00
Merge branch 'linus' into perf/core, to pick up fixes
2019-02-28 08:27:17 +01:00
async: Add support for queueing on specific NUMA node
2019-01-31 14:20:54 +01:00
audit: remove duplicated include from audit.c
2018-12-14 12:09:30 -05:00
audit: use current whenever possible
2018-11-26 18:41:21 -05:00
audit: minimize our use of audit_log_format()
2018-11-26 18:40:00 -05:00
audit: minimize our use of audit_log_format()
2018-11-26 18:40:00 -05:00
audit: minimize our use of audit_log_format()
2018-11-26 18:40:00 -05:00
audit: use current whenever possible
2018-11-26 18:41:21 -05:00
kbuild: fix kernel/bounds.c 'W=1' warning
2018-10-31 08:54:14 -07:00
time: make adjtime compat handling available for 32 bit
2019-02-07 00:13:27 +01:00
Linux 5.0-rc5
2019-02-04 08:57:24 +01:00
kexec: export PG_offline to VMCOREINFO
2019-03-05 21:07:14 -08:00
cred: export get_task_cred().
2018-12-19 13:52:44 -05:00
delayacct: track delays from thrashing cache pages
2018-10-26 16:26:32 -07:00
kernel/exit.c: release ptraced tasks before zap_pid_ns_processes
2019-02-01 15:46:23 -08:00
kernel/fail_function.c: remove meaningless null pointer check before debugfs_remove_recursive
2018-10-31 08:54:12 -07:00
sched/core: Convert task_struct.stack_refcount to refcount_t
2019-02-04 08:53:56 +01:00
PM / reboot: Eliminate race between reboot and suspend
2018-08-06 12:35:20 +02:00
Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-03-06 07:17:17 -08:00
kernel/hung_task.c: Use continuously blocked time when reporting.
2019-03-07 18:31:59 -08:00
jump_label: move 'asm goto' support test to Kconfig
2019-01-06 09:46:51 +09:00
bpf: Add module name [bpf] to ksymbols for bpf programs
2019-01-21 17:38:56 -03:00
bpf: introduce bpf_spin_lock
2019-02-01 20:55:38 +01:00
kconfig: warn no new line at end of file
2018-12-15 17:44:35 +09:00
kernel/kcov.c: mark write_comp_data() as notrace
2019-01-04 13:13:47 -08:00
kexec: add call to LSM hook in original kexec_load syscall
2018-07-16 12:31:57 -07:00
mm: convert totalram_pages and totalhigh_pages variables to atomic
2018-12-28 12:11:47 -08:00
kexec_file: kexec_walk_memblock() only walks a dedicated region at kdump
2018-12-06 14:38:50 +00:00
kprobes: Search non-suffixed symbol in blacklist
2019-02-13 08:16:40 +01:00
Merge branch 'akpm' (patches from Andrew)
2019-03-06 10:31:36 -08:00
kbuild: change filechk to surround the given command with { }
2019-01-06 09:46:51 +09:00
mm/hmm: fix memremap.h, move dev_page_fault_t callback to hmm
2018-12-28 12:11:52 -08:00
dynamic_debug: add static inline stub for ddebug_add_module
2019-03-07 18:32:00 -08:00
modsign: use all trusted keys to verify module signature
2018-11-07 14:41:41 +01:00
padata: clean an indentation issue, remove extraneous space
2018-11-16 14:11:04 +08:00
kernel/panic.c: taint: fix debugfs_simple_attr.cocci warnings
2019-03-07 18:31:59 -08:00
Fix failure path in alloc_pid()
2018-12-28 12:42:30 -08:00
signal: Use group_send_sig_info to kill all processes in a pid namespace
2018-09-16 16:08:25 +02:00
mm: remove include/linux/bootmem.h
2018-10-31 08:54:16 -07:00
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
kernel/reboot.c: export pm_power_off_prepare
2018-09-11 16:13:24 +01:00
relay: check return of create_buf_file() properly
2019-01-31 14:01:48 +01:00
kernel, resource: check for IORESOURCE_SYSRAM in release_mem_region_adjustable
2018-12-28 12:11:49 -08:00
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
seccomp, bpf: disable preemption before calling into bpf prog
2019-02-22 00:14:19 +01:00
Merge branch 'timers-2038-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-03-05 14:08:26 -08:00
cpu/hotplug: Fix "SMT disabled by BIOS" detection for KVM
2019-01-30 19:27:00 +01:00
softirq: Don't skip softirq execution when softirq thread is parking
2019-02-10 21:51:39 +01:00
stackleak: Mark stackleak_track_stack() as notrace
2018-12-05 19:31:44 -08:00
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2018-08-13 11:25:07 -07:00
kernel/sys: annotate implicit fall through
2019-03-07 18:31:59 -08:00
ipc: Fix building compat mode without sysvipc
2019-03-06 16:00:56 +01:00
sysctl: handle overflow in proc_get_long
2019-03-07 18:32:02 -08:00
kernel/sysctl: add panic_print into sysctl
2019-01-04 13:13:47 -08:00
Merge branches 'doc.2019.01.26a', 'fixes.2019.01.26a', 'sil.2019.01.26a', 'spdx.2019.02.09a', 'srcu.2019.01.26a' and 'torture.2019.01.26a' into HEAD
2019-02-09 08:47:52 -08:00
tracing: Replace synchronize_sched() and call_rcu_sched()
2018-11-27 09:21:41 -08:00
umh: add exit routine for UMH process
2019-01-11 18:05:40 -08:00
smp,cpumask: introduce on_each_cpu_cond_mask
2018-10-09 16:51:11 +02:00
userns: use irqsave variant of refcount_dec_and_lock()
2018-08-22 10:52:47 -07:00
userns: also map extents in the reverse map to kernel IDs
2018-11-07 23:51:16 -06:00
sys: don't hold uts_sem while accessing userspace memory
2018-08-11 02:05:53 -05:00
watchdog: Mark watchdog touch functions as notrace
2018-08-30 12:56:40 +02:00
watchdog: Mark watchdog touch functions as notrace
2018-08-30 12:56:40 +02:00
kernel: workqueue: clarify wq_worker_last_func() caller requirements
2019-03-07 18:32:01 -08:00
psi: fix aggregation idle shut-off
2019-02-01 15:46:23 -08:00
7f2923c4f7