Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Shung-Hsi Yu bae6905103 bpf: Fix precision tracking for BPF_ALU | BPF_TO_BE | BPF_END ... commit 291d044fd51f8484066300ee42afecf8c8db7b3a upstream. BPF_END and BPF_NEG has a different specification for the source bit in the opcode compared to other ALU/ALU64 instructions, and is either reserved or use to specify the byte swap endianness. In both cases the source bit does not encode source operand location, and src_reg is a reserved field. backtrack_insn() currently does not differentiate BPF_END and BPF_NEG from other ALU/ALU64 instructions, which leads to r0 being incorrectly marked as precise when processing BPF_ALU | BPF_TO_BE | BPF_END instructions. This commit teaches backtrack_insn() to correctly mark precision for such case. While precise tracking of BPF_NEG and other BPF_END instructions are correct and does not need fixing, this commit opt to process all BPF_NEG and BPF_END instructions within the same if-clause to better align with current convention used in the verifier (e.g. check_alu_op). Fixes: b5dc0163d8 ("bpf: precise scalar_value tracking") Cc: stable@vger.kernel.org Reported-by: Mohamed Mahmoud <mmahmoud@redhat.com> Closes: https://lore.kernel.org/r/87jzrrwptf.fsf@toke.dk Tested-by: Toke Høiland-Jørgensen <toke@redhat.com> Tested-by: Tao Lyu <tao.lyu@epfl.ch> Acked-by: Eduard Zingerman <eddyz87@gmail.com> Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@suse.com> Link: https://lore.kernel.org/r/20231102053913.12004-2-shung-hsi.yu@suse.com Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-11-28 16:50:18 +00:00
..
arraymap.c
bpf_lru_list.c	bpf: Address KCSAN report on bpf_lru_list	2023-07-27 08:37:42 +02:00
bpf_lru_list.h	bpf: Address KCSAN report on bpf_lru_list	2023-07-27 08:37:42 +02:00
btf.c	btf: fix resolving BTF_KIND_VAR after ARRAY, STRUCT, UNION, PTR	2023-03-17 08:32:51 +01:00
cgroup.c	bpf: Don't EFAULT for getsockopt with optval=NULL	2023-05-17 11:35:44 +02:00
core.c	bpf: Adjust insufficient default bpf_jit_limit	2023-04-05 11:16:37 +02:00
cpumap.c
devmap.c
disasm.c
disasm.h
hashtab.c
helpers.c
inode.c
local_storage.c
lpm_trie.c
Makefile
map_in_map.c
map_in_map.h
offload.c
percpu_freelist.c
percpu_freelist.h
queue_stack_maps.c	bpf: Avoid deadlock when using queue and stack maps from NMI	2023-10-10 21:46:36 +02:00
reuseport_array.c
stackmap.c
syscall.c	bpf: Ensure correct locking around vulnerable function find_vpid()	2022-10-26 13:22:24 +02:00
sysfs_btf.c
tnum.c
verifier.c	bpf: Fix precision tracking for BPF_ALU | BPF_TO_BE | BPF_END	2023-11-28 16:50:18 +00:00
xskmap.c