Ard Biesheuvel
3e04040df6
Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"
...
This reverts commit 864b75f9d6 .
Commit 864b75f9d6 ("mm/page_alloc: fix memmap_init_zone pageblock
alignment") modified the logic in memmap_init_zone() to initialize
struct pages associated with invalid PFNs, to appease a VM_BUG_ON()
in move_freepages(), which is redundant by its own admission, and
dereferences struct page fields to obtain the zone without checking
whether the struct pages in question are valid to begin with.
Commit 864b75f9d6 only makes it worse, since the rounding it does
may cause pfn assume the same value it had in a prior iteration of
the loop, resulting in an infinite loop and a hang very early in the
boot. Also, since it doesn't perform the same rounding on start_pfn
itself but only on intermediate values following an invalid PFN, we
may still hit the same VM_BUG_ON() as before.
So instead, let's fix this at the core, and ensure that the BUG
check doesn't dereference struct page fields of invalid pages.
Fixes: 864b75f9d6 ("mm/page_alloc: fix memmap_init_zone pageblock alignment")
Tested-by: Jan Glauber <jglauber@cavium.com>
Tested-by: Shanker Donthineni <shankerd@codeaurora.org>
Cc: Daniel Vacek <neelx@redhat.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-03-14 16:33:28 -07:00
..
kasan
kasan: fix prototype author email address
2018-02-06 18:32:43 -08:00
backing-dev.c
Revert "bdi: add error handle for bdi_debug_register"
2017-12-21 10:01:30 -07:00
balloon_compaction.c
bootmem.c
mm: docs: fix parameter names mismatch
2018-02-06 18:32:48 -08:00
cleancache.c
cma.c
mm/cma.c: change pr_info to pr_err for cma_alloc fail log
2017-11-15 18:21:03 -08:00
cma.h
cma_debug.c
compaction.c
mm/compaction.c: fix comment for try_to_compact_pages()
2018-01-31 17:18:39 -08:00
debug.c
mm/debug.c: provide useful debugging information for VM_BUG
2018-01-04 16:45:09 -08:00
debug_page_ref.c
dmapool.c
early_ioremap.c
mm/early_ioremap: Fix boot hang with earlyprintk=efi,keep
2017-12-11 14:54:44 +01:00
fadvise.c
mm/fadvise: discard partial page if endbyte is also EOF
2018-01-31 17:18:39 -08:00
failslab.c
filemap.c
mm/filemap.c: remove include of hardirq.h
2018-01-31 17:18:36 -08:00
frame_vector.c
mm/frame_vector.c: release a semaphore in 'get_vaddr_frames()'
2017-12-14 16:00:48 -08:00
frontswap.c
gup.c
mm/gup.c: teach get_user_pages_unlocked to handle FOLL_NOWAIT
2018-03-09 16:40:01 -08:00
gup_benchmark.c
mm: add infrastructure for get_user_pages_fast() benchmarking
2017-11-17 16:10:04 -08:00
highmem.c
hmm.c
libnvdimm for 4.16
2018-02-06 10:41:33 -08:00
huge_memory.c
mm/thp: remove pmd_huge_split_prepare()
2018-01-31 17:18:38 -08:00
hugetlb.c
hugetlb: fix surplus pages accounting
2018-03-09 16:40:01 -08:00
hugetlb_cgroup.c
hwpoison-inject.c
mm/memory_failure: Remove unused trapno from memory_failure
2018-01-23 12:17:42 -06:00
init-mm.c
internal.h
Revert "mm, thp: Do not make pmd/pud dirty without a reason"
2017-11-29 09:01:01 -08:00
interval_tree.c
mm/interval_tree.c: use vma_pages() helper
2018-01-31 17:18:37 -08:00
Kconfig
mm: relax deferred struct page requirements
2018-01-31 17:18:36 -08:00
Kconfig.debug
kmemcheck: rip it out
2017-11-15 18:21:05 -08:00
khugepaged.c
mm: thp: use down_read_trylock() in khugepaged to avoid long block
2018-01-31 17:18:38 -08:00
kmemleak-test.c
kmemleak.c
mm: kmemleak: remove unused hardirq.h
2018-01-31 17:18:36 -08:00
ksm.c
mm: docs: fixup punctuation
2018-02-06 18:32:48 -08:00
list_lru.c
mm/list_lru.c: mark expected switch fall-through
2017-11-15 18:21:07 -08:00
maccess.c
mm: docs: fix parameter names mismatch
2018-02-06 18:32:48 -08:00
madvise.c
mm/memory_failure: Remove unused trapno from memory_failure
2018-01-23 12:17:42 -06:00
Makefile
mm: add infrastructure for get_user_pages_fast() benchmarking
2017-11-17 16:10:04 -08:00
memblock.c
mm/memblock.c: hardcode the end_pfn being -1
2018-03-09 16:40:01 -08:00
memcontrol.c
vfs: do bulk POLL* -> EPOLL* replacement
2018-02-11 14:34:03 -08:00
memory-failure.c
x86/mm, mm/hwpoison: Don't unconditionally unmap kernel 1:1 pages
2018-02-13 16:25:06 +01:00
memory.c
mm: hide a #warning for COMPILE_TEST
2018-02-16 09:41:36 -08:00
memory_hotplug.c
libnvdimm for 4.16
2018-02-06 10:41:33 -08:00
mempolicy.c
hugetlb, mbind: fall back to default policy if vma is NULL
2018-01-31 17:18:40 -08:00
mempool.c
kasan: detect invalid frees for large mempool objects
2018-02-06 18:32:43 -08:00
memtest.c
migrate.c
mm, hugetlb: do not rely on overcommit limit during migration
2018-01-31 17:18:40 -08:00
mincore.c
mlock.c
mm, mlock, vmscan: no more skipping pagevecs
2018-02-21 15:35:42 -08:00
mm_init.c
mmap.c
mm, oom_reaper: fix memory corruption
2017-12-14 16:00:49 -08:00
mmu_context.c
mmu_notifier.c
mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks
2018-01-31 17:18:38 -08:00
mmzone.c
mprotect.c
mm: numa: do not trap faults on shared data section pages.
2018-01-31 17:18:40 -08:00
mremap.c
msync.c
nobootmem.c
nommu.c
mm: docs: fixup punctuation
2018-02-06 18:32:48 -08:00
oom_kill.c
mm, oom: avoid reaping only for mm's with blockable invalidate callbacks
2018-01-31 17:18:38 -08:00
page-writeback.c
Revert "mm/page-writeback.c: print a warning if the vm dirtiness settings are illogical"
2017-11-29 18:40:43 -08:00
page_alloc.c
Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"
2018-03-14 16:33:28 -07:00
page_counter.c
page_ext.c
mm/page_ext.c: make page_ext_init a noop when CONFIG_PAGE_EXTENSION but nothing uses it
2018-01-31 17:18:39 -08:00
page_idle.c
page_io.c
block: convert to bio_first_bvec_all & bio_first_page_all
2018-01-06 09:18:00 -07:00
page_isolation.c
mm: distinguish CMA and MOVABLE isolation in has_unmovable_pages()
2017-11-15 18:21:02 -08:00
page_owner.c
mm/page_owner.c: clean up init_pages_in_zone()
2018-01-31 17:18:39 -08:00
page_poison.c
page_vma_mapped.c
mm, page_vma_mapped: Introduce pfn_in_hpage()
2018-01-22 12:15:57 -08:00
pagewalk.c
mm: docs: add blank lines to silence sphinx "Unexpected indentation" errors
2018-02-06 18:32:48 -08:00
percpu-internal.h
percpu-km.c
percpu-stats.c
percpu-vm.c
mm: remove __GFP_COLD
2017-11-15 18:21:06 -08:00
percpu.c
percpu: hack to let the CRIS architecture to boot until they clean up
2017-11-27 12:53:12 -08:00
pgtable-generic.c
mm: do not lose dirty and accessed bits in pmdp_invalidate()
2018-01-31 17:18:38 -08:00
process_vm_access.c
mm: docs: add blank lines to silence sphinx "Unexpected indentation" errors
2018-02-06 18:32:48 -08:00
quicklist.c
readahead.c
rmap.c
mm: remove cold parameter from free_hot_cold_page*
2017-11-15 18:21:06 -08:00
rodata_test.c
shmem.c
shmem: add sealing support to hugetlb-backed memfd
2018-01-31 17:18:39 -08:00
slab.c
kasan: don't use __builtin_return_address(1)
2018-02-06 18:32:43 -08:00
slab.h
Currently, hardened usercopy performs dynamic bounds checking on slab
2018-02-03 16:25:42 -08:00
slab_common.c
Currently, hardened usercopy performs dynamic bounds checking on slab
2018-02-03 16:25:42 -08:00
slob.c
slab, slub, slob: add slab_flags_t
2017-11-15 18:21:01 -08:00
slub.c
kasan: don't use __builtin_return_address(1)
2018-02-06 18:32:43 -08:00
sparse-vmemmap.c
mm: merge vmem_altmap_alloc into altmap_alloc_block_buf
2018-01-08 11:46:23 -08:00
sparse.c
libnvdimm for 4.16
2018-02-06 10:41:33 -08:00
swap.c
mm/swap.c: make functions and their kernel-doc agree (again)
2018-02-21 15:35:43 -08:00
swap_cgroup.c
swap_slots.c
mm/swap_slots.c: fix race conditions in swap_slots cache init
2017-11-15 18:21:03 -08:00
swap_state.c
mm: remove cold parameter for release_pages
2017-11-15 18:21:06 -08:00
swapfile.c
vfs: do bulk POLL* -> EPOLL* replacement
2018-02-11 14:34:03 -08:00
truncate.c
mm: add unmap_mapping_pages()
2018-01-31 17:18:37 -08:00
usercopy.c
usercopy: WARN() on slab cache usercopy region violations
2018-01-15 12:07:48 -08:00
userfaultfd.c
mm/userfaultfd.c: remove duplicate include
2018-02-06 18:32:47 -08:00
util.c
new primitive: vmemdup_user()
2018-01-07 13:06:15 -05:00
vmacache.c
vmalloc.c
vmalloc: fix __GFP_HIGHMEM usage for vmalloc_32 on 32b systems
2018-02-21 15:35:43 -08:00
vmpressure.c
vmscan.c
mm, mlock, vmscan: no more skipping pagevecs
2018-02-21 15:35:42 -08:00
vmstat.c
mm, sysctl: make NUMA stats configurable
2017-11-15 18:21:07 -08:00
workingset.c
mm, truncate: do not check mapping for every page being truncated
2017-11-15 18:21:06 -08:00
z3fold.c
mm: docs: fix parameter names mismatch
2018-02-06 18:32:48 -08:00
zbud.c
mm: docs: fix parameter names mismatch
2018-02-06 18:32:48 -08:00
zpool.c
mm/zpool.c: zpool_evictable: fix mismatch in parameter name and kernel-doc
2018-02-21 15:35:43 -08:00
zsmalloc.c
zsmalloc: use U suffix for negative literals being shifted
2018-01-31 17:18:39 -08:00
zswap.c
mm, swap, frontswap: fix THP swap if frontswap enabled
2018-02-21 15:35:43 -08:00