Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Oleg Nesterov 8a6b173287 uprobes: Kill UPROBE_SKIP_SSTEP and can_skip_sstep() ... UPROBE_COPY_INSN, UPROBE_SKIP_SSTEP, and uprobe->flags must die. This patch kills UPROBE_SKIP_SSTEP. I never understood why it was added; not only it doesn't help, it harms. It can only help to avoid arch_uprobe_skip_sstep() if it was already called before and failed. But this is ugly, if we want to know whether we can emulate this instruction or not we should do this analysis in arch_uprobe_analyze_insn(), not when we hit this probe for the first time. And in fact this logic is simply wrong. arch_uprobe_skip_sstep() can fail or not depending on the task/register state, if this insn can be emulated but, say, put_user() fails we need to xol it this time, but this doesn't mean we shouldn't try to emulate it when this or another thread hits this bp next time. And this is the actual reason for this change. We need to emulate the "call" insn, but push(return-address) can obviously fail. Per-arch notes: x86: __skip_sstep() can only emulate "rep;nop". With this change it will be called every time and most probably for no reason. This will be fixed by the next changes. We need to change this suboptimal code anyway. arm: Should not be affected. It has its own "bool simulate" flag checked in arch_uprobe_skip_sstep(). ppc: Looks like, it can emulate almost everything. Does it actually need to record the fact that emulate_step() failed? Hopefully not. But if yes, it can add the ppc- specific flag into arch_uprobe. TODO: rename arch_uprobe_skip_sstep() to arch_uprobe_emulate_insn(), Signed-off-by: Oleg Nesterov <oleg@redhat.com> Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Reviewed-by: David A. Long <dave.long@linaro.org> Reviewed-by: Jim Keniston <jkenisto@us.ibm.com> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>		2014-04-17 21:58:16 +02:00
..
debug	mm: per-thread vma caching	2014-04-07 16:35:53 -07:00
events	uprobes: Kill UPROBE_SKIP_SSTEP and can_skip_sstep()	2014-04-17 21:58:16 +02:00
gcov
irq	genirq: Export symbol no_action()	2014-03-22 11:33:09 +01:00
locking	lglock: map to spinlock when !CONFIG_SMP	2014-04-07 16:36:14 -07:00
power	kernel: use macros from compiler.h instead of __attribute__((...))	2014-04-07 16:36:11 -07:00
printk	printk: fix one circular lockdep warning about console_lock	2014-04-03 16:21:08 -07:00
rcu	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-03-31 11:21:19 -07:00
sched	Merge branch 'akpm' (incoming from Andrew)	2014-04-07 16:38:06 -07:00
time	kernel: use macros from compiler.h instead of __attribute__((...))	2014-04-07 16:36:11 -07:00
trace	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-04-12 14:49:50 -07:00
.gitignore
acct.c
async.c
audit.c	Merge git://git.infradead.org/users/eparis/audit	2014-04-12 12:38:53 -07:00
audit.h	audit: Use struct net not pid_t to remember the network namespce to reply in	2014-03-20 10:10:53 -04:00
audit_tree.c
audit_watch.c
auditfilter.c	Merge git://git.infradead.org/users/eparis/audit	2014-04-12 12:38:53 -07:00
auditsc.c	Merge git://git.infradead.org/users/eparis/audit	2014-04-12 12:38:53 -07:00
backtracetest.c
bounds.c
capability.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2014-04-03 09:26:18 -07:00
cgroup.c	cgroup: newly created dirs and files should be owned by the creator	2014-04-07 16:44:47 -04:00
cgroup_freezer.c	cgroup: drop const from @buffer of cftype->write_string()	2014-03-19 10:23:54 -04:00
compat.c	Merge branch 'x86-x32-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-04-02 12:51:41 -07:00
configs.c
context_tracking.c
cpu.c	CPU hotplug: Provide lockless versions of callback registration functions	2014-03-20 13:43:40 +01:00
cpu_pm.c
cpuset.c	Merge branch 'akpm' (incoming from Andrew)	2014-04-03 16:22:16 -07:00
crash_dump.c
cred.c
delayacct.c
dma.c
elfcore.c
exec_domain.c
exit.c	wait: WSTOPPED|WCONTINUED doesn't work if a zombie leader is traced by another process	2014-04-07 16:36:06 -07:00
extable.c
fork.c	kernel: use macros from compiler.h instead of __attribute__((...))	2014-04-07 16:36:11 -07:00
freezer.c
futex.c	futex: update documentation for ordering guarantees	2014-04-12 17:57:51 -07:00
futex_compat.c
groups.c	kernel/groups.c: remove return value of set_groups	2014-04-03 16:21:05 -07:00
hrtimer.c	timer: Remove code redundancy while calling get_nohz_timer_target()	2014-03-20 12:35:46 +01:00
hung_task.c	kernel: audit/fix non-modular users of module_init in core code	2014-04-03 16:21:07 -07:00
irq_work.c
itimer.c
jump_label.c
kallsyms.c	kernel: use macros from compiler.h instead of __attribute__((...))	2014-04-07 16:36:11 -07:00
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kexec.c	kernel: use macros from compiler.h instead of __attribute__((...))	2014-04-07 16:36:11 -07:00
kmod.c
kprobes.c
ksysfs.c	kernel: use macros from compiler.h instead of __attribute__((...))	2014-04-07 16:36:11 -07:00
kthread.c	kthread: ensure locality of task_struct allocations	2014-04-03 16:20:49 -07:00
latencytop.c
Makefile	Merge branch 'x86-asmlinkage-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-03-31 14:13:25 -07:00
module-internal.h
module.c	modules: use raw_cpu_write for initialization of per cpu refcount.	2014-04-07 16:36:14 -07:00
module_signing.c
notifier.c	notifier: Substitute rcu_access_pointer() for rcu_dereference_raw()	2014-02-26 06:35:13 -08:00
nsproxy.c
padata.c
panic.c	kernel/panic.c: display reason at end + pr_emerg	2014-04-07 16:36:08 -07:00
params.c
pid.c
pid_namespace.c	pid_namespace: pidns_get() should check task_active_pid_ns() != NULL	2014-04-02 16:20:21 -07:00
posix-cpu-timers.c
posix-timers.c
profile.c	CPU hotplug notifiers registration fixes for 3.15-rc1	2014-04-07 14:55:46 -07:00
ptrace.c	kernel/compat: convert to COMPAT_SYSCALL_DEFINE	2014-03-06 15:35:10 +01:00
range.c
reboot.c
relay.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-04-12 14:49:50 -07:00
res_counter.c	res_counter: remove interface for locked charging and uncharging	2014-04-07 16:35:54 -07:00
resource.c	kernel/resource.c: make reallocate_resource() static	2014-04-03 16:21:07 -07:00
seccomp.c	Merge git://git.infradead.org/users/eparis/audit	2014-04-12 12:38:53 -07:00
signal.c	kernel: use macros from compiler.h instead of __attribute__((...))	2014-04-07 16:36:11 -07:00
smp.c	smp: Rename __smp_call_function_single() to smp_call_function_single_async()	2014-02-24 14:47:15 -08:00
smpboot.c
smpboot.h
softirq.c	softirq: Add linux/irq.h to make it compile again	2014-03-19 11:28:14 +01:00
stacktrace.c
stop_machine.c	stop_machine: Fix^2 race between stop_two_cpus() and stop_cpus()	2014-03-11 11:33:47 +01:00
sys.c	mm, thp: add VM_INIT_DEF_MASK and PRCTL_THP_DISABLE	2014-04-07 16:35:52 -07:00
sys_ni.c	fs, kernel: permit disabling the uselib syscall	2014-04-03 16:21:05 -07:00
sysctl.c	hung_task: check the value of "sysctl_hung_task_timeout_sec"	2014-04-07 16:36:07 -07:00
sysctl_binary.c
system_certificates.S
system_keyring.c
task_work.c
taskstats.c
test_kprobes.c
time.c
timeconst.bc
timer.c	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-04-01 11:00:07 -07:00
torture.c	rcutorture: Gracefully handle NULL cleanup hooks	2014-02-23 09:04:39 -08:00
tracepoint.c	This includes the final patch to clean up and fix the issue with the	2014-04-12 13:06:10 -07:00
tsacct.c
uid16.c
up.c	smp: Rename __smp_call_function_single() to smp_call_function_single_async()	2014-02-24 14:47:15 -08:00
user-return-notifier.c
user.c	kernel: audit/fix non-modular users of module_init in core code	2014-04-03 16:21:07 -07:00
user_namespace.c	kernel: audit/fix non-modular users of module_init in core code	2014-04-03 16:21:07 -07:00
utsname.c
utsname_sysctl.c
watchdog.c	kernel/watchdog.c: touch_nmi_watchdog should only touch local cpu not every one	2014-04-03 16:20:58 -07:00
workqueue.c	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-04-01 11:00:07 -07:00
workqueue_internal.h