Luis R. Rodriguez
8ada92799e
wait: add wait_event_killable_timeout() ...
These are the few pending fixes I have queued up for v4.13-final. One
is a a generic regression fix for recursive loops on kmod and the other
one is a trivial print out correction.
During the v4.13 development we assumed that recursive kmod loops were
no longer possible. Clearly that is not true. The regression fix makes
use of a new killable wait. We use a killable wait to be paranoid in
how signals might be sent to modprobe and only accept a proper SIGKILL.
The signal will only be available to userspace to issue *iff* a thread
has already entered a wait state, and that happens only if we've already
throttled after 50 kmod threads have been hit.
Note that although it may seem excessive to trigger a failure afer 5
seconds if all kmod thread remain busy, prior to the series of changes
that went into v4.13 we would actually *always* fatally fail any request
which came in if the limit was already reached. The new waiting
implemented in v4.13 actually gives us *more* breathing room -- the wait
for 5 seconds is a wait for *any* kmod thread to finish. We give up and
fail *iff* no kmod thread has finished and they're *all* running
straight for 5 consecutive seconds. If 50 kmod threads are running
consecutively for 5 seconds something else must be really bad.
Recursive loops with kmod are bad but they're also hard to implement
properly as a selftest without currently fooling current userspace tools
like kmod [1]. For instance kmod will complain when you run depmod if
it finds a recursive loop with symbol dependency between modules as such
this type of recursive loop cannot go upstream as the modules_install
target will fail after running depmod.
These tests already exist on userspace kmod upstream though (refer to
the testsuite/module-playground/mod-loop-*.c files). The same is not
true if request_module() is used though, or worst if aliases are used.
Likewise the issue with 64-bit kernels booting 32-bit userspace without
a binfmt handler built-in is also currently not detected and proactively
avoided by userspace kmod tools, or kconfig for all architectures.
Although we could complain in the kernel when some of these individual
recursive issues creep up, proactively avoiding these situations in
userspace at build time is what we should keep striving for.
Lastly, since recursive loops could happen with kmod it may mean
recursive loops may also be possible with other kernel usermode helpers,
this should be investigated and long term if we can come up with a more
sensible generic solution even better!
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20170809-kmod-for-v4.13-final
[1] https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git
This patch (of 3):
This wait is similar to wait_event_interruptible_timeout() but only
accepts SIGKILL interrupt signal. Other signals are ignored.
Link: http://lkml.kernel.org/r/20170809234635.13443-2-mcgrof@kernel.org
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jessica Yu <jeyu@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Michal Marek <mmarek@suse.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Miroslav Benes <mbenes@suse.cz>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: Daniel Mentz <danielmentz@google.com>
Cc: David Binderman <dcb314@hotmail.com>
Cc: Matt Redfearn <matt.redfearn@imgetc.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2017-08-18 15:32:01 -07:00
main drm pull for v4.13
2017-07-09 18:48:37 -07:00
libceph: make RECOVERY_DELETES feature create a new interval
2017-08-01 16:46:45 +02:00
libceph: fallback for when there isn't a pool-specific choose_arg
2017-08-01 16:46:44 +02:00
firmware /meson
This is the bulk of GPIO changes for the v4.13 series:
2017-07-07 12:40:27 -07:00
Merge branch 'i2c/for-4.13' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
2017-07-12 10:04:56 -07:00
First set of IIO fixes for the 4.13 cycle.
2017-07-23 20:54:31 -07:00
sunrpc: mark all struct svc_procinfo instances as const
2017-07-13 15:58:02 -04:00
chrome-platform-for-linus-4.13
2017-07-11 09:55:47 -07:00
net/mlx4_en: Fix wrong indication of Wake-on-LAN (WoL) support
2017-08-02 10:44:09 -07:00
Third set of -rc fixes for 4.13 cycle
2017-08-08 11:42:33 -07:00
mtd: nand: Declare tBERS, tR and tPROG as u64 to avoid integer overflow
2017-08-02 10:26:42 +02:00
drivers/perf: arm_pmu: Request PMU SPIs with IRQF_PER_CPU
2017-07-27 13:43:22 +01:00
pinctrl: generic: update references to Documentation/pinctrl.txt
2017-08-07 15:26:34 +02:00
staging/iio fixes for 4.13-rc5
2017-08-13 12:30:17 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
This is the big bulk of pin control changes for the v4.13 series:
2017-07-06 11:38:59 -07:00
Chuck's RDMA update overhauls the "call receive" side of the
2017-07-13 13:56:24 -07:00
USB fixes for 4.13-rc2
2017-07-22 08:55:16 -07:00
tty: pl011: fix initialization order of QDF2400 E44
2017-07-30 07:53:44 -07:00
net, atm: convert atm_dev.refcnt from atomic_t to refcount_t
2017-07-04 22:35:16 +01:00
writeback: rework wb_[dec|inc]_stat family of functions
2017-07-12 16:26:05 -07:00
bitmap: use memcmp optimisation in more situations
2017-07-10 16:32:34 -07:00
mm: zero hash tables in allocator
2017-07-06 16:24:33 -07:00
bpf: check NULL for sk_to_full_sk() return value
2017-07-17 13:37:56 -07:00
bpf: fix mixed signed/unsigned derived min/max value bounds
2017-07-20 15:20:27 -07:00
Changes for 4.13:
2017-07-10 10:51:53 -07:00
bug: split BUILD_BUG stuff out into <linux/build_bug.h>
2017-07-10 16:32:34 -07:00
bug: split BUILD_BUG stuff out into <linux/build_bug.h>
2017-07-10 16:32:34 -07:00
Small patch to add a clk_bulk_prepare_enable() and
2017-07-14 12:37:41 -07:00
Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-07-06 20:57:13 -07:00
compiler, clang: always inline when CONFIG_OPTIMIZE_INLINING is disabled
2017-07-06 16:24:29 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux
2017-07-14 13:12:32 -07:00
scsi: bnx2i: Simplify cpu hotplug code
2017-07-26 21:51:25 -04:00
cpuset: fix a deadlock due to incomplete patching of cpusets_enabled()
2017-08-02 17:16:12 -07:00
kdump: protect vmcoreinfo data under the crash memory
2017-07-12 16:26:00 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
dm, dax: Make sure dm_dax_flush() is called if device supports it
2017-07-26 15:55:44 -04:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
libnvdimm for 4.13
2017-07-07 09:44:06 -07:00
pinctrl: generic: update references to Documentation/pinctrl.txt
2017-08-07 15:26:34 +02:00
pty: fix the cached path of the pty slave file descriptor in the master
2017-08-17 09:10:48 -07:00
dma-buf/fence: Avoid use of uninitialised timestamp
2017-07-14 16:09:55 -03:00
dma-coherent: introduce interface for default DMA pool
2017-07-20 16:09:10 +02:00
lib: add errseq_t type and infrastructure for handling it
2017-07-06 07:02:24 -04:00
kcmp: fs/epoll: wrap kcmp code with CONFIG_CHECKPOINT_RESTORE
2017-07-12 16:26:01 -07:00
lib/extable.c: use bsearch() library function in search_extable()
2017-07-10 16:32:35 -07:00
include/linux/filter.h: use linux/set_memory.h
2017-07-06 16:24:30 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
The first major feature for ext4 this merge window is the largedir
2017-07-09 09:31:22 -07:00
dentry name snapshots
2017-07-07 20:09:10 -04:00
trace: fix the errors caused by incompatible type of RCU variables
2017-07-20 09:27:29 -04:00
device property: Introduce fwnode_call_bool_op() for ops that return bool
2017-07-12 13:32:46 +02:00
mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic
2017-07-12 16:26:03 -07:00
Merge branches 'for-4.13/multitouch', 'for-4.13/retrode', 'for-4.13/transport-open-close-consolidation', 'for-4.13/upstream' and 'for-4.13/wacom' into for-linus
2017-07-10 11:11:25 +02:00
mm: always enable thp for dax mappings
2017-07-10 16:32:31 -07:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-07-15 12:00:42 -07:00
i2c: rephrase explanation of I2C_CLASS_DEPRECATED
2017-07-31 17:33:53 +02:00
sched/cputime: Move the vtime task fields to their own struct
2017-07-05 09:54:15 +02:00
ARM: fix rd_size declaration
2017-07-10 16:32:34 -07:00
Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2017-07-09 10:24:46 -07:00
Changes for 4.13:
2017-07-10 10:51:53 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
udp6: fix jumbogram reception
2017-07-31 22:01:21 -07:00
genirq/cpuhotplug: Revert "Set force affinity flag on hotplug migration"
2017-07-27 15:40:02 +02:00
genirq: Add mutex to irq desc to serialize request/free_irq()
2017-07-04 12:46:16 +02:00
jhash: fix -Wimplicit-fallthrough warnings
2017-07-17 09:22:34 -07:00
kernel.h: handle pointers to arrays better in container_of()
2017-07-12 16:25:59 -07:00
kdump: protect vmcoreinfo data under the crash memory
2017-07-12 16:26:00 -07:00
There has been a fair amount of activity in the docs tree this time
2017-07-03 21:13:25 -07:00
mm: make PR_SET_THP_DISABLE immediately active
2017-07-10 16:32:31 -07:00
mm: kmemleak: treat vm_struct as alternative reference to vmalloc'ed objects
2017-07-06 16:24:34 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
kprobes: Rename [arch_]function_offset_within_entry() to [arch_]kprobe_on_func_entry()
2017-07-08 11:05:34 +02:00
kthread: fix documentation build warning
2017-08-02 16:34:47 -07:00
KVM: avoid using rcu_dereference_protected
2017-08-02 22:41:02 +02:00
libata: Cleanup ata_read_log_page()
2017-07-10 13:41:04 -04:00
Merge branch 'for-4.13/dax' into libnvdimm-for-next
2017-07-03 16:54:58 -07:00
mm/list_lru.c: fix list_lru_count_node() to be race free
2017-07-10 16:32:33 -07:00
llist: clang: introduce member_address_is_nonnull()
2017-07-19 15:33:50 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
mm, memory_hotplug: move movable_node to the hotplug proper
2017-07-06 16:24:35 -07:00
mm: memcontrol: fix NULL pointer crash in test_clear_page_writeback()
2017-08-18 15:32:01 -07:00
mm, memory_hotplug: move movable_node to the hotplug proper
2017-07-06 16:24:35 -07:00
mm, mempolicy: simplify rebinding mempolicies when updating cpusets
2017-07-06 16:24:34 -07:00
mm, migration: do not trigger OOM killer when migrating memory
2017-07-12 16:26:04 -07:00
Writeback error handling fixes (pile #1 )
2017-07-07 18:39:15 -07:00
mm: fix MADV_[FREE|DONTNEED] TLB flush miss problem
2017-08-10 15:54:07 -07:00
mm: disallow early_pfn_to_nid on configurations which do not implement it
2017-07-10 16:32:33 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
net: Fix a typo in comment about sock flags.
2017-08-15 17:07:17 -07:00
bonding: avoid NETDEV_CHANGEMTU event when unregistering slave
2017-07-08 11:23:29 +01:00
netfilter: remove old pre-netns era hook api
2017-07-17 17:01:10 +02:00
nfs4: add NFSv4 LOOKUPP handlers
2017-07-13 16:00:15 -04:00
NFS: Store the raw NFS access mask in the inode's access cache
2017-07-21 11:51:19 -04:00
NFSv4.1: Handle EXCHGID4_FLAG_CONFIRMED_R during NFSv4.1 migration
2017-07-13 16:00:12 -04:00
NFS: Don't run wake_up_bit() when nobody is waiting...
2017-07-13 17:12:07 -04:00
NFSv4: Fix EXCHANGE_ID corrupt verifier issue
2017-08-01 16:28:55 -04:00
kernel/watchdog: split up config options
2017-07-12 16:26:02 -07:00
mm, memory_hotplug: split up register_one_node()
2017-07-06 16:24:32 -07:00
mm, memory_hotplug: drop CONFIG_MOVABLE_NODE
2017-07-06 16:24:35 -07:00
NTB: Add ntb.h comments
2017-07-06 11:30:07 -04:00
nvmet_fc: add defer_req callback for deferment of cmd buffer return
2017-08-10 11:06:38 +02:00
nvme-fc: revise TRADDR parsing
2017-07-25 18:05:25 +02:00
nvme: fabrics commands should use the fctype field for data direction
2017-07-25 17:58:32 +02:00
nvmem: include linux/err.h from header
2017-07-10 14:27:39 +02:00
Device properties framework updates for v4.13-rc1
2017-07-10 15:23:45 -07:00
mm, THP, swap: delay splitting THP during swap out
2017-07-06 16:24:31 -07:00
include/linux/page_ref.h: ensure page_ref_unfreeze is ordered against prior accesses
2017-07-10 16:32:31 -07:00
mm: allow page_cache_get_speculative in interrupt context
2017-08-02 17:16:13 -07:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2017-08-15 18:52:28 -07:00
PCI: tango: Add Sigma Designs Tango SMP8759 PCIe host bridge support
2017-07-07 13:41:28 -05:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2017-07-05 12:31:59 -07:00
net: phy: Remove trailing semicolon in macro definition
2017-07-25 12:33:43 -07:00
ptp: introduce ptp auxiliary worker
2017-08-01 15:22:55 -07:00
Add wait_for_random_bytes() and get_random_*_wait() functions so that
2017-07-15 12:44:02 -07:00
rtc: Remove wrong deprecation comment
2017-07-12 23:11:23 +02:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
provide linux/set_memory.h
2017-07-06 16:24:30 -07:00
Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-07-06 20:57:13 -07:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2017-07-05 12:31:59 -07:00
mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic
2017-07-12 16:26:03 -07:00
mm/slub.c: wrap kmem_cache->cpu_partial in config CONFIG_SLUB_CPU_PARTIAL
2017-07-06 16:24:30 -07:00
Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-07-15 12:00:42 -07:00
mm: swap: provide lru_add_drain_all_cpuslocked()
2017-07-10 16:32:33 -07:00
mm, THP, swap: delay splitting THP during swap out
2017-07-06 16:24:31 -07:00
mm: hwpoison: change PageHWPoison behavior on hugetlb pages
2017-07-10 16:32:30 -07:00
dma-buf/sync_file: Allow multiple sync_files to wrap a single dma-fence
2017-07-31 10:55:24 -03:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-07-06 20:57:13 -07:00
trace: fix the errors caused by incompatible type of RCU variables
2017-07-20 09:27:29 -04:00
Now that IPC and other changes have landed, enable manual markings for
2017-07-19 08:55:18 -07:00
Merge branch 'work.__copy_in_user' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-07-08 10:15:02 -07:00
fix brown paperbag bug in inlined copy_..._iter()
2017-07-10 07:40:49 -04:00
uuid: remove uuid_be
2017-07-24 17:50:37 +02:00
include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH
2017-07-26 13:30:23 -06:00
mm/oom_kill: count global and memory cgroup oom kills
2017-07-06 16:24:35 -07:00
mm: memcontrol: per-lruvec stats infrastructure
2017-07-06 16:24:35 -07:00
vtime, sched/cputime: Remove vtime_account_user()
2017-07-05 09:54:14 +02:00
wait: add wait_event_killable_timeout()
2017-08-18 15:32:01 -07:00
workqueue: implicit ordered attribute should be overridable
2017-07-25 13:28:56 -04:00
