Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Maciej W. Rozycki e3f7e99337 PCI: Sanitise firmware BAR assignments behind a PCI-PCI bridge ... commit 0e32818397426a688f598f35d3bc762eca6d7592 upstream. When pci_assign_resource() is unable to assign resources to a BAR, it uses pci_revert_fw_address() to fall back to a firmware assignment (if any). Previously pci_revert_fw_address() assumed all addresses could reach the device, but this is not true if the device is below a bridge that only forwards addresses within its windows. This problem was observed on a Tyan Tomcat IV S1564D system where the BIOS did not assign valid addresses to several bridges and USB devices: pci 0000:00:11.0: PCI-to-PCIe bridge to [bus 01-ff] pci 0000:00:11.0: bridge window [io 0xe000-0xefff] pci 0000:01:00.0: PCIe Upstream Port to [bus 02-ff] pci 0000:01:00.0: bridge window [io 0x0000-0x0fff] # unreachable pci 0000:02:02.0: PCIe Downstream Port to [bus 05-ff] pci 0000:02:02.0: bridge window [io 0x0000-0x0fff] # unreachable pci 0000:05:00.0: PCIe-to-PCI bridge to [bus 06-ff] pci 0000:05:00.0: bridge window [io 0x0000-0x0fff] # unreachable pci 0000:06:08.0: USB UHCI 1.1 pci 0000:06:08.0: BAR 4: [io 0xfce0-0xfcff] # unreachable pci 0000:06:08.1: USB UHCI 1.1 pci 0000:06:08.1: BAR 4: [io 0xfce0-0xfcff] # unreachable pci 0000:06:08.0: can't claim BAR 4 [io 0xfce0-0xfcff]: no compatible bridge window pci 0000:06:08.1: can't claim BAR 4 [io 0xfce0-0xfcff]: no compatible bridge window During the first pass of assigning unassigned resources, there was not enough I/O space available, so we couldn't assign the 06:08.0 BAR and reverted to the firmware assignment (still unreachable). Reverting the 06:08.1 assignment failed because it conflicted with 06:08.0: pci 0000:00:11.0: bridge window [io 0xe000-0xefff] pci 0000:01:00.0: no space for bridge window [io size 0x2000] pci 0000:02:02.0: no space for bridge window [io size 0x1000] pci 0000:05:00.0: no space for bridge window [io size 0x1000] pci 0000:06:08.0: BAR 4: no space for [io size 0x0020] pci 0000:06:08.0: BAR 4: trying firmware assignment [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: no space for [io size 0x0020] pci 0000:06:08.1: BAR 4: trying firmware assignment [io 0xfce0-0xfcff] pci 0000:06:08.1: BAR 4: [io 0xfce0-0xfcff] conflicts with 0000:06:08.0 [io 0xfce0-0xfcff] A subsequent pass assigned valid bridge windows and a valid 06:08.1 BAR, but left the 06:08.0 BAR alone, so the UHCI device was still unusable: pci 0000:00:11.0: bridge window [io 0xe000-0xefff] released pci 0000:00:11.0: bridge window [io 0x1000-0x2fff] # reassigned pci 0000:01:00.0: bridge window [io 0x1000-0x2fff] # reassigned pci 0000:02:02.0: bridge window [io 0x2000-0x2fff] # reassigned pci 0000:05:00.0: bridge window [io 0x2000-0x2fff] # reassigned pci 0000:06:08.0: BAR 4: assigned [io 0xfce0-0xfcff] # left alone pci 0000:06:08.1: BAR 4: assigned [io 0x2000-0x201f] ... uhci_hcd 0000:06:08.0: host system error, PCI problems? uhci_hcd 0000:06:08.0: host controller process error, something bad happened! uhci_hcd 0000:06:08.0: host controller halted, very bad! uhci_hcd 0000:06:08.0: HCRESET not completed yet! uhci_hcd 0000:06:08.0: HC died; cleaning up If the address assigned by firmware is not reachable because it's not within upstream bridge windows, fail instead of assigning the unusable address from firmware. [bhelgaas: commit log, use pci_upstream_bridge()] Link: https://bugzilla.kernel.org/show_bug.cgi?id=16263 Link: https://lore.kernel.org/r/alpine.DEB.2.21.2203012338460.46819@angie.orcam.me.uk Link: https://lore.kernel.org/r/alpine.DEB.2.21.2209211921250.29493@angie.orcam.me.uk Fixes: 58c84eda07 ("PCI: fall back to original BIOS BAR addresses") Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Cc: stable@vger.kernel.org # v2.6.35+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-10-26 13:22:16 +02:00
..
controller	PCI: tegra194: Fix link up retry sequence	2022-08-25 11:17:58 +02:00
endpoint
hotplug	PCI: pciehp: Add Qualcomm quirk for Command Completed erratum	2022-04-15 14:18:33 +02:00
pcie	PCI/portdrv: Enable Bandwidth Notification only if port supports it	2021-09-22 12:26:22 +02:00
switch
access.c	PCI: Reduce warnings on possible RW1C corruption	2022-04-15 14:18:15 +02:00
ats.c
bus.c
ecam.c	PCI/ACPI: Add Ampere Altra SOC MCFG quirk	2021-09-26 14:07:05 +02:00
host-bridge.c
iov.c
irq.c
Kconfig
Makefile
mmap.c
msi.c	PCI/MSI: Fix pci_irq_vector()/pci_irq_get_affinity()	2022-01-27 09:19:38 +01:00
of.c
p2pdma.c
pci-acpi.c
pci-bridge-emul.c	PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device	2022-01-27 09:19:50 +01:00
pci-bridge-emul.h	PCI: pci-bridge-emul: Add PCIe Root Capabilities Register	2021-09-26 14:07:04 +02:00
pci-driver.c
pci-label.c
pci-mid.c
pci-pf-stub.c
pci-stub.c
pci-sysfs.c
pci.c	PCI/PM: Fix bridge_d3_blacklist[] Elo i2 overwrite of Gigabyte X299	2022-06-14 18:11:46 +02:00
pci.h
probe.c	PCI: Fix pci_host_bridge struct device release/free handling	2021-10-06 15:42:38 +02:00
proc.c
quirks.c	PCI: Add ACS quirk for Broadcom BCM5750x NICs	2022-08-25 11:18:31 +02:00
remove.c	PCI: Fix pci_host_bridge struct device release/free handling	2021-10-06 15:42:38 +02:00
rom.c
search.c
setup-bus.c
setup-irq.c
setup-res.c	PCI: Sanitise firmware BAR assignments behind a PCI-PCI bridge	2022-10-26 13:22:16 +02:00
slot.c
syscall.c	PCI: Return ~0 data on pciconfig_read() CAP_SYS_ADMIN failure	2021-09-22 12:26:22 +02:00
vc.c
vpd.c
xen-pcifront.c