Ethan Lien
44277c50fd
btrfs: fix qgroup reserve overflow the qgroup limit ...
commit b642b52d0b50f4d398cb4293f64992d0eed2e2ce upstream.
We use extent_changeset->bytes_changed in qgroup_reserve_data() to record
how many bytes we set for EXTENT_QGROUP_RESERVED state. Currently the
bytes_changed is set as "unsigned int", and it will overflow if we try to
fallocate a range larger than 4GiB. The result is we reserve less bytes
and eventually break the qgroup limit.
Unlike regular buffered/direct write, which we use one changeset for
each ordered extent, which can never be larger than 256M. For
fallocate, we use one changeset for the whole range, thus it no longer
respects the 256M per extent limit, and caused the problem.
The following example test script reproduces the problem:
$ cat qgroup-overflow.sh
#!/bin/bash
DEV=/dev/sdj
MNT=/mnt/sdj
mkfs.btrfs -f $DEV
mount $DEV $MNT
# Set qgroup limit to 2GiB.
btrfs quota enable $MNT
btrfs qgroup limit 2G $MNT
# Try to fallocate a 3GiB file. This should fail.
echo
echo "Try to fallocate a 3GiB file..."
fallocate -l 3G $MNT/3G.file
# Try to fallocate a 5GiB file.
echo
echo "Try to fallocate a 5GiB file..."
fallocate -l 5G $MNT/5G.file
# See we break the qgroup limit.
echo
sync
btrfs qgroup show -r $MNT
umount $MNT
When running the test:
$ ./qgroup-overflow.sh
(...)
Try to fallocate a 3GiB file...
fallocate: fallocate failed: Disk quota exceeded
Try to fallocate a 5GiB file...
qgroupid rfer excl max_rfer
-------- ---- ---- --------
0/5 5.00GiB 5.00GiB 2.00GiB
Since we have no control of how bytes_changed is used, it's better to
set it to u64.
CC: stable@vger.kernel.org # 4.14+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Ethan Lien <ethanlien@synology.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-04-15 14:18:39 +02:00
9P: Cast to loff_t before multiplying
2020-11-05 11:43:34 +01:00
fs/affs: release old buffer head on error path
2021-03-04 10:26:48 +01:00
afs: Fix incorrect triggering of sillyrename on 3rd-party invalidation
2021-09-30 10:09:22 +02:00
autofs: fix a leak in autofs_expire_indirect()
2019-10-25 00:03:11 -04:00
bfs: don't use WARNING: string when it's just info.
2021-01-06 14:48:39 +01:00
btrfs: fix qgroup reserve overflow the qgroup limit
2022-04-15 14:18:39 +02:00
cachefiles: Handle readpage error correctly
2020-11-05 11:43:36 +01:00
ceph: fix handling of "meta" errors
2021-10-27 09:54:27 +02:00
cifs: fix double free race when mount fails in cifs_get_root()
2022-03-08 19:07:45 +01:00
y2038: add inode timestamp clamping
2019-09-19 09:42:37 -07:00
configfs: fix a race in configfs_{,un}register_subsystem()
2022-03-02 11:41:10 +01:00
cramfs: fix usage on non-MTD device
2019-11-23 21:44:49 -05:00
fscrypt: add fscrypt_symlink_getattr() for computing st_size
2021-09-12 08:56:38 +02:00
debugfs: lockdown: Allow reading debugfs files that are not world readable
2022-01-27 09:19:36 +01:00
fsnotify: fix fsnotify hooks in pseudo filesystems
2022-02-01 17:24:34 +01:00
fs: dlm: filter user dlm messages for kernel locks
2022-01-27 09:19:40 +01:00
Revert "ecryptfs: replace BUG_ON with error handling code"
2021-05-26 12:05:19 +02:00
efivarfs: revert "fix memory leak in efivarfs_create()"
2020-12-02 08:49:53 +01:00
erofs: fix unsafe pagevec reuse of hooked pclusters
2021-11-21 13:38:51 +01:00
exportfs_decode_fh(): negative pinned may become positive without the parent locked
2019-11-10 11:56:05 -05:00
ext2: correct max file size computing
2022-04-15 14:18:13 +02:00
ext4: don't BUG if someone dirty pages without asking ext4 first
2022-04-15 14:18:23 +02:00
f2fs: fix to avoid potential deadlock
2022-04-15 14:18:06 +02:00
fat: don't allow to mount if the FAT length == 0
2020-06-17 16:40:36 +02:00
fscache: Fix cookie key hashing
2021-09-22 12:26:25 +02:00
fuse: fix pipe buffer lifetime for direct_io
2022-03-16 13:21:47 +01:00
gfs2: Make sure FITRIM minlen is rounded up to fs block size
2022-04-15 14:18:28 +02:00
hfs: add lock nesting notation to hfs_find_init
2021-07-31 08:19:38 +02:00
hfsplus: prevent corruption in shrinking truncate
2021-05-19 10:08:29 +02:00
hostfs: fix memory handling in follow_link()
2021-04-14 08:24:14 +02:00
hugetlbfs: fix mount mode command line processing
2021-07-28 13:31:01 +02:00
mm/swap: consider max pages in iomap_swapfile_add_extent
2021-09-15 09:47:35 +02:00
isofs: Fix out of bound access for corrupted isofs image
2021-11-12 14:43:03 +01:00
jbd2: fix up sparse warnings in checkpoint code
2020-11-18 19:20:30 +01:00
jffs2: fix memory leak in jffs2_scan_medium
2022-04-15 14:17:59 +02:00
jfs: prevent NULL deref in diFree
2022-04-15 14:18:36 +02:00
kernfs: do not call fsnotify() with name without a parent
2020-08-19 08:16:12 +02:00
lockd: lockd server-side shouldn't set fl_ops
2021-09-22 12:26:34 +02:00
minix: fix bug when opening a file with O_DIRECT
2022-04-15 14:18:35 +02:00
NFS: swap-out must always use STABLE writes.
2022-04-15 14:18:36 +02:00
nfs_common: need lock during iterate through the list
2020-12-30 11:51:22 +01:00
NFSD: prevent underflow in nfssvc_decode_writeargs()
2022-04-15 14:17:59 +02:00
nilfs2: fix memory leak in nilfs_sysfs_delete_snapshot_group
2021-09-26 14:07:13 +02:00
fanotify: fix ignore mask logic for events on child and on dir
2020-06-17 16:40:24 +02:00
ntfs: add sanity check on allocation size
2022-04-15 14:18:23 +02:00
ocfs2: fix crash when initialize filecheck kobj fails
2022-03-23 09:12:06 +01:00
orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()
2022-01-20 09:19:17 +01:00
ovl: fix warning in ovl_create_real()
2021-12-22 09:29:40 +01:00
proc/vmcore: fix clearing user buffer by properly using clear_user()
2021-12-01 09:23:31 +01:00
pstore: Fix typo in compression option name
2021-03-04 10:26:45 +01:00
qnx4: work around gcc false positive warning bug
2021-09-30 10:09:26 +02:00
quota: make dquot_quota_sync return errors from ->sync_fs
2022-02-23 11:59:55 +01:00
ramfs: fix nommu mmap with gaps in the page cache
2020-10-29 09:57:53 +01:00
reiserfs: check directory items on read from disk
2021-08-12 13:21:05 +02:00
romfs: fix uninitialized memory leak in romfs_dev_read()
2020-08-26 10:40:51 +02:00
squashfs: fix divide error in calculate_skip()
2021-05-19 10:08:29 +02:00
sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output
2021-03-07 12:20:48 +01:00
tracefs: Set the group ownership in apply_options() not parse_options()
2022-03-02 11:41:13 +01:00
ubifs: Rectify space amount budget for mkdir/tmpfile operations
2022-04-15 14:18:31 +02:00
udf: Fix NULL ptr deref when converting from inline format
2022-02-01 17:24:34 +01:00
fs/ufs: avoid potential u32 multiplication overflow
2020-08-21 13:05:37 +02:00
fs-verity: fix signed integer overflow with i_size near S64_MAX
2021-10-06 15:42:30 +02:00
xfs: map unwritten blocks in XFS_IOC_{ALLOC,FREE}SP just like fallocate
2022-01-11 15:23:32 +01:00
aio: fix use-after-free due to missing POLLFREE handling
2021-12-14 14:49:02 +01:00
utimes: Clamp the timestamps in notify_change()
2020-02-11 04:35:12 -08:00
elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings
2021-10-06 15:42:35 +02:00
binfmt_flat: revert "binfmt_flat: don't offset the data start"
2020-09-03 11:26:39 +02:00
binfmt_misc: fix possible deadlock in bm_register_write
2021-03-17 17:03:57 +01:00
block: reexpand iov_iter after read/write
2021-05-22 11:38:29 +02:00
fs: Don't invalidate page buffers in block_write_full_page()
2020-11-05 11:43:24 +01:00
chardev: Avoid potential use-after-free in 'chrdev_open()'
2020-01-14 20:08:18 +01:00
fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP
2020-01-09 10:20:05 +01:00
coredump: fix core_pattern parse error
2020-12-11 13:23:30 +01:00
fs: fix NULL dereference due to data race in prepend_path()
2020-10-29 09:57:45 +01:00
dax: fix ENOMEM handling in grab_mapping_entry()
2021-07-14 16:53:25 +02:00
fix dget_parent() fastpath race
2020-10-01 13:17:19 +02:00
fs: direct-io: fix missing sdio->boundary
2021-04-14 08:24:11 +02:00
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:21:37 +01:00
eventfd: track eventfd_signal() recursion depth
2020-02-11 04:35:37 -08:00
ep_create_wakeup_source(): dentry name can change under you...
2020-10-07 08:01:31 +02:00
vfs: check fd has read access in kernel_read_file_from_fd()
2021-10-27 09:54:27 +02:00
fcntl: fix potential deadlock for &fasync_struct.fa_lock
2021-09-15 09:47:28 +02:00
fget: clarify and improve __fget_files() implementation
2022-03-02 11:41:18 +01:00
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-17 10:50:21 +02:00
writeback: fix obtain a reference to a freeing memcg css
2021-07-14 16:53:35 +02:00
memcg: charge fs_context and legacy_fs_context
2022-02-08 18:24:29 +01:00
futex: Fix inode life-time issue
2020-03-25 08:25:58 +01:00
cgroup1: fix leaked context root causing sporadic NULL deref in LTP
2021-07-31 08:19:37 +02:00
io_uring: Fix current->fs handling in io_sq_wq_submit_work()
2021-01-30 13:54:10 +01:00
compat_ioctl: add compat_ptr_ioctl()
2019-12-17 19:55:30 +01:00
fs-verity for 5.4
2019-09-18 16:59:14 -07:00
libfs: fix error cast of negative value in simple_attr_write()
2020-11-24 13:29:19 +01:00
locks: reinstate locks_delete_block optimization
2020-03-25 08:25:41 +01:00
fs-verity for 5.4
2019-09-18 16:59:14 -07:00
fs: move guard_bio_eod() after bio_set_op_attrs
2020-01-17 19:48:21 +01:00
fsnotify: invalidate dcache before IN_DELETE event
2022-02-01 17:24:39 +01:00
fs: warn about impending deprecation of mandatory locks
2021-08-26 08:36:22 -04:00
cifs_atomic_open(): fix double-put on late allocation failure
2020-03-18 07:17:51 +01:00
pipe: increase minimum default pipe size to 2 pages
2021-08-12 13:21:02 +02:00
propagate_one(): mnt_set_mountpoint() needs mount_lock
2020-05-02 08:48:44 +02:00
mount: fix mounting of detached mounts onto targets that reside on shared mounts
2021-03-17 17:03:33 +01:00
fs: allow deduplication of eof block into the end of the destination file
2020-02-11 04:35:23 -08:00
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-21 12:56:16 +02:00
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:25:11 +01:00
seq_file: disallow extremely large seq buffer allocations
2021-07-20 16:10:54 +02:00
signalfd: use wake_up_pollfree()
2021-12-14 14:49:02 +01:00
splice: only read in as much information as there is pipe buffer space
2019-12-17 19:56:52 +01:00
vfs: Fix EOVERFLOW testing in put_compat_statfs64
2019-10-03 14:21:35 -07:00
vfs: make freeze_super abort when sync_filesystem returns error
2022-02-23 11:59:55 +01:00
userfaultfd: prevent concurrent API initialization
2021-09-22 12:26:26 +02:00
utimes: Clamp the timestamps in notify_change()
2020-02-11 04:35:12 -08:00
xattr: break delegations in {set,remove}xattr
2020-08-11 15:33:39 +02:00
44277c50fd