Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Tom Zanussi 9f0bbf3115 tracing: Use strncpy instead of memcpy for string keys in hist triggers ... Because there may be random garbage beyond a string's null terminator, it's not correct to copy the the complete character array for use as a hist trigger key. This results in multiple histogram entries for the 'same' string key. So, in the case of a string key, use strncpy instead of memcpy to avoid copying in the extra bytes. Before, using the gdbus entries in the following hist trigger as an example: # echo 'hist:key=comm' > /sys/kernel/debug/tracing/events/sched/sched_waking/trigger # cat /sys/kernel/debug/tracing/events/sched/sched_waking/hist ... { comm: ImgDecoder #4 } hitcount: 203 { comm: gmain } hitcount: 213 { comm: gmain } hitcount: 216 { comm: StreamTrans #73 } hitcount: 221 { comm: mozStorage #3 } hitcount: 230 { comm: gdbus } hitcount: 233 { comm: StyleThread#5 } hitcount: 253 { comm: gdbus } hitcount: 256 { comm: gdbus } hitcount: 260 { comm: StyleThread#4 } hitcount: 271 ... # cat /sys/kernel/debug/tracing/events/sched/sched_waking/hist | egrep gdbus | wc -l 51 After: # cat /sys/kernel/debug/tracing/events/sched/sched_waking/hist | egrep gdbus | wc -l 1 Link: http://lkml.kernel.org/r/50c35ae1267d64eee975b8125e151e600071d4dc.1549309756.git.tom.zanussi@linux.intel.com Cc: Namhyung Kim <namhyung@kernel.org> Cc: stable@vger.kernel.org Fixes: 79e577cbce ("tracing: Support string type key properly") Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>		2019-03-05 08:47:46 -05:00
..
blktrace.c	blkcg: remove bio->bi_css and instead use bio->bi_blkg	2018-12-07 22:26:37 -07:00
bpf_trace.c	Remove 'type' argument from access_ok() function	2019-01-03 18:57:57 -08:00
fgraph.c	tracing: Fix ftrace_graph_get_ret_stack() to use task and not current	2018-12-22 08:21:03 -05:00
ftrace.c	ftrace: Allow enabling of filters via index of available_filter_functions	2019-02-15 13:10:09 -05:00
ftrace_internal.h	ftrace: Create new ftrace_internal.h header	2018-12-08 20:54:06 -05:00
Kconfig	tracing: Use dyn_event framework for synthetic events	2018-12-08 20:54:10 -05:00
Makefile	tracing: Add unified dynamic event framework	2018-12-08 20:54:09 -05:00
power-traces.c
preemptirq_delay_test.c
ring_buffer.c	ring-buffer: Remove unused function ring_buffer_page_len()	2019-02-06 11:58:33 -05:00
ring_buffer_benchmark.c
rpm-traces.c
trace.c	tracing: Fix spelling mistake: "analagous" -> "analogous"	2019-02-20 13:51:08 -05:00
trace.h	tracing: Add conditional snapshot	2019-02-20 13:51:06 -05:00
trace_benchmark.c
trace_benchmark.h
trace_branch.c
trace_clock.c
trace_dynevent.c	tracing: Add generic event-name based remove event method	2018-12-10 12:22:44 -05:00
trace_dynevent.h	tracing: Add unified dynamic event framework	2018-12-08 20:54:09 -05:00
trace_entries.h	tracing: Change the function format to display function names by perf	2019-02-11 14:53:43 -05:00
trace_event_perf.c	tracing/perf: Use strndup_user() instead of buggy open-coded version	2019-02-21 10:35:10 -05:00
trace_events.c	tracing: Use str_has_prefix() instead of using fixed sizes	2018-12-22 22:51:54 -05:00
trace_events_filter.c	ftrace: Allow enabling of filters via index of available_filter_functions	2019-02-15 13:10:09 -05:00
trace_events_filter_test.h
trace_events_hist.c	tracing: Use strncpy instead of memcpy for string keys in hist triggers	2019-03-05 08:47:46 -05:00
trace_events_trigger.c	tracing: Fix memory leak in set_trigger_filter()	2018-12-11 13:50:19 -05:00
trace_export.c
trace_functions.c
trace_functions_graph.c	tracing: Put a margin between flags and duration for wakeup tracers	2019-02-06 11:56:19 -05:00
trace_hwlat.c
trace_irqsoff.c	function_graph: Support displaying relative timestamp	2019-02-06 11:56:18 -05:00
trace_kdb.c
trace_kprobe.c	tracing/kprobes: Fix NULL pointer dereference in trace_kprobe_create()	2019-01-15 11:33:45 -05:00
trace_kprobe_selftest.c
trace_kprobe_selftest.h
trace_mmiotrace.c
trace_nop.c
trace_output.c	tracing: Simplify printf'ing in seq_print_sym	2018-12-22 08:21:06 -05:00
trace_output.h
trace_preemptirq.c
trace_printk.c
trace_probe.c	tracing: Annotate implicit fall through in parse_probe_arg()	2019-02-06 11:56:18 -05:00
trace_probe.h	tracing/kprobes: Use dyn_event framework for kprobe events	2018-12-08 20:54:09 -05:00
trace_probe_tmpl.h
trace_sched_switch.c
trace_sched_wakeup.c	tracing: Add conditional snapshot	2019-02-20 13:51:06 -05:00
trace_selftest.c	fgraph: Add new fgraph_ops structure to enable function graph hooks	2018-12-08 20:54:07 -05:00
trace_selftest_dynamic.c
trace_seq.c
trace_stack.c	tracing: Use the return of str_has_prefix() to remove open coded numbers	2018-12-22 22:52:30 -05:00
trace_stat.c
trace_stat.h
trace_syscalls.c
trace_uprobe.c	tracing: Consolidate trace_add/remove_event_call back to the nolock functions	2018-12-10 12:22:10 -05:00
tracing_map.c
tracing_map.h