Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Filipe Manana 7ad8aa6635 btrfs: use smp_mb__after_atomic() when forcing COW in create_pending_snapshot() ... [ Upstream commit 45c222468d33202c07c41c113301a4b9c8451b8f ] After setting the BTRFS_ROOT_FORCE_COW flag on the root we are doing a full write barrier, smp_wmb(), but we don't need to, all we need is a smp_mb__after_atomic(). The use of the smp_wmb() is from the old days when we didn't use a bit and used instead an int field in the root to signal if cow is forced. After the int field was changed to a bit in the root's state (flags field), we forgot to update the memory barrier in create_pending_snapshot() to smp_mb__after_atomic(), but we did the change in commit_fs_roots() after clearing BTRFS_ROOT_FORCE_COW. That happened in commit 27cdeb7096 ("Btrfs: use bitfield instead of integer data type for the some variants in btrfs_root"). On the reader side, in should_cow_block(), we also use the counterpart smp_mb__before_atomic() which generates further confusion. So change the smp_wmb() to smp_mb__after_atomic(). In fact we don't even need any barrier at all since create_pending_snapshot() is called in the critical section of a transaction commit and therefore no one can concurrently join/attach the transaction, or start a new one, until the transaction is unblocked. By the time someone starts a new transaction and enters should_cow_block(), a lot of implicit memory barriers already took place by having acquired several locks such as fs_info->trans_lock and extent buffer locks on the root node at least. Nevertlheless, for consistency use smp_mb__after_atomic() after setting the force cow bit in create_pending_snapshot(). Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2025-12-03 12:45:04 +01:00
..
9p	fs/9p: drop inodes immediately on non-.L too	2024-05-17 11:43:53 +02:00
adfs
affs	affs: don't write overlarge OFS data block size fields	2025-04-10 14:29:42 +02:00
afs	afs: Fix directory format encoding struct	2025-03-13 12:42:52 +01:00
autofs	autofs: fix memory leak of waitqueues in autofs_catatonic_mode	2023-09-23 11:00:02 +02:00
befs
bfs	bfs: don't use WARNING: string when it's just info.	2021-01-06 14:48:39 +01:00
btrfs	btrfs: use smp_mb__after_atomic() when forcing COW in create_pending_snapshot()	2025-12-03 12:45:04 +01:00
cachefiles	cachefiles: fix memory leak in cachefiles_add_cache()	2024-03-06 14:36:10 +00:00
ceph	ceph: fix possible integer overflow in ceph_zero_objects()	2025-07-17 18:24:50 +02:00
cifs	cifs: fix integer overflow in match_server()	2025-09-09 18:44:02 +02:00
coda	coda: Avoid partial allocation of sig_inputArgs	2023-03-11 16:43:56 +01:00
configfs	configfs: Do not override creating attribute file failure in populate_attrs()	2025-06-27 11:02:50 +01:00
cramfs	cramfs: Verify inode mode when loading from disk	2025-10-29 13:59:55 +01:00
crypto	fscrypt: add fscrypt_symlink_getattr() for computing st_size	2021-09-12 08:56:38 +02:00
debugfs	new helper: lookup_positive_unlocked()	2023-09-23 10:59:40 +02:00
devpts	fsnotify: fix fsnotify hooks in pseudo filesystems	2022-02-01 17:24:34 +01:00
dlm	dlm: check for defined force value in dlm_lockspace_release	2025-10-29 13:59:58 +01:00
ecryptfs	ecryptfs: Fix buffer size for tag 66 packet	2024-06-16 13:28:32 +02:00
efivarfs	efivarfs: Fix slab-out-of-bounds in efivarfs_d_compare	2025-09-04 14:05:55 +02:00
efs
erofs	erofs: fix incorrect symlink detection in fast symlink	2025-01-09 13:23:27 +01:00
exportfs
ext2	ext2: fix datatype of block number in ext2_xattr_set2()	2023-09-23 11:00:04 +02:00
ext4	ext4: detect invalid INLINE_DATA + EXTENTS flag combination	2025-10-29 14:00:01 +01:00
f2fs	f2fs: fix to avoid out-of-boundary access in dnode page	2025-08-28 16:21:35 +02:00
fat	fat: fix uninitialized variable	2024-11-08 16:20:47 +01:00
freevxfs
fscache	fscache: Fix cookie key hashing	2021-09-22 12:26:25 +02:00
fuse	fuse: prevent overflow in copy_file_range return value	2025-10-02 13:34:28 +02:00
gfs2	gfs2: move msleep to sleepable context	2025-06-27 11:02:50 +01:00
hfs	hfs: fix KMSAN uninit-value issue in hfs_find_set_zero_bits()	2025-10-29 13:59:58 +01:00
hfsplus	hfsplus: return EIO when type of hidden directory mismatch in hfsplus_fill_super()	2025-10-29 13:59:58 +01:00
hostfs	hostfs: fix memory handling in follow_link()	2021-04-14 08:24:14 +02:00
hpfs
hugetlbfs	mm/hugetlb: fix folio is still mapped when deleted	2025-10-02 13:34:35 +02:00
iomap	iomap: Set all uptodate bits for an Uptodate page	2024-03-01 13:13:35 +01:00
isofs	isofs: Verify inode mode when loading from disk	2025-08-28 16:21:15 +02:00
jbd2	jbd2: ensure that all ongoing I/O complete before freeing blocks	2025-10-29 14:00:01 +01:00
jffs2	jffs2: check jffs2_prealloc_raw_node_refs() result in few other places	2025-06-27 11:02:56 +01:00
jfs	jfs: upper bound check of tree index in dbAllocAG	2025-08-28 16:21:28 +02:00
kernfs	fs/kernfs/dir: obey S_ISGID	2024-02-23 08:25:03 +01:00
lockd	fs: lockd: avoid possible wrong NULL parameter	2023-09-23 10:59:48 +02:00
minix	minixfs: Verify inode mode when loading from disk	2025-10-29 13:59:55 +01:00
nfs	NFSv4.1: fix backchannel max_resp_sz verification check	2025-10-29 13:59:49 +01:00
nfs_common	nfs_common: need lock during iterate through the list	2020-12-30 11:51:22 +01:00
nfsd	NFSD: Fix last write offset handling in layoutcommit	2025-10-29 14:00:01 +01:00
nilfs2	nilfs2: fix CFI failure when accessing /sys/fs/nilfs2/features/*	2025-10-02 13:34:31 +02:00
nls	fs/nls: make load_nls() take a const parameter	2023-09-23 10:59:38 +02:00
notify	fanotify: disallow mount/sb marks on kernel internal pseudo fs	2023-07-27 08:37:26 +02:00
ntfs	ntfs: check overflow when iterating ATTR_RECORDs	2022-11-25 17:42:22 +01:00
ocfs2	ocfs2: clear extent cache after moving/defragmenting extents	2025-10-29 13:59:59 +01:00
omfs	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
openpromfs	openpromfs: finish conversion to the new mount API	2024-06-16 13:28:32 +02:00
orangefs	fs/orangefs: use snprintf() instead of sprintf()	2025-08-28 16:21:27 +02:00
overlayfs	ovl: Check for NULL d_inode() in ovl_dentry_upper()	2025-07-17 18:24:51 +02:00
proc	fix proc_sys_compare() handling of in-lookup dentries	2025-07-17 18:25:01 +02:00
pstore	pstore/ram: Fix crash when setting number of cpus to an odd number	2024-02-23 08:24:55 +01:00
qnx4	qnx4: work around gcc false positive warning bug	2021-09-30 10:09:26 +02:00
qnx6
quota	quota: flush quota_release_work upon quota writeback	2024-12-14 19:44:42 +01:00
ramfs
reiserfs	reiserfs: Check the return value from __getblk()	2023-09-23 10:59:40 +02:00
romfs
squashfs	Squashfs: reject negative file sizes in squashfs_read_inode()	2025-10-29 13:59:55 +01:00
sysfs	fs: sysfs: Fix reference leak in sysfs_break_active_protection()	2024-05-02 16:18:32 +02:00
sysv	sysv: don't call sb_bread() with pointers_lock held	2024-04-13 12:51:38 +02:00
tracefs	tracefs: Add missing lockdown check to tracefs_create_dir()	2023-09-23 11:00:06 +02:00
ubifs	ubifs: skip dumping tnc tree when zroot is null	2025-03-13 12:42:59 +01:00
udf	fs: udf: fix OOB read in lengthAllocDescs handling	2025-10-29 13:59:54 +01:00
ufs
unicode	Revert "unicode: Don't special case ignorable code points"	2024-12-14 19:44:55 +01:00
verity	fsverity: skip PKCS#7 parser when keyring is empty	2023-09-23 10:59:55 +02:00
xfs	xfs: don't drop errno values when we fail to ficlone the entire range	2024-12-19 18:05:03 +01:00
aio.c	fs/aio: Check IOCB_AIO_RW before the struct aio_kiocb conversion	2024-04-13 12:51:29 +02:00
anon_inodes.c
attr.c	attr: block mode changes of symlinks	2023-09-23 11:00:06 +02:00
bad_inode.c
binfmt_aout.c	binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf	2023-01-18 11:41:46 +01:00
binfmt_elf.c	elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings	2021-10-06 15:42:35 +02:00
binfmt_elf_fdpic.c	fs: binfmt_elf_efpic: don't use missing interpreter's properties	2024-09-04 13:14:54 +02:00
binfmt_em86.c
binfmt_flat.c	binfmt_flat: Fix integer overflow bug on 32 bit systems	2025-03-13 12:43:07 +01:00
binfmt_misc.c	binfmt_misc: cleanup on filesystem umount	2024-09-04 13:14:53 +02:00
binfmt_script.c
block_dev.c	block: Don't invalidate pagecache for invalid falloc modes	2024-01-08 11:29:48 +01:00
buffer.c	fs/buffer: fix use-after-free when call bh_read() helper	2025-08-28 16:21:32 +02:00
char_dev.c	chardev: fix error handling in cdev_device_add()	2023-01-18 11:41:25 +01:00
compat.c
compat_binfmt_elf.c
compat_ioctl.c	lsm: new security_file_ioctl_compat() hook	2024-02-23 08:25:15 +01:00
coredump.c	coredump: hand a pidfd to the usermode coredump helper	2025-06-04 14:32:36 +02:00
d_path.c
dax.c	dax: fix cache flush on PMD-mapped pages	2022-06-14 18:11:41 +02:00
dcache.c	vfs: Don't leak disconnected dentries on umount	2025-10-29 14:00:01 +01:00
dcookies.c
direct-io.c	fs: direct-io: fix missing sdio->boundary	2021-04-14 08:24:11 +02:00
drop_caches.c
eventfd.c	eventfd: prevent underflow for eventfd semaphores	2023-09-23 10:59:40 +02:00
eventpoll.c	epoll: Add synchronous wakeup support for ep_poll_callback	2025-01-09 13:23:32 +01:00
exec.c	exec: Fix incorrect type for ret	2025-10-29 13:59:57 +01:00
fcntl.c	fs: Fix file_set_fowner LSM hook inconsistencies	2024-11-08 16:20:34 +01:00
fhandle.c	do_sys_name_to_handle(): use kzalloc() to fix kernel-infoleak	2024-03-26 18:22:13 -04:00
file.c	alloc_fdtable(): change calling conventions.	2025-08-28 16:21:37 +02:00
file_table.c	SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()	2022-05-25 09:14:34 +02:00
filesystems.c	fs/filesystems: Fix potential unsigned integer underflow in fs_name()	2025-06-27 11:02:50 +01:00
fs-writeback.c	writeback: fix call of incorrect macro	2023-05-17 11:35:58 +02:00
fs_context.c	fs: avoid empty option when generating legacy mount string	2023-07-27 08:37:25 +02:00
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fsopen.c
inode.c	vfs: fix race between evice_inodes() and find_inode()&iput()	2024-11-08 16:20:34 +01:00
internal.h	fs: Establish locking order for unrelated directories	2023-07-27 08:37:26 +02:00
io_uring.c	io_uring: fail NOP if non-zero op flags is passed in	2024-06-16 13:28:48 +02:00
ioctl.c
Kconfig	nfs: add missing selections of CONFIG_CRC32	2025-05-02 07:39:20 +02:00
Kconfig.binfmt
libfs.c	libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value	2023-01-18 11:40:55 +01:00
locks.c	filelock: Correct the filelock owner in fcntl_setlk/fcntl_setlk64	2024-09-04 13:15:02 +02:00
Makefile
mbcache.c	mbcache: Avoid nesting of cache->c_list_lock under bit locks	2023-01-18 11:41:59 +01:00
mount.h
mpage.c
namei.c	fuse: don't truncate cached, mutated symlink	2025-04-10 14:29:36 +02:00
namespace.c	fs: Add 'initramfs_options' to set initramfs mount options	2025-10-29 13:59:55 +01:00
no-block.c
nsfs.c
open.c	ftruncate: pass a signed offset	2024-07-05 09:08:31 +02:00
pipe.c	pipe: increase minimum default pipe size to 2 pages	2021-08-12 13:21:02 +02:00
pnode.c	pnode: terminate at peers of source	2023-01-18 11:41:44 +01:00
pnode.h	mount: fix mounting of detached mounts onto targets that reside on shared mounts	2021-03-17 17:03:33 +01:00
posix_acl.c
proc_namespace.c
read_write.c
readdir.c	readdir: make sure to verify directory entry for legacy interfaces too	2021-04-21 12:56:16 +02:00
select.c	fs/select: rework stack allocation hack for clang	2024-03-26 18:22:13 -04:00
seq_file.c	seq_file: disallow extremely large seq buffer allocations	2021-07-20 16:10:54 +02:00
signalfd.c	io_uring: disable polling pollfree files	2022-09-05 10:27:47 +02:00
splice.c	Revert "fs: check FMODE_LSEEK to control internal pipe splicing"	2022-10-17 17:24:32 +02:00
stack.c
stat.c	stat: fix inconsistency between struct stat and struct compat_stat	2022-04-27 13:50:48 +02:00
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-30 12:44:07 +01:00
super.c	fs: explicitly unregister per-superblock BDIs	2024-11-08 16:20:26 +01:00
sync.c	ovl: skip overlayfs superblocks at global sync	2023-12-08 08:44:27 +01:00
timerfd.c
userfaultfd.c	userfaultfd: open userfaultfds with O_RDONLY	2022-10-26 13:22:21 +02:00
utimes.c
xattr.c	fs: don't audit the capability check in simple_xattr_list()	2023-01-18 11:40:53 +01:00