Vincent Guittot
a399d23307
sched/core: Fix incorrect utilization accounting when switching to fair class ...
When a task switches to fair scheduling class, the period between now
and the last update of its utilization is accounted as running time
whatever happened during this period. This incorrect accounting applies
to the task and also to the task group branch.
When changing the property of a running task like its list of allowed
CPUs or its scheduling class, we follow the sequence:
- dequeue task
- put task
- change the property
- set task as current task
- enqueue task
The end of the sequence doesn't follow the normal sequence (as per
__schedule()) which is:
- enqueue a task
- then set the task as current task.
This incorrectordering is the root cause of incorrect utilization accounting.
Update the sequence to follow the right one:
- dequeue task
- put task
- change the property
- enqueue task
- set task as current task
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Morten.Rasmussen@arm.com
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bsegall@google.com
Cc: dietmar.eggemann@arm.com
Cc: linaro-kernel@lists.linaro.org
Cc: pjt@google.com
Cc: yuyang.du@intel.com
Link: http://lkml.kernel.org/r/1473666472-13749-8-git-send-email-vincent.guittot@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2016-09-30 11:03:27 +02:00
bpf: fix bpf_skb_in_cgroup helper naming
2016-08-12 21:53:33 -07:00
kconfig: tinyconfig: provide whole choice blocks to avoid warnings
2016-09-01 17:52:01 -07:00
mm/init: Add 'rodata=off' boot cmdline parameter to disable read-only kernel mappings
2016-02-22 08:51:37 +01:00
perf/core: Limit matching exclusive events to one PMU
2016-09-22 14:56:09 +02:00
gcov: add support for gcc version >= 6
2016-07-15 14:54:27 +09:00
genirq: Skip chained interrupt trigger setup if type is IRQ_TYPE_NONE
2016-09-19 11:31:36 +02:00
modules: add ro_after_init support
2016-08-04 10:16:55 +09:30
locking/pvqspinlock: Fix a bug in qstat_read()
2016-08-10 14:13:29 +02:00
PM / QoS: avoid calling cancel_delayed_work_sync() during early boot
2016-09-05 15:07:53 +02:00
printk/nmi: avoid direct printk()-s from __printk_nmi_flush()
2016-09-01 17:52:01 -07:00
Merge branch 'smp-hotplug-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-07-29 13:55:30 -07:00
sched/core: Fix incorrect utilization accounting when switching to fair class
2016-09-30 11:03:27 +02:00
tick/nohz: Fix softlockup on scheduler stalls in kvm guest
2016-09-02 10:25:40 +02:00
Al Viro has been looking at the tracefs code, and has pointed out
2016-09-25 18:40:13 -07:00
Merge branch 'stable-4.8' of git://git.infradead.org/users/pcmoore/audit
2016-07-29 17:54:17 -07:00
Merge branch 'stable-4.8' of git://git.infradead.org/users/pcmoore/audit
2016-07-29 17:54:17 -07:00
audit: cleanup prune_tree_thread
2016-04-04 09:46:47 -04:00
Merge branch 'stable-4.8' of git://git.infradead.org/users/pcmoore/audit
2016-09-01 15:55:56 -07:00
audit: add fields to exclude filter by reusing user filter
2016-06-27 11:01:00 -04:00
Merge branch 'stable-4.8' of git://git.infradead.org/users/pcmoore/audit
2016-07-29 17:54:17 -07:00
kernel: Add noaudit variant of ns_capable()
2016-06-06 20:16:18 +10:00
Merge branch 'for-4.8-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup
2016-09-27 16:43:11 -07:00
cgroup: Use lld instead of ld when printing pids controller events_limit
2016-06-21 15:03:36 -04:00
timers/core: Correct callback order during CPU hot plug
2016-07-28 18:56:22 +02:00
cpuset: fix non static symbol warning
2016-09-16 11:31:17 -04:00
cred: Reject inodes with invalid ids in set_create_file_as()
2016-06-30 18:05:09 -05:00
sched/core: Optimize __schedule()
2016-09-22 14:53:45 +02:00
Merge branch 'akpm' (patches from Andrew)
2016-09-01 18:23:22 -07:00
freezer, oom: check TIF_MEMDIE on the correct task
2016-07-28 16:07:41 -07:00
futex: Assume all mappings are private on !MMU systems
2016-07-29 18:44:14 +02:00
kernel/hung_task.c: use timeout diff when timeout is updated
2016-03-22 15:36:02 -07:00
powerpc updates for 4.8 #2
2016-08-05 09:00:54 -04:00
kallsyms: add support for relative offsets in kallsyms address table
2016-03-15 16:55:16 -07:00
kernel/kcov: unproxify debugfs file's fops
2016-06-15 04:56:35 -07:00
kexec: allow architectures to override boot mapping
2016-08-02 19:35:27 -04:00
kexec: add restriction on kexec_load() segment sizes
2016-08-02 19:35:31 -04:00
kexec: fix double-free when failing to relocate the purgatory
2016-09-01 17:52:01 -07:00
kexec: add a kexec_crash_loaded() function
2016-08-02 19:35:30 -04:00
sched/debug: Make schedstats a runtime tunable that is disabled by default
2016-02-09 11:54:23 +01:00
ELF/MIPS build fix
2016-05-23 17:04:14 -07:00
mm: fix cache mode of dax pmd mappings
2016-09-09 17:34:46 -07:00
Removed the MODULE_SIG_FORCE-means-no-MODULE_FORCE_LOAD patch.
2016-08-04 09:14:38 -04:00
KEYS: Move the point of trust determination to __key_link()
2016-04-11 22:43:43 +01:00
cgroup: introduce cgroup namespaces
2016-02-16 13:04:58 -05:00
kernel/padata.c: hide unused functions
2016-05-19 19:12:14 -07:00
kexec: use core_param for crash_kexec_post_notifiers boot option
2016-08-02 19:35:29 -04:00
remove lots of IS_ERR_VALUE abuses
2016-05-27 15:26:11 -07:00
profile: Convert to hotplug state machine
2016-07-15 10:41:42 +02:00
tree-wide: replace config_enabled() with IS_ENABLED()
2016-08-04 08:50:07 -04:00
relay: add global mode support for buffer-only channels
2016-08-02 19:35:41 -04:00
/proc/iomem: only expose physical resource addresses to privileged users
2016-04-14 12:56:09 -07:00
seccomp: Fix tracer exit notifications during fatal signals
2016-08-30 16:12:46 -07:00
signals: Use hrtimer for sigtimedwait()
2016-07-07 10:35:07 +02:00
Merge branch 'smp-hotplug-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-07-29 13:55:30 -07:00
sched/core: Do not use smp_processor_id() with preempt enabled in smpboot_thread_fn()
2016-09-22 12:28:00 +02:00
cpu/hotplug: Create hotplug threads
2016-03-01 20:36:56 +01:00
arch, ftrace: for KASAN put hard/soft IRQ entries into separate sections
2016-03-25 16:37:42 -07:00
stop_machine: Avoid a sleep and wakeup in stop_one_cpu()
2016-09-22 14:53:45 +02:00
prctl: make PR_SET_THP_DISABLE wait for mmap_sem killable
2016-05-23 17:04:14 -07:00
sysctl: handle error writing UINT_MAX to u32 fields
2016-08-26 17:39:35 -07:00
kernel/sysctl_binary.c: use generic UUID library
2016-05-20 17:58:30 -07:00
task_work: use READ_ONCE/lockless_dereference, avoid pi_lock if !task_works
2016-08-02 19:35:02 -04:00
taskstats: use the libnl API to align nlattr on 64-bit
2016-04-23 20:13:25 -04:00
torture: Stop onoff task if there is only one cpu
2016-06-14 16:03:28 -07:00
kernel/...: convert pr_warning to pr_warn
2016-03-22 15:36:02 -07:00
time, acct: Drop irq save & restore from __acct_update_integrals()
2016-02-29 09:53:09 +01:00
fs: Limit file caps to the user namespace of the super block
2016-06-24 10:40:31 -05:00
Revert "perf/x86/intel, watchdog: Switch NMI watchdog to ref cycles on x86"
2016-07-10 20:58:36 +02:00
Merge branch 'smp-hotplug-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-07-29 13:55:30 -07:00
sched/core: Get rid of 'cpu' argument in wq_worker_sleeping()
2016-03-02 10:28:47 -05:00
a399d23307