Peter Senna Tschudin
bf6445631c
perf tools: Bool functions shouldn't return -1
...
Returning a negative value for a boolean function seem to have the
undesired effect of returning true. Replace -1 by false in a
bool-returning function.
The diff of the .s file before and after the change (for x86_64):
3907c3907
< movl $1, %ebx
---
> xorl %ebx, %ebx
while if -1 is replaced by true, the diff is empty.
This issue was found by the following Coccinelle semantic patch:
<smpl>
@@
identifier f;
constant C;
typedef bool;
@@
bool f (...){
<+...
* return -C;
...+>
}
</smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Matt Fleming <matt.fleming@intel.com>
Cc: Milos Vyletel <milos@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1442484533-19742-1-git-send-email-peter.senna@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2015-09-17 15:31:52 -03:00
..
arch
perf tools: Fix link time error with sample_reg_masks on non x86
2015-09-01 13:04:41 -03:00
bench
perf bench futex: Add lock_pi stresser
2015-07-20 17:49:51 -03:00
config
tools build: Add test for presence of __get_cpuid() gcc builtin
2015-09-17 13:14:35 -03:00
Documentation
perf record: Add ability to name registers to record
2015-08-31 18:01:33 -03:00
python
perf python: Make twatch.py use soft dummy event, freq=0
2015-07-29 10:51:45 -03:00
scripts
perf scripts python: Add new compaction-times script
2015-08-28 14:53:40 -03:00
tests
perf tests: Fix software clock events test setting maps
2015-09-15 11:04:49 -03:00
trace/strace /groups
perf trace: Support 'strace' syscall event groups
2015-07-20 15:16:32 -03:00
ui
perf top: Fix segfault pressing -> with no hist entries
2015-09-14 15:10:41 -03:00
util
perf tools: Bool functions shouldn't return -1
2015-09-17 15:31:52 -03:00
.gitignore
perf tools: Add Intel PT instruction decoder
2015-08-17 11:11:36 -03:00
Build
perf trace: Support 'strace' syscall event groups
2015-07-20 15:16:32 -03:00
builtin-annotate.c
perf annotate: Reset the dso find_symbol cache when removing symbols
2015-08-24 13:33:14 -03:00
builtin-bench.c
perf bench futex: Add lock_pi stresser
2015-07-20 17:49:51 -03:00
builtin-buildid-cache.c
perf buildid: Introduce sysfs/filename__sprintf_build_id
2015-08-28 14:53:50 -03:00
builtin-buildid-list.c
perf buildid: Introduce sysfs/filename__sprintf_build_id
2015-08-28 14:53:50 -03:00
builtin-data.c
builtin-diff.c
perf callchain: Allow disabling call graphs per event
2015-08-12 13:20:28 -03:00
builtin-evlist.c
builtin-help.c
builtin-inject.c
perf tools: Add new PERF_RECORD_SWITCH event
2015-07-23 22:51:13 -03:00
builtin-kmem.c
perf kmem: Fill in the missing session freeing after an error occurs
2015-07-01 17:53:49 -03:00
builtin-kvm.c
perf kvm: Fill in the missing session freeing after an error occurs
2015-07-01 17:53:49 -03:00
builtin-list.c
builtin-lock.c
builtin-mem.c
perf mem: Fill in the missing session freeing after an error occurs
2015-07-01 17:53:49 -03:00
builtin-probe.c
perf probe: Delete an unnecessary check before the function call "strfilter__delete"
2015-07-06 08:58:36 -03:00
builtin-record.c
perf record: Add ability to name registers to record
2015-08-31 18:01:33 -03:00
builtin-report.c
perf report: Show call graph from reference events
2015-08-12 13:20:28 -03:00
builtin-sched.c
builtin-script.c
perf tools: Fix use of wrong event when processing exit events
2015-09-02 17:46:26 -03:00
builtin-stat.c
Merge branch 'perf/urgent' into perf/core, to pick up fixes
2015-08-31 10:25:26 +02:00
builtin-timechart.c
builtin-top.c
Merge branch 'perf/urgent' into perf/core, to pick up fixes before adding more changes
2015-08-20 11:48:56 +02:00
builtin-trace.c
perf trace: Add header with copyright and background info
2015-08-28 14:53:48 -03:00
builtin.h
command-list.txt
CREDITS
design.txt
Makefile
Makefile.perf
perf tools: Add Intel PT instruction decoder
2015-08-17 11:11:36 -03:00
MANIFEST
perf tools: Remove export.h from MANIFEST
2015-08-26 10:34:57 -03:00
perf-archive.sh
perf-completion.sh
perf-read-vdso.c
perf-sys.h
perf-with-kcore.sh
perf tools: Fix perf-with-kcore handling of arguments containing spaces
2015-08-06 16:48:27 -03:00
perf.c
perf tools: Do not change lib/api/fs/debugfs directly
2015-08-28 14:53:53 -03:00
perf.h
perf record: Add ability to name registers to record
2015-08-31 18:01:33 -03:00