Qais Yousef
c6a9060be5
sched/uclamp: Fix rq->uclamp_max not set on first enqueue ...
[ Upstream commit 315c4f884800c45cb6bd8c90422fad554a8b9588 ]
Commit d81ae8aac85c ("sched/uclamp: Fix initialization of struct
uclamp_rq") introduced a bug where uclamp_max of the rq is not reset to
match the woken up task's uclamp_max when the rq is idle.
The code was relying on rq->uclamp_max initialized to zero, so on first
enqueue
static inline void uclamp_rq_inc_id(struct rq *rq, struct task_struct *p,
enum uclamp_id clamp_id)
{
...
if (uc_se->value > READ_ONCE(uc_rq->value))
WRITE_ONCE(uc_rq->value, uc_se->value);
}
was actually resetting it. But since commit d81ae8aac85c changed the
default to 1024, this no longer works. And since rq->uclamp_flags is
also initialized to 0, neither above code path nor uclamp_idle_reset()
update the rq->uclamp_max on first wake up from idle.
This is only visible from first wake up(s) until the first dequeue to
idle after enabling the static key. And it only matters if the
uclamp_max of this task is < 1024 since only then its uclamp_max will be
effectively ignored.
Fix it by properly initializing rq->uclamp_flags = UCLAMP_FLAG_IDLE to
ensure uclamp_idle_reset() is called which then will update the rq
uclamp_max value as expected.
Fixes: d81ae8aac85c ("sched/uclamp: Fix initialization of struct uclamp_rq")
Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <Valentin.Schneider@arm.com>
Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lkml.kernel.org/r/20211202112033.1705279-1-qais.yousef@arm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-12-08 09:01:13 +01:00
bpf: Prevent increasing bpf_jit_limit above max
2021-11-17 09:48:20 +01:00
cgroup: Make rebind_subsystems() disable v2 controllers all at once
2021-11-17 09:48:34 +01:00
kdb: Make memory allocations more robust
2021-03-04 10:26:10 +01:00
dma-debug: fix sg checks in debug_dma_map_sg()
2021-10-27 09:54:25 +02:00
perf/core: Avoid put_page() when GUP fails
2021-11-26 10:47:22 +01:00
gcov: re-fix clang-11+ support
2021-04-14 08:24:10 +02:00
genirq/timings: Fix error return code in irq_timings_test_irqs()
2021-09-15 09:47:29 +02:00
locking/lockdep: Avoid RCU-induced noinstr fail
2021-11-17 09:48:28 +01:00
PM: hibernate: use correct mode for swsusp_close()
2021-12-01 09:23:33 +01:00
printk/console: Allow to disable console output by using console="" or console=null
2021-11-12 14:43:03 +01:00
rcu: Fix existing exp request check in sync_sched_exp_online_cleanup()
2021-11-17 09:48:33 +01:00
sched/uclamp: Fix rq->uclamp_max not set on first enqueue
2021-12-08 09:01:13 +01:00
Revert "posix-cpu-timers: Force next expiration recalc after itimer reset"
2021-09-16 12:56:13 +02:00
tracing: Check pid filtering when creating events
2021-12-01 09:23:34 +01:00
kbuild: update config_data.gz only when the content of .config is changed
2021-05-11 14:04:16 +02:00
audit: move put_tree() to avoid trim_trees refcount underflow and UAF
2021-09-03 10:08:16 +02:00
audit: CONFIG_CHANGE don't log internal bookkeeping as an event
2020-10-01 13:17:32 +02:00
audit: fix possible null-pointer dereference in audit_filter_rules
2021-10-27 09:54:27 +02:00
cpu/hotplug: Cure the cpusets trainwreck
2021-07-19 08:53:15 +02:00
kernel/cpu_pm: Fix uninitted local in cpu_pm
2020-06-22 09:31:22 +02:00
don't dump the threads that had been already exiting when zapped.
2020-11-18 19:20:31 +01:00
fail_function: Remove a redundant mutex unlock
2020-11-24 13:29:18 +01:00
mm/hugetlb: initialize hugetlb_usage in mm_init
2021-09-22 12:26:37 +02:00
mm, futex: fix shared futex pgoff on shmem huge page
2021-06-30 08:47:55 -04:00
kbuild: add variables for compression tools
2020-09-03 11:27:10 +02:00
kallsyms: Refactor kallsyms_show_value() to take cred
2020-07-16 08:16:44 +02:00
exec: Transform exec_update_mutex into a rw_semaphore
2021-01-09 13:44:55 +01:00
kernel: kexec: remove the lock operation of system_transition_mutex
2021-02-03 23:25:56 +01:00
kernel: kexec_file: fix error return code of kexec_calculate_store_digests()
2021-05-19 10:08:28 +02:00
kprobes: Limit max data_size of the kretprobe instances
2021-12-08 09:01:10 +01:00
kthread: Fix PF_KTHREAD vs to_kthread() race
2021-09-12 08:56:39 +02:00
kbuild: update config_data.gz only when the content of .config is changed
2021-05-11 14:04:16 +02:00
module: limit enabling module.sig_enforce
2021-06-30 08:47:42 -04:00
module: harden ELF info handling
2021-04-07 14:47:38 +02:00
module: harden ELF info handling
2021-04-07 14:47:38 +02:00
kernel/notifier.c: intercept duplicate registrations to avoid infinite loops
2020-10-01 13:17:23 +02:00
memcg: enable accounting for pids in nested pid namespaces
2021-09-22 12:26:37 +02:00
profiling: fix shift-out-of-bounds bugs
2021-09-26 14:07:09 +02:00
ptrace: make ptrace() fail if the tracee changed its pid unexpectedly
2021-05-26 12:05:15 +02:00
reboot: fix overflow parsing reboot cpu number
2020-11-18 19:20:30 +01:00
kernel/relay.c: fix memleak on destroy relay channel
2020-08-26 10:40:51 +02:00
/dev/mem: Revoke mappings when a driver claims the region
2020-06-24 17:50:35 +02:00
seccomp: Add missing return in non-void function
2021-03-04 10:26:45 +01:00
signal: Remove the bogus sigkill_pending in ptrace_stop
2021-11-17 09:48:24 +01:00
smp: Fix smp_call_function_single_async prototype
2021-05-14 09:44:33 +02:00
kthread: Extract KTHREAD_IS_PER_CPU
2021-02-07 15:35:49 +01:00
prctl: allow to setup brk for et_dyn executables
2021-09-26 14:07:08 +02:00
kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()
2020-10-01 13:17:10 +02:00
sysctl.c: fix underflow value setting risk in vm_table
2021-03-17 17:03:45 +01:00
tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing
2021-07-14 16:53:08 +02:00
usermodehelper: reset umask to default before executing user process
2020-10-14 10:32:58 +02:00
smp: Fix smp_call_function_single_async prototype
2021-05-14 09:44:33 +02:00
workqueue: make sysfs of unbound kworker cpumask more clever
2021-11-17 09:48:31 +01:00
c6a9060be5