Jeremy Kerr
27b70214fc
net: usb: ax88179_178a: fix packet alignment padding ...
[ Upstream commit e869e7a17798d85829fa7d4f9bbe1eebd4b2d3f6 ]
Using a AX88179 device (0b95:1790), I see two bytes of appended data on
every RX packet. For example, this 48-byte ping, using 0xff as a
payload byte:
04:20:22.528472 IP 192.168.1.1 > 192.168.1.2: ICMP echo request, id 2447, seq 1, length 64
0x0000: 000a cd35 ea50 000a cd35 ea4f 0800 4500
0x0010: 0054 c116 4000 4001 f63e c0a8 0101 c0a8
0x0020: 0102 0800 b633 098f 0001 87ea cd5e 0000
0x0030: 0000 dcf2 0600 0000 0000 ffff ffff ffff
0x0040: ffff ffff ffff ffff ffff ffff ffff ffff
0x0050: ffff ffff ffff ffff ffff ffff ffff ffff
0x0060: ffff 961f
Those last two bytes - 96 1f - aren't part of the original packet.
In the ax88179 RX path, the usbnet rx_fixup function trims a 2-byte
'alignment pseudo header' from the start of the packet, and sets the
length from a per-packet field populated by hardware. It looks like that
length field *includes* the 2-byte header; the current driver assumes
that it's excluded.
This change trims the 2-byte alignment header after we've set the packet
length, so the resulting packet length is correct. While we're moving
the comment around, this also fixes the spelling of 'pseudo'.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-30 15:36:45 -04:00
ACPI/IORT: Fix PMCG node single ID mapping handling
2020-06-22 09:30:54 +02:00
binderfs: use refcount for binder control devices too
2020-03-25 08:25:50 +01:00
libata: Use per port sync for detach
2020-06-24 17:50:47 +02:00
drivers: base: Fix NULL pointer exception in __platform_driver_probe() if a driver developer is foolish
2020-06-24 17:50:24 +02:00
ps3disk: use the default segment boundary
2020-06-24 17:50:15 +02:00
Bluetooth: hci_bcm: fix freeing not-requested IRQ
2020-06-22 09:31:18 +02:00
bus: sunxi-rsb: Return correct data when mixing 16-bit and 8-bit reads
2020-04-17 10:49:56 +02:00
/dev/mem: Revoke mappings when a driver claims the region
2020-06-24 17:50:35 +02:00
clk: ast2600: Fix AHB clock divider for A1
2020-06-24 17:50:35 +02:00
clocksource: dw_apb_timer_of: Fix missing clockevent timers
2020-06-22 09:30:55 +02:00
counter: 104-quad-8: Add lock guards - generic interface
2020-05-02 08:48:44 +02:00
cpufreq: Fix up cpufreq_boost_set_sw()
2020-06-17 16:40:33 +02:00
cpuidle: Fix three reference count leaks
2020-06-22 09:31:10 +02:00
crypto: omap-sham - add proper load balancing support for multicore
2020-06-24 17:50:38 +02:00
device-dax: don't leak kernel memory to user space after unloading kmem
2020-05-27 17:46:48 +02:00
PM / devfreq: Add missing locking while setting suspend_freq
2020-05-10 10:31:34 +02:00
dmaengine: owl: Use correct lock in owl_dma_get_pchan()
2020-05-27 17:46:43 +02:00
dma-buf: Fix SET_NAME ioctl uapi
2020-05-06 08:15:01 +02:00
EDAC/amd64: Add AMD family 17h model 60h PCI IDs
2020-06-22 09:31:20 +02:00
extcon: adc-jack: Fix an error handling path in 'adc_jack_probe()'
2020-06-24 17:50:36 +02:00
firmware: imx: scu: Fix possible memory leak in imx_scu_probe()
2020-06-24 17:50:30 +02:00
fpga: dfl: afu: Corrected error handling levels
2020-06-24 17:50:29 +02:00
gnss: sirf: fix error return code in sirf_probe()
2020-06-22 09:31:20 +02:00
gpio: pca953x: fix handling of automatic address incrementing
2020-06-24 17:50:22 +02:00
Revert "drm/amd/display: disable dcn20 abm feature for bring up"
2020-06-24 17:50:51 +02:00
HID: Add quirks for Trust Panora Graphic Tablet
2020-06-24 17:50:27 +02:00
Drivers: hv: vmbus: Always handle the VMBus messages on CPU0
2020-06-22 09:31:00 +02:00
hwmon: (k10temp) Add AMD family 17h model 60h PCI match
2020-06-22 09:31:19 +02:00
coresight: tmc: Fix TMC mode read in tmc_read_prepare_etb()
2020-06-24 17:50:15 +02:00
i2c: icy: Fix build with CONFIG_AMIGA_PCMCIA=n
2020-06-24 17:50:41 +02:00
ide: serverworks: potential overflow in svwks_set_pio_mode()
2020-02-24 08:36:53 +01:00
iio: bmp280: fix compensation of humidity
2020-06-24 17:50:12 +02:00
RDMA/iw_cxgb4: cleanup device debugfs entries on ULD remove
2020-06-24 17:50:33 +02:00
input: i8042 - Remove special PowerPC handling
2020-06-24 17:50:36 +02:00
iommu: Fix reference count leak in iommu_group_alloc.
2020-06-03 08:21:28 +02:00
ipack: tpci200: fix error return code in tpci200_register()
2020-05-27 17:46:47 +02:00
irqchip/mbigen: Free msi_desc on device teardown
2020-04-23 10:36:20 +02:00
leds: core: Fix warning message when init_data
2020-04-23 10:36:37 +02:00
drivers/macintosh: Fix memleak in windfarm_pm112 driver
2020-06-22 09:31:22 +02:00
mailbox: zynqmp-ipi: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()
2020-06-24 17:50:36 +02:00
bcache: fix potential deadlock problem in btree_gc_coalesce
2020-06-24 17:50:45 +02:00
media: ov5640: fix use of destroyed mutex
2020-06-22 09:31:19 +02:00
mfd: stmfx: Disable IRQ in suspend to avoid spurious interrupt
2020-06-24 17:50:33 +02:00
misc: xilinx-sdfec: improve get_user_pages_fast() error handling
2020-06-24 17:50:35 +02:00
mmc: sdhci-esdhc-imx: fix the mask for tuning start point
2020-06-22 09:31:10 +02:00
mtd: rawnand: tmio: Fix the probe error path
2020-06-22 09:31:26 +02:00
net: usb: ax88179_178a: fix packet alignment padding
2020-06-30 15:36:45 -04:00
NFC: st21nfca: add missed kfree_skb() in an error path
2020-06-10 20:24:54 +02:00
NTB: perf: Fix race condition when run with ntb_test
2020-06-24 17:50:41 +02:00
libnvdimm: Out of bounds read in __nd_ioctl()
2020-04-23 10:36:42 +02:00
nvme-pci: use simple suspend when a HMB is enabled
2020-06-24 17:50:43 +02:00
nvmem: qfprom: remove incorrect write support
2020-06-10 20:24:57 +02:00
of: Fix a refcounting bug in __of_attach_node_sysfs()
2020-06-24 17:50:35 +02:00
PCI: amlogic: meson: Don't use FAST_LINK_MODE to set up link
2020-06-24 17:50:31 +02:00
drivers/perf: hisi: Fix wrong value for all counters enable
2020-06-24 17:50:41 +02:00
drivers: phy: sr-usb: do not use internal fsm for USB2 phy init
2020-06-24 17:50:28 +02:00
pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
2020-06-24 17:50:38 +02:00
platform/x86: asus_wmi: Reserve more space for struct bias_args
2020-06-22 09:31:11 +02:00
power: supply: smb347-charger: IRQSTAT_D is volatile
2020-06-24 17:50:25 +02:00
pwm: jz4740: Enhance precision in calculation of duty cycle
2020-06-24 17:50:52 +02:00
rapidio: fix an error in get_user_pages_fast() error handling
2020-05-27 17:46:48 +02:00
regulator: qcom-rpmh: Fix typos in pm8150 and pm8150l
2020-06-22 09:30:58 +02:00
remoteproc: qcom_q6v5_mss: map/unmap mpss segments before/after use
2020-06-24 17:50:13 +02:00
reset: uniphier: Add SCSSI reset control for each channel
2020-02-24 08:36:41 +01:00
rtc: rv3028: Add missed check for devm_regmap_init_i2c()
2020-06-24 17:50:36 +02:00
s390/qdio: put thinint indicator after early error
2020-06-24 17:50:22 +02:00
scsi: ufs-bsg: Fix runtime PM imbalance on error
2020-06-24 17:50:47 +02:00
slimbus: ngd: get drvdata from correct device
2020-06-24 17:50:22 +02:00
soc/tegra: pmc: Select GENERIC_PINCONF
2020-06-22 09:31:22 +02:00
soundwire: slave: don't init debugfs on device registration error
2020-06-24 17:50:23 +02:00
spi: dw: Return any value retrieved from the dma_transfer callback
2020-06-22 09:31:10 +02:00
staging: sm750fb: add missing case while setting FB_VISUAL
2020-06-24 17:50:24 +02:00
scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()
2020-06-24 17:50:34 +02:00
thermal/drivers/ti-soc-thermal: Avoid dereferencing ERR_PTR
2020-06-24 17:50:23 +02:00
thunderbolt: Prevent crash if non-active NVMem file is read
2020-02-28 17:22:13 +01:00
tty: n_gsm: Fix bogus i++ in gsm_data_kick
2020-06-24 17:50:29 +02:00
usb/ehci-platform: Set PM runtime as active on resume
2020-06-24 17:50:44 +02:00
vfio/mdev: Fix reference count leak in add_mdev_supported_type
2020-06-24 17:50:36 +02:00
scsi: vhost: Notify TCM about the maximum sg entries supported per command
2020-06-24 17:50:17 +02:00
backlight: lp855x: Ensure regulators are disabled on probe failure
2020-06-24 17:50:09 +02:00
virtio_ring: Fix mem leak with vring_new_virtqueue()
2020-03-18 07:17:55 +01:00
visorbus: fix uninitialized variable access
2020-02-24 08:36:47 +01:00
vme: bridges: reduce stack usage
2020-02-24 08:36:48 +01:00
w1: omap-hdq: cleanup to add missing newline for some dev_dbg
2020-06-22 09:31:26 +02:00
watchdog: da9062: No need to ping manually before setting timeout
2020-06-24 17:50:32 +02:00
xen/pvcalls-back: test for errors when calling backend_connect()
2020-06-17 16:40:38 +02:00
27b70214fc