Arnd Bergmann
0e9207b054
scsi: mylex: Fix sysfs buffer lengths
...
[ Upstream commit 1197c5b2099f716b3de327437fb50900a0b936c9 ]
The myrb and myrs drivers use an odd way of implementing their sysfs files,
calling snprintf() with a fixed length of 32 bytes to print into a page
sized buffer. One of the strings is actually longer than 32 bytes, which
clang can warn about:
drivers/scsi/myrb.c:1906:10: error: 'snprintf' will always be truncated; specified size is 32, but format string expands to at least 34 [-Werror,-Wformat-truncation]
drivers/scsi/myrs.c:1089:10: error: 'snprintf' will always be truncated; specified size is 32, but format string expands to at least 34 [-Werror,-Wformat-truncation]
These could all be plain sprintf() without a length as the buffer is always
long enough. On the other hand, sysfs files should not be overly long
either, so just double the length to make sure the longest strings don't
get truncated here.
Fixes: 7726618639 ("scsi: myrs: Add Mylex RAID controller (SCSI interface)")
Fixes: 081ff398c5 ("scsi: myrb: Add Mylex RAID controller (block interface)")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240326223825.4084412-8-arnd@kernel.org
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-13 12:51:36 +02:00
..
aacraid
aic7xxx
aic94xx
arcmsr
arm
be2iscsi
scsi: be2iscsi: Fix a memleak in beiscsi_init_wrb_handle()
2023-12-13 18:18:13 +01:00
bfa
scsi: bfa: Fix function pointer type mismatch for hcb_qe->cbfn
2024-03-26 18:22:23 -04:00
bnx2fc
scsi: bnx2fc: Fix skb double free in bnx2fc_rcv()
2024-01-08 11:29:46 +01:00
bnx2i
csiostor
scsi: csiostor: Avoid function pointer casts
2024-03-26 18:22:23 -04:00
cxgbi
cxlflash
device_handler
scsi: scsi_dh_alua: Fix memleak for 'qdata' in alua_activate()
2023-04-05 11:16:36 +02:00
dpt
esas2r
fcoe
scsi: Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"
2024-02-23 08:25:10 +01:00
fnic
scsi: fnic: Return error if vmalloc() failed
2024-01-25 14:34:25 -08:00
hisi_sas
scsi: hisi_sas: Replace with standard error code return value
2024-01-25 14:34:25 -08:00
ibmvscsi
ibmvscsi_tgt
isci
scsi: isci: Fix an error code problem in isci_io_request_build()
2024-02-23 08:25:04 +01:00
libfc
scsi: libfc: Fix up timeout error in fc_fcp_rec_error()
2024-02-23 08:24:58 +01:00
libsas
lpfc
scsi: lpfc: Correct size for wqe for memset()
2024-04-13 12:51:32 +02:00
megaraid
scsi: megaraid_sas: Increase register read retry rount from 3 to 30 for selected registers
2023-11-28 16:50:18 +00:00
mpt3sas
scsi: mpt3sas: Prevent sending diag_reset when the controller is ready
2024-03-26 18:22:13 -04:00
mvsas
pcmcia
pm8001
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
qedf
scsi: qedf: Do not touch __user pointer in qedf_dbg_fp_int_cmd_read() directly
2023-09-23 10:59:50 +02:00
qedi
scsi: qedi: Fix potential deadlock on &qedi_percpu->p_work_lock
2023-09-23 10:59:39 +02:00
qla2xxx
scsi: qla2xxx: Fix command flush on cable pull
2024-04-13 12:51:32 +02:00
qla4xxx
scsi: qla4xxx: Add length check when parsing nlattrs
2023-09-23 10:59:49 +02:00
smartpqi
snic
scsi: snic: Fix double free in snic_tgt_create()
2023-08-30 16:27:27 +02:00
sym53c8xx_2
ufs
scsi: ufs: core: Leave space for '\0' in utf8 desc string
2023-11-20 10:30:13 +01:00
.gitignore
3w-9xxx.c
3w-9xxx.h
3w-sas.c
3w-sas.h
3w-xxxx.c
scsi: 3w-xxxx: Add error handling for initialization failure in tw_probe()
2023-07-27 08:37:16 +02:00
3w-xxxx.h
53c700.c
scsi: 53c700: Check that command slot is not NULL
2023-08-16 18:19:25 +02:00
53c700.h
53c700.scr
53c700_d.h_shipped
a100u2w.c
a100u2w.h
a2091.c
a2091.h
a3000.c
a3000.h
a4000t.c
advansys.c
aha152x.c
aha152x.h
aha1542.c
aha1542.h
aha1740.c
aha1740.h
am53c974.c
atari_scsi.c
atp870u.c
atp870u.h
BusLogic.c
BusLogic.h
bvme6000_scsi.c
ch.c
constants.c
dc395x.c
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
dc395x.h
dmx3191d.c
dpt_i2o.c
scsi: dpt_i2o: Do not process completions with invalid addresses
2023-06-09 10:29:04 +02:00
dpti.h
scsi: dpt_i2o: Remove broken pass-through ioctl (I2OUSERCMD)
2023-06-09 10:29:03 +02:00
esp_scsi.c
esp_scsi.h
fdomain.c
fdomain.h
fdomain_isa.c
fdomain_pci.c
FlashPoint.c
g_NCR5380.c
gdth.c
gdth.h
gdth_ioctl.h
gdth_proc.c
gdth_proc.h
gvp11.c
gvp11.h
hosts.c
scsi: core: Fix unremoved procfs host directory regression
2024-04-13 12:51:32 +02:00
hpsa.c
hpsa.h
hpsa_cmd.h
hptiop.c
hptiop.h
imm.c
imm.h
initio.c
initio.h
ipr.c
scsi: ipr: Work around fortify-string warning
2023-03-11 16:44:13 +01:00
ipr.h
ips.c
ips.h
iscsi_boot_sysfs.c
iscsi_tcp.c
iscsi_tcp.h
jazz_esp.c
Kconfig
scsi: jazz_esp: Only build if SCSI core is builtin
2024-03-01 13:13:37 +01:00
lasi700.c
libiscsi.c
libiscsi_tcp.c
mac53c94.c
mac53c94.h
mac_esp.c
mac_scsi.c
Makefile
megaraid.c
scsi: megaraid: Fix mega_cmd_done() CMDID_INT_CMDS
2023-05-17 11:35:41 +02:00
megaraid.h
mesh.c
mesh.h
mvme16x_scsi.c
mvme147.c
mvme147.h
mvumi.c
mvumi.h
myrb.c
scsi: mylex: Fix sysfs buffer lengths
2024-04-13 12:51:36 +02:00
myrb.h
myrs.c
scsi: mylex: Fix sysfs buffer lengths
2024-04-13 12:51:36 +02:00
myrs.h
ncr53c8xx.c
ncr53c8xx.h
NCR5380.c
NCR5380.h
nsp32.c
nsp32.h
nsp32_debug.c
nsp32_io.h
pmcraid.c
pmcraid.h
ppa.c
ppa.h
ps3rom.c
qla1280.c
qla1280.h
qlogicfas.c
qlogicfas408.c
qlogicfas408.h
qlogicpti.c
qlogicpti.h
raid_class.c
scsi: core: raid_class: Remove raid_component_add()
2023-08-30 16:27:27 +02:00
script_asm.pl
scsi.c
scsi: core: Improve scsi_vpd_inquiry() checks
2023-04-26 11:24:03 +02:00
scsi.h
scsi_common.c
scsi_debug.c
scsi_debugfs.c
scsi_debugfs.h
scsi_devinfo.c
scsi: core: Add BLIST_SKIP_VPD_PAGES for SKhynix H28U74301AMR
2023-04-05 11:16:40 +02:00
scsi_dh.c
scsi_error.c
scsi_ioctl.c
scsi_lib.c
scsi: core: Decrease scsi_device's iorequest_cnt if dispatch failed
2023-06-09 10:28:58 +02:00
scsi_lib_dma.c
scsi_logging.c
scsi_logging.h
scsi_netlink.c
scsi_pm.c
scsi_priv.h
scsi_proc.c
scsi: core: Fix legacy /proc parsing buffer overflow
2023-08-16 18:19:24 +02:00
scsi_sas_internal.h
scsi_scan.c
scsi_sysctl.c
scsi_sysfs.c
scsi_trace.c
scsi_transport_api.h
scsi_transport_fc.c
scsi_transport_iscsi.c
scsi: iscsi: Add strlen() check in iscsi_if_set{_host}_param()
2023-09-23 10:59:49 +02:00
scsi_transport_sas.c
scsi_transport_spi.c
scsi_transport_srp.c
scsicam.c
sd.c
sd.h
sd_dif.c
sd_zbc.c
sense_codes.h
ses.c
scsi: ses: Handle enclosure with just a primary component gracefully
2023-04-20 12:07:32 +02:00
sg.c
sgiwd93.c
sim710.c
sni_53c710.c
sr.c
sr.h
sr_ioctl.c
sr_vendor.c
st.c
st.h
st_options.h
stex.c
scsi: stex: Fix gcc 13 warnings
2023-06-09 10:29:00 +02:00
storvsc_drv.c
scsi: storvsc: Always set no_report_opcodes
2023-09-23 10:59:39 +02:00
sun3_scsi.c
sun3_scsi_vme.c
sun3x_esp.c
sun_esp.c
virtio_scsi.c
vmw_pvscsi.c
vmw_pvscsi.h
wd33c93.c
wd33c93.h
wd719x.c
wd719x.h
xen-scsifront.c
zalon.c
zorro7xx.c
zorro_esp.c