Mark Brown
eb29a5cc0b
revert "drivers/video/s3c-fb.c: fix clock setting for Samsung SoC Framebuffer"
...
Fix divide by zero and broken output. Commit 600ce1a0fa ("fix clock
setting for Samsung SoC Framebuffer") introduced a mandatory refresh
parameter to the platform data for the S3C framebuffer but did not
introduce any validation code, causing existing platforms (none of which
have refresh set) to divide by zero whenever the framebuffer is
configured, generating warnings and unusable output.
Ben Dooks noted several problems with the patch:
- The platform data supplies the pixclk directly and should already
have taken care of the refresh rate.
- The addition of a window ID parameter doesn't help since only the
root framebuffer can control the pixclk.
- pixclk is specified in picoseconds (rather than Hz) as the patch
assumed.
and suggests reverting the commit so do that. Without fixing this no
mainline user of the driver will produce output.
[akpm@linux-foundation.org: don't revert the correct bit]
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: InKi Dae <inki.dae@samsung.com>
Cc: Kyungmin Park <kmpark@infradead.org>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-01-16 12:15:40 -08:00
..
aty
tree-wide: fix assorted typos all over the place
2009-12-04 15:39:55 +01:00
backlight
omap1: Fix compile for omap1_bl.c
2010-01-08 10:29:06 -08:00
console
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2009-12-09 19:43:33 -08:00
display
tree-wide: convert open calls to remove spaces to skip_spaces() lib function
2009-12-15 08:53:32 -08:00
geode
lxfb: add copyright/license info
2009-12-16 07:20:02 -08:00
i810
i810fb: fix stack exploding
2009-12-16 07:20:02 -08:00
intelfb
intelfb: fix setting of active pipe with LVDS displays
2009-12-16 07:20:05 -08:00
kyro
logo
fbdev: move logo externs to header file
2009-06-16 19:47:57 -07:00
matrox
matroxfb: fix problems with display stability
2009-12-16 07:20:05 -08:00
mb862xx
mb862xxfb: add acceleration support for Coral-P/Coral-PA. * imageblt * copyarea * fillrect
2009-12-16 07:20:01 -08:00
mbx
msm
drivers/video/msm: update to new kernel
2009-11-12 07:26:00 -08:00
nvidia
nvidiafb: fix boot-time printk string
2009-06-23 12:50:05 -07:00
omap
video/omap: add __init/__exit macros to drivers/video/omap/lcd_htcherald.c
2010-01-11 14:45:25 +02:00
omap2
OMAP: DSS2: OMAPFB: fix crash when panel driver was not loaded
2010-01-12 12:10:55 +02:00
pnx4008
riva
savage
savagefb: fix blanking mode on CRT display
2009-11-12 07:25:56 -08:00
sis
fbdev: TV_PALN bit set twice in sisfb_detect_VB_connect()
2009-12-16 07:20:01 -08:00
vermilion
via
viafb: fix acceleration for some chips
2010-01-16 12:15:37 -08:00
68328fb.c
68328fb: fix cmap memory leaks
2009-04-01 08:59:31 -07:00
acornfb.c
acornfb: remove fb_mmap function
2009-06-16 19:47:59 -07:00
acornfb.h
amba-clcd.c
Remove multiple KERN_ prefixes from printk formats
2009-07-08 10:30:03 -07:00
amifb.c
amifb: check fb_alloc_cmap return value and handle failure properly
2009-04-01 08:59:31 -07:00
arcfb.c
arkfb.c
arkfb: fix misplaced parentheses
2009-04-01 08:59:32 -07:00
asiliantfb.c
asiliantfb: add missing return statement
2009-04-21 13:41:47 -07:00
atafb.c
Revert "fbdev: atafb - add palette register check"
2009-12-17 07:20:30 -08:00
atafb.h
atafb_iplan2p2.c
atafb_iplan2p4.c
atafb_iplan2p8.c
atafb_mfb.c
atafb_utils.h
atmel_lcdfb.c
Merge branch 'for-next' into for-linus
2009-12-07 18:36:35 +01:00
au1100fb.c
drivers/video: add kmalloc NULL tests
2009-09-23 07:39:56 -07:00
au1100fb.h
au1200fb.c
platform driver: fix incorrect use of 'platform_bus_type' with 'struct device_driver'
2009-03-24 16:38:25 -07:00
au1200fb.h
bf54x-lq043fb.c
fbdev: bf54x-lq043fb: use kzalloc over kmalloc/memset
2009-06-16 19:48:03 -07:00
bfin-lq035q1-fb.c
fbdev: bfin-lq035q1-fb: new Blackfin Landscape LCD EZ-Extender driver
2009-12-16 07:20:01 -08:00
bfin-t350mcqb-fb.c
fbdev: bfin-t350mcqb-fb: fix LCD dimensions
2009-12-16 07:20:01 -08:00
broadsheetfb.c
fb-defio: Inhibit VM_IO flag to be set on vmalloc-ed framebuffers.
2009-12-03 17:30:42 -08:00
bt431.h
bt455.h
bw2.c
bw2: use standard fields for framebuffer physical address and length
2009-06-16 04:56:30 -07:00
c2p.h
c2p_core.h
c2p_iplan2.c
c2p_planar.c
carminefb.c
carminefb: fix possible access beyond end of carmine_modedb[]
2009-06-16 19:47:59 -07:00
carminefb.h
carminefb_regs.h
cfbcopyarea.c
trivial: remove unnecessary semicolons
2009-09-21 15:14:58 +02:00
cfbfillrect.c
fbdev: fix fillrect for 24bpp modes
2009-05-06 16:36:10 -07:00
cfbimgblt.c
cg3.c
cg3: use standard fields for framebuffer physical address and length
2009-06-16 04:56:34 -07:00
cg6.c
cg6: use standard fields for framebuffer physical address and length
2009-06-16 04:56:35 -07:00
cg14.c
cg14: use standard fields for framebuffer physical address and length
2009-06-16 04:56:31 -07:00
chipsfb.c
chipsfb: remove redundant assignment
2009-06-16 19:47:58 -07:00
cirrusfb.c
cirrusfb: do not allow unsupported pixel depth
2009-04-13 15:04:30 -07:00
clps711xfb.c
clps711xfb: convert to proc_fops
2009-12-16 07:20:04 -08:00
cobalt_lcdfb.c
Update Yoichi Yuasa's e-mail address
2009-07-03 15:45:29 +01:00
controlfb.c
controlfb.h
cyber2000fb.c
VIDEO: cyberpro: pci_request_regions needs a persistent name
2009-12-24 18:34:09 +00:00
cyber2000fb.h
da8xx-fb.c
davinci: fb: add framebuffer blank operation
2009-12-16 07:20:05 -08:00
dnfb.c
edid.h
efifb.c
fbdev: add support for handoff from firmware to hw framebuffers
2009-06-16 19:48:00 -07:00
ep93xx-fb.c
fbdev: add palette register check to several drivers
2009-12-16 07:20:01 -08:00
epson1355fb.c
fb_ddc.c
fb_defio.c
Merge branch 'xen/fbdev' of git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen
2009-12-10 09:34:40 -08:00
fb_draw.h
fbdev: fix fillrect for 24bpp modes
2009-05-06 16:36:10 -07:00
fb_notify.c
fb_sys_fops.c
fbcmap.c
fbcvt.c
fbmem.c
Merge branch 'drm-next' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6
2009-09-30 08:03:00 -07:00
fbmon.c
fbmon: work around compiler bug in gcc-2.4.2
2009-07-22 08:49:22 -07:00
fbsysfs.c
Revert "fb: Initialize fb_info mutexes in framebuffer_alloc()"
2009-07-08 09:20:11 -07:00
ffb.c
fm2fb.c
fsl-diu-fb.c
fsl-diu-fb: fix regression with uninitalized fb_info->mm_lock mutex
2009-07-08 14:18:35 -07:00
fsl-diu-fb.h
g364fb.c
gbefb.c
Merge branch 'for-next' into for-linus
2009-12-07 18:36:35 +01:00
gxt4500.c
hecubafb.c
fb-defio: Inhibit VM_IO flag to be set on vmalloc-ed framebuffers.
2009-12-03 17:30:42 -08:00
hgafb.c
hitfb.c
const: constify remaining dev_pm_ops
2009-12-15 08:53:25 -08:00
hpfb.c
igafb.c
igafb: use framebuffer_alloc() to allocate fb_info struct
2009-06-16 19:47:58 -07:00
imsttfb.c
imxfb.c
trivial: remove unnecessary semicolons
2009-09-21 15:14:58 +02:00
Kconfig
fbdev: bfin-lq035q1-fb: new Blackfin Landscape LCD EZ-Extender driver
2009-12-16 07:20:01 -08:00
leo.c
leo: use standard fields for framebuffer physical address and length
2009-06-16 04:56:37 -07:00
macfb.c
macmodes.c
macmodes.h
Makefile
fbdev: bfin-lq035q1-fb: new Blackfin Landscape LCD EZ-Extender driver
2009-12-16 07:20:01 -08:00
maxinefb.c
fbdev: add palette register check to several drivers
2009-12-16 07:20:01 -08:00
metronomefb.c
fb-defio: Inhibit VM_IO flag to be set on vmalloc-ed framebuffers.
2009-12-03 17:30:42 -08:00
modedb.c
fbdev: drop custom atoi from drivers/video/modedb.c
2009-12-16 07:20:01 -08:00
mx3fb.c
i.MX31: fix framebuffer locking regressions
2009-08-07 10:39:56 -07:00
n411.c
neofb.c
offb.c
offb: Add support for framebuffer handoff to offb.
2009-12-09 17:09:29 +11:00
output.c
tree-wide: convert open calls to remove spaces to skip_spaces() lib function
2009-12-15 08:53:32 -08:00
p9100.c
p9100: use standard fields for framebuffer physical address and length
2009-06-16 04:56:38 -07:00
platinumfb.c
platinumfb: fix misplaced parenthesis
2009-09-23 07:39:50 -07:00
platinumfb.h
pm2fb.c
fbdev: use framebuffer_release() for freeing fb_info structures
2009-06-16 19:48:00 -07:00
pm3fb.c
pmag-aa-fb.c
pmag-ba-fb.c
fbdev: add palette register check to several drivers
2009-12-16 07:20:01 -08:00
pmagb-b-fb.c
fbdev: add palette register check to several drivers
2009-12-16 07:20:01 -08:00
ps3fb.c
powerpc/cell: Move CBE_IOPTE_* to <asm/cell-regs.h>
2009-08-20 10:29:26 +10:00
pvr2fb.c
sh: dma: Make PVR2 DMA configurable.
2009-03-17 09:30:36 +09:00
pxa168fb.c
pxa168fb: fix offset setting at initialization
2009-12-01 09:02:31 +08:00
pxa168fb.h
fb: add support of LCD display controller on pxa168/910 (base layer)
2009-06-13 00:09:09 +08:00
pxafb.c
[ARM] pxafb: fix building issue of incorrect reference
2009-12-29 14:11:27 +08:00
pxafb.h
q40fb.c
s1d13xxxfb.c
fbdev: s1d13xxxfb: add accelerated bitblt functions
2009-06-16 19:48:00 -07:00
s3c-fb.c
revert "drivers/video/s3c-fb.c: fix clock setting for Samsung SoC Framebuffer"
2010-01-16 12:15:40 -08:00
s3c2410fb.c
s3c2410fb: fix clockrate calculation
2009-09-23 07:39:56 -07:00
s3c2410fb.h
s3c-fb: CPUFREQ frequency scaling support
2009-06-16 19:47:59 -07:00
s3fb.c
s3fb: fix color component length for pseudocolor modes
2009-04-13 15:04:29 -07:00
sa1100fb.c
Nicolas Pitre has a new email address
2009-09-15 09:37:12 -07:00
sa1100fb.h
sa1100fb: fix color component length for pseudocolor modes
2009-04-13 15:04:29 -07:00
sbuslib.c
sbuslib.h
sgivwfb.c
sgivwfb: Make use of ARRAY_SIZE.
2009-12-04 15:39:52 +01:00
sh7760fb.c
fbdev: add mutex for fb_mmap locking
2009-06-30 18:56:00 -07:00
sh_mobile_lcdcfb.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6
2009-12-16 10:29:52 -08:00
skeletonfb.c
fbdev: fix color component field length documentation
2009-04-13 15:04:29 -07:00
sm501fb.c
sm501: implement acceleration features
2009-12-16 07:20:04 -08:00
sstfb.c
sstfb: check fb_alloc_cmap return value and handle failure properly
2009-04-01 08:59:30 -07:00
sticore.h
stifb.c
tree-wide: fix assorted typos all over the place
2009-12-04 15:39:55 +01:00
sunxvr500.c
sunxvr500: fix cmap memory leaks
2009-04-01 08:59:31 -07:00
sunxvr2500.c
svgalib.c
syscopyarea.c
sysfillrect.c
fbdev: fix fillrect for 24bpp modes
2009-05-06 16:36:10 -07:00
sysimgblt.c
tcx.c
tcx: use standard fields for framebuffer physical address and length
2009-06-16 19:48:00 -07:00
tdfxfb.c
tree-wide: fix assorted typos all over the place
2009-12-04 15:39:55 +01:00
tgafb.c
tgafb: fix cmap memory leak
2009-04-01 08:59:31 -07:00
tmiofb.c
drivers/video/tmiofb.c: fix uninitialised return value
2009-09-23 07:39:57 -07:00
tridentfb.c
tridentfb: delete acceleration Kconfig option
2009-04-01 08:59:34 -07:00
uvesafb.c
fb: remove fb_save_state() and fb_restore_state operations
2009-11-12 07:25:56 -08:00
valkyriefb.c
valkyriefb: check fb_alloc_cmap return value and handle failure properly
2009-04-01 08:59:31 -07:00
valkyriefb.h
vesafb.c
fbdev: add support for handoff from firmware to hw framebuffers
2009-06-16 19:48:00 -07:00
vfb.c
fbdev: fix color component field length documentation
2009-04-13 15:04:29 -07:00
vga16fb.c
vgastate.c
vt8623fb.c
tree-wide: fix assorted typos all over the place
2009-12-04 15:39:55 +01:00
w100fb.c
w100fb: fix regression with uninitalized fb_info->mm_lock mutex
2009-07-08 09:19:49 -07:00
w100fb.h
xen-fbfront.c
Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6
2009-12-11 12:18:16 -08:00
xilinxfb.c
fbdev/xilinxfb: Fix improper casting and tighen up probe path
2009-06-17 00:30:02 -06:00